From a9c128d2b26bfecca407035c306247df753a7cba Mon Sep 17 00:00:00 2001 From: qameta-ci Date: Mon, 8 Apr 2024 15:19:06 +0000 Subject: [PATCH 01/44] set next development version 2.28 --- gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index c5f5a795..872642fb 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,4 +1,4 @@ -version=2.27.0 +version=2.28-SNAPSHOT org.gradle.daemon=true org.gradle.parallel=true From 732399ad75afedcb7a845c8a2105408811929e16 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 8 May 2024 15:23:45 +0100 Subject: [PATCH 02/44] bump com.google.inject:guice from 5.1.0 to 7.0.0 (via #1003) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 69a89cf1..64c58eec 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -150,7 +150,7 @@ configure(libs) { dependencies { dependency("com.github.spotbugs:spotbugs:4.8.3") dependency("com.github.tomakehurst:wiremock:3.0.1") - dependency("com.google.inject:guice:5.1.0") + dependency("com.google.inject:guice:7.0.0") dependency("com.google.testing.compile:compile-testing:0.19") dependency("com.puppycrawl.tools:checkstyle:10.13.0") dependency("com.squareup.retrofit2:retrofit:2.9.0") From d960678b221f2bfaf92a553acd312c3b52bfdae0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 8 May 2024 15:24:20 +0100 Subject: [PATCH 03/44] bump protobufVersion from 3.22.4 to 4.26.1 (via #1027) --- allure-grpc/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-grpc/build.gradle.kts b/allure-grpc/build.gradle.kts index 1205a6ca..bcba01f3 100644 --- a/allure-grpc/build.gradle.kts +++ b/allure-grpc/build.gradle.kts @@ -9,7 +9,7 @@ description = "Allure gRPC Integration" val agent: Configuration by configurations.creating val grpcVersion = "1.57.2" -val protobufVersion = "3.22.4" +val protobufVersion = "4.26.1" dependencies { agent("org.aspectj:aspectjweaver") From a438edc848802beb4fbd058b50a6e59e8d1df212 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 8 May 2024 15:24:54 +0100 Subject: [PATCH 04/44] bump orgSlf4jVersion from 1.7.36 to 2.0.7 (via #903) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 64c58eec..cded9ca9 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -139,7 +139,7 @@ configure(libs) { apply(plugin = "java") apply(plugin = "java-library") - val orgSlf4jVersion = "1.7.36" + val orgSlf4jVersion = "2.0.7" val assertJVersion = "1.9.9.1" dependencyManagement { From e874ee26e5efef4b175d98ac58174ce0739c1047 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 9 May 2024 13:50:42 +0100 Subject: [PATCH 05/44] bump io.rest-assured:rest-assured from 5.3.1 to 5.4.0 (via #1043) --- allure-rest-assured/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-rest-assured/build.gradle.kts b/allure-rest-assured/build.gradle.kts index ba734a06..9fa2af59 100644 --- a/allure-rest-assured/build.gradle.kts +++ b/allure-rest-assured/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure Rest-Assured Integration" -val restAssuredVersion = "5.3.1" +val restAssuredVersion = "5.4.0" dependencies { api(project(":allure-attachments")) From cdd7b9b09e3cb6b91733f70030ac5de35d137dc3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 9 May 2024 13:51:03 +0100 Subject: [PATCH 06/44] bump org.postgresql:postgresql from 42.7.1 to 42.7.3 (via #1041) --- allure-jooq/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-jooq/build.gradle.kts b/allure-jooq/build.gradle.kts index d7aeab40..ef7c3516 100644 --- a/allure-jooq/build.gradle.kts +++ b/allure-jooq/build.gradle.kts @@ -15,7 +15,7 @@ dependencies { testImplementation(project(":allure-java-commons-test")) testImplementation(project(":allure-junit-platform")) testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine") - testRuntimeOnly("org.postgresql:postgresql:42.7.1") + testRuntimeOnly("org.postgresql:postgresql:42.7.3") } java { From c5ec96adf5147e0ba4b62a6c124b1b7bc891534a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 9 May 2024 13:51:22 +0100 Subject: [PATCH 07/44] bump orgSlf4jVersion from 2.0.7 to 2.0.13 (via #1042) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index cded9ca9..c16b5017 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -139,7 +139,7 @@ configure(libs) { apply(plugin = "java") apply(plugin = "java-library") - val orgSlf4jVersion = "2.0.7" + val orgSlf4jVersion = "2.0.13" val assertJVersion = "1.9.9.1" dependencyManagement { From aae1a575776a78fd55b0f7eeaa326dfc58d71358 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 10 May 2024 12:32:14 +0100 Subject: [PATCH 08/44] bump com.google.protobuf from 0.9.1 to 0.9.4 (via #1048) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 487d5b0a..6ad3ae34 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -56,7 +56,7 @@ pluginManagement { id("io.qameta.allure-download") version "2.11.2" id("io.qameta.allure-report") version "2.11.2" id("io.spring.dependency-management") version "1.1.0" - id("com.google.protobuf") version "0.9.1" + id("com.google.protobuf") version "0.9.4" id("com.github.spotbugs") version "6.0.6" kotlin("jvm") version "1.7.10" } From fad5f02f8d550cb90e79eac5751c067a432bd398 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 10 May 2024 15:55:31 +0100 Subject: [PATCH 09/44] bump org.apache.httpcomponents:httpclient from 4.5.13 to 4.5.14 (via #1046) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index c16b5017..c5becb4c 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -160,7 +160,7 @@ configure(libs) { dependency("javax.annotation:javax.annotation-api:1.3.2") dependency("net.sourceforge.pmd:pmd-java:6.55.0") dependency("org.apache.commons:commons-lang3:3.12.0") - dependency("org.apache.httpcomponents:httpclient:4.5.13") + dependency("org.apache.httpcomponents:httpclient:4.5.14") dependency("org.apache.httpcomponents.client5:httpclient5:5.2.1") dependency("org.aspectj:aspectjrt:${assertJVersion}") dependency("org.aspectj:aspectjweaver:${assertJVersion}") From 781ab098a8effb2338444d4143100ac9a7870f4c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 10 May 2024 15:55:50 +0100 Subject: [PATCH 10/44] bump io.spring.dependency-management from 1.1.0 to 1.1.5 (via #1047) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 6ad3ae34..1428a47d 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -55,7 +55,7 @@ pluginManagement { id("io.qameta.allure-aggregate-report") version "2.11.2" id("io.qameta.allure-download") version "2.11.2" id("io.qameta.allure-report") version "2.11.2" - id("io.spring.dependency-management") version "1.1.0" + id("io.spring.dependency-management") version "1.1.5" id("com.google.protobuf") version "0.9.4" id("com.github.spotbugs") version "6.0.6" kotlin("jvm") version "1.7.10" From ca68113c7ba8fcd2a733463bb6e99e77a9a4e4ae Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 28 May 2024 10:55:26 +0100 Subject: [PATCH 11/44] bump org.awaitility:awaitility from 4.2.0 to 4.2.1 (via #1050) --- allure-awaitility/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-awaitility/build.gradle.kts b/allure-awaitility/build.gradle.kts index 2426a93b..587ca030 100644 --- a/allure-awaitility/build.gradle.kts +++ b/allure-awaitility/build.gradle.kts @@ -2,7 +2,7 @@ description = "Allure Awaitlity Integration" val agent: Configuration by configurations.creating -val awaitilityVersion = "4.2.0" +val awaitilityVersion = "4.2.1" dependencies { agent("org.aspectj:aspectjweaver") From a85d0e3d10ca76553db53df44bfb020a81a92bb1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 21 Jun 2024 12:46:38 +0100 Subject: [PATCH 12/44] bump org.mockito:mockito-core from 5.10.0 to 5.12.0 (via #1054) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index c5becb4c..d5edada8 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -170,7 +170,7 @@ configure(libs) { dependency("org.hamcrest:hamcrest:2.2") dependency("org.jboss.resteasy:resteasy-client:6.2.1.Final") dependency("org.mock-server:mockserver-netty:5.15.0") - dependency("org.mockito:mockito-core:5.10.0") + dependency("org.mockito:mockito-core:5.12.0") dependency("org.slf4j:slf4j-api:${orgSlf4jVersion}") dependency("org.slf4j:slf4j-nop:${orgSlf4jVersion}") dependency("org.slf4j:slf4j-simple:${orgSlf4jVersion}") From 7f798f37321bb0c234276291d0b79b2acd28649e Mon Sep 17 00:00:00 2001 From: Dmitry Baev Date: Fri, 5 Jul 2024 16:09:15 +0100 Subject: [PATCH 13/44] fix(allure-karate): remove the code that causes the process to hang (fixes #1040, via #1065) --- .../io/qameta/allure/karate/AllureKarate.java | 85 ------------------- 1 file changed, 85 deletions(-) diff --git a/allure-karate/src/main/java/io/qameta/allure/karate/AllureKarate.java b/allure-karate/src/main/java/io/qameta/allure/karate/AllureKarate.java index 310d6c75..2c629a9f 100644 --- a/allure-karate/src/main/java/io/qameta/allure/karate/AllureKarate.java +++ b/allure-karate/src/main/java/io/qameta/allure/karate/AllureKarate.java @@ -26,7 +26,6 @@ import com.intuit.karate.core.StepResult; import io.qameta.allure.Allure; import io.qameta.allure.AllureLifecycle; -import io.qameta.allure.model.Attachment; import io.qameta.allure.model.Label; import io.qameta.allure.model.Link; import io.qameta.allure.model.Parameter; @@ -50,8 +49,6 @@ import java.util.Optional; import java.util.Set; import java.util.UUID; -import java.util.concurrent.locks.ReadWriteLock; -import java.util.concurrent.locks.ReentrantReadWriteLock; import java.util.stream.Collectors; import static io.qameta.allure.util.ResultsUtils.createLabel; @@ -71,11 +68,6 @@ public class AllureKarate implements RuntimeHook { private final AllureLifecycle lifecycle; - private final ReadWriteLock lock = new ReentrantReadWriteLock(); - - private final Map stepsAndTcUuids = new HashMap<>(); - private final Map stepAndUuids = new HashMap<>(); - private final List tcUuids = new ArrayList<>(); public AllureKarate() { @@ -221,14 +213,6 @@ public void afterStep(final StepResult result, }); lifecycle.stopStep(uuid); - if (stepResult.isFailed() - && sr.engine.getConfig().getDriverOptions() != null - && (Boolean) sr.engine.getConfig().getDriverOptions().get("screenshotOnFailure") - ) { - addToStepsAndTcUuids(uuid, lifecycle.getCurrentTestCase().get()); - addToStepAndUuids(uuid, step); - } - if (Objects.nonNull(result.getEmbeds())) { result.getEmbeds().forEach(embed -> { try (InputStream is = new BufferedInputStream(Files.newInputStream(embed.getFile().toPath()))) { @@ -248,30 +232,6 @@ public void afterStep(final StepResult result, @Override public void afterFeature(final FeatureRuntime fr) { - - if (!stepsAndTcUuids.isEmpty()) { - fr.result.getScenarioResults() - .forEach(sc -> { - if (Objects.nonNull(sc.getFailedStep())) { - getKeySetFromStepAndUuids().forEach(uuid -> { - if (getValueFromStepAndUuids(uuid) == sc.getFailedStep().getStep()) { - final List attachments = new ArrayList<>(); - sc.getFailedStep().getEmbeds().forEach(e -> attachments.add( - new Attachment() - .setSource(e.getFile().getPath()) - .setType(e.getResourceType().contentType) - .setName(e.getFile().getName()) - ) - ); - lifecycle.updateTestCase(getValueFromStepsAndTcUuids(uuid), result -> - result.setAttachments(attachments) - ); - } - }); - } - }); - } - tcUuids.forEach(lifecycle::writeTestCase); } @@ -321,49 +281,4 @@ private List getLinks(final List labels) { } return allureLinks; } - - private void addToStepsAndTcUuids(final String stepUuid, final String tcUuid) { - lock.writeLock().lock(); - try { - stepsAndTcUuids.put(stepUuid, tcUuid); - } finally { - lock.writeLock().unlock(); - } - } - - private void addToStepAndUuids(final String stepUuid, final Step step) { - lock.writeLock().lock(); - try { - stepAndUuids.put(stepUuid, step); - } finally { - lock.writeLock().unlock(); - } - } - - private String getValueFromStepsAndTcUuids(final String stepUuid) { - lock.readLock().lock(); - try { - return stepsAndTcUuids.get(stepUuid); - } finally { - lock.readLock().unlock(); - } - } - - private Step getValueFromStepAndUuids(final String stepUuid) { - lock.readLock().lock(); - try { - return stepAndUuids.get(stepUuid); - } finally { - lock.readLock().unlock(); - } - } - - private Set getKeySetFromStepAndUuids() { - lock.readLock().lock(); - try { - return stepAndUuids.keySet(); - } finally { - lock.readLock().unlock(); - } - } } From 71ec65c00035a0b7602715aef2bf52d879e98e6a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 17:18:30 +0100 Subject: [PATCH 14/44] bump io.github.gradle-nexus.publish-plugin from 1.1.0 to 2.0.0 (via #1057) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 1428a47d..8d3f7a00 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -50,7 +50,7 @@ pluginManagement { id("com.diffplug.spotless") version "6.11.0" id("com.github.johnrengelman.shadow") version "8.1.1" id("com.gradle.enterprise") version "3.12.5" - id("io.github.gradle-nexus.publish-plugin") version "1.1.0" + id("io.github.gradle-nexus.publish-plugin") version "2.0.0" id("io.qameta.allure-adapter") version "2.11.2" id("io.qameta.allure-aggregate-report") version "2.11.2" id("io.qameta.allure-download") version "2.11.2" From 5649230a11acbb3f83a5726fc59552fcc5e84929 Mon Sep 17 00:00:00 2001 From: Valery Yatsynovich Date: Fri, 5 Jul 2024 19:19:24 +0300 Subject: [PATCH 15/44] chore(allure-jsonunit): deprecate `AllureConfigurableJsonMatcher` in favor of `ConfigurableJsonMatcher` (via #1060) --- .../qameta/allure/jsonunit/AbstractJsonPatchMatcher.java | 9 ++++++++- .../allure/jsonunit/AllureConfigurableJsonMatcher.java | 2 ++ .../java/io/qameta/allure/jsonunit/JsonPatchMatcher.java | 7 ++++--- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AbstractJsonPatchMatcher.java b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AbstractJsonPatchMatcher.java index 6a940d4d..329dbc6c 100644 --- a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AbstractJsonPatchMatcher.java +++ b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AbstractJsonPatchMatcher.java @@ -20,13 +20,15 @@ import org.hamcrest.Matcher; import net.javacrumbs.jsonunit.core.Configuration; +import net.javacrumbs.jsonunit.core.ConfigurationWhen.ApplicableForPath; +import net.javacrumbs.jsonunit.core.ConfigurationWhen.PathsParam; import net.javacrumbs.jsonunit.core.Option; import net.javacrumbs.jsonunit.core.internal.Diff; import net.javacrumbs.jsonunit.core.internal.Options; import net.javacrumbs.jsonunit.core.listener.DifferenceListener; /** - * Сontains basic matcher functionality and implementation of methods for matching configuration. + * Contains basic matcher functionality and implementation of methods for matching configuration. * * @param the type */ @@ -54,6 +56,11 @@ public T when(final Option first, final Option... next) { return (T) this; } + public T when(final PathsParam pathsParam, final ApplicableForPath... applicableForPaths) { + this.configuration = this.configuration.when(pathsParam, applicableForPaths); + return (T) this; + } + public T withOptions(final Options options) { this.configuration = configuration.withOptions(options); return (T) this; diff --git a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AllureConfigurableJsonMatcher.java b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AllureConfigurableJsonMatcher.java index 07851666..3b95e334 100644 --- a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AllureConfigurableJsonMatcher.java +++ b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/AllureConfigurableJsonMatcher.java @@ -25,7 +25,9 @@ /** * @param the type of matcher * @see net.javacrumbs.jsonunit.ConfigurableJsonMatcher + * @deprecated Use {@link net.javacrumbs.jsonunit.ConfigurableJsonMatcher} */ +@Deprecated public interface AllureConfigurableJsonMatcher extends Matcher { AllureConfigurableJsonMatcher withTolerance(BigDecimal tolerance); diff --git a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java index b9f53b13..78bed71e 100644 --- a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java +++ b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java @@ -17,6 +17,7 @@ import io.qameta.allure.attachment.DefaultAttachmentProcessor; import io.qameta.allure.attachment.FreemarkerAttachmentRenderer; +import net.javacrumbs.jsonunit.ConfigurableJsonMatcher; import net.javacrumbs.jsonunit.core.listener.DifferenceListener; import org.hamcrest.Description; @@ -28,8 +29,8 @@ * @param the type */ @SuppressWarnings("unused") -public final class JsonPatchMatcher extends AbstractJsonPatchMatcher> - implements AllureConfigurableJsonMatcher { +public final class JsonPatchMatcher extends AbstractJsonPatchMatcher> + implements ConfigurableJsonMatcher { private final Object expected; @@ -37,7 +38,7 @@ private JsonPatchMatcher(final Object expected) { this.expected = expected; } - public static AllureConfigurableJsonMatcher jsonEquals(final Object expected) { + public static ConfigurableJsonMatcher jsonEquals(final Object expected) { return new JsonPatchMatcher(expected); } From 5edb2e29801b3390317461c952332d32bff4c563 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 17:52:52 +0100 Subject: [PATCH 16/44] bump net.sourceforge.pmd:pmd-java from 6.55.0 to 7.3.0 (via #1062) --- .../awaitility/AllureAwaitilityListener.java | 7 +++--- .../allure/awaitility/TemporalDuration.java | 5 +--- .../qameta/allure/cucumber4jvm/TagParser.java | 8 +++---- .../cucumber5jvm/AllureCucumber5Jvm.java | 11 ++------- .../qameta/allure/cucumber5jvm/TagParser.java | 8 +++---- .../cucumber6jvm/AllureCucumber6Jvm.java | 11 ++------- .../qameta/allure/cucumber6jvm/TagParser.java | 8 +++---- .../cucumber7jvm/AllureCucumber7Jvm.java | 11 ++------- .../qameta/allure/cucumber7jvm/TagParser.java | 8 +++---- .../testsourcemodel/TestSourcesModel.java | 2 +- .../JavaDocDescriptionsProcessor.java | 2 +- .../io/qameta/allure/grpc/AllureGrpc.java | 23 ++++++++----------- .../httpclient5/AllureHttpClient5Request.java | 5 ++-- .../AllureHttpClient5Response.java | 5 ++-- .../allure/internal/AllureThreadContext.java | 13 ++++++----- .../junitplatform/AllureJunitPlatform.java | 1 + .../io/qameta/allure/junit4/AllureJunit4.java | 1 - .../allure/junit4/AllureJunit4Utils.java | 5 +--- .../io/qameta/allure/junit5/AllureJunit5.java | 1 + .../java/io/qameta/allure/model/Stage.java | 2 +- .../java/io/qameta/allure/model/Status.java | 2 +- .../allure/selenide/AllureSelenide.java | 12 +++++----- build.gradle.kts | 2 +- .../quality-configs/checkstyle/checkstyle.xml | 14 ++++++----- gradle/quality-configs/pmd/pmd.xml | 13 ++++------- 25 files changed, 77 insertions(+), 103 deletions(-) diff --git a/allure-awaitility/src/main/java/io/qameta/allure/awaitility/AllureAwaitilityListener.java b/allure-awaitility/src/main/java/io/qameta/allure/awaitility/AllureAwaitilityListener.java index 93f6c0ee..01b793cf 100644 --- a/allure-awaitility/src/main/java/io/qameta/allure/awaitility/AllureAwaitilityListener.java +++ b/allure-awaitility/src/main/java/io/qameta/allure/awaitility/AllureAwaitilityListener.java @@ -77,7 +77,8 @@ public class AllureAwaitilityListener implements ConditionEvaluationListener lifecycle = new InheritableThreadLocal() { + private static final InheritableThreadLocal LIFECYCLE + = new InheritableThreadLocal() { @Override protected AllureLifecycle initialValue() { return Allure.getLifecycle(); @@ -85,7 +86,7 @@ protected AllureLifecycle initialValue() { }; public static AllureLifecycle getLifecycle() { - return lifecycle.get(); + return LIFECYCLE.get(); } /** @@ -250,7 +251,7 @@ public void exceptionIgnored(final IgnoredException ignoredException) { * @param allure allure lifecycle to set */ public static void setLifecycle(final AllureLifecycle allure) { - lifecycle.set(allure); + LIFECYCLE.set(allure); } } diff --git a/allure-awaitility/src/main/java/io/qameta/allure/awaitility/TemporalDuration.java b/allure-awaitility/src/main/java/io/qameta/allure/awaitility/TemporalDuration.java index b9f58879..d549ee81 100644 --- a/allure-awaitility/src/main/java/io/qameta/allure/awaitility/TemporalDuration.java +++ b/allure-awaitility/src/main/java/io/qameta/allure/awaitility/TemporalDuration.java @@ -60,10 +60,7 @@ public class TemporalDuration implements TemporalAccessor { @Override public boolean isSupported(final TemporalField field) { - if (!temporal.isSupported(field)) { - return false; - } - return temporal.getLong(field) - BASE.getLong(field) != 0L; + return temporal.isSupported(field) && temporal.getLong(field) - BASE.getLong(field) != 0L; } @Override diff --git a/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/TagParser.java b/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/TagParser.java index 0c7417c0..0c6f76e4 100644 --- a/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/TagParser.java +++ b/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/TagParser.java @@ -52,13 +52,13 @@ public boolean isKnown() { private boolean getStatusDetailByTag(final String tagName) { return scenario.getTags().stream() - .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)) - || feature.getTags().stream() - .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); + .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)) + || feature.getTags().stream() + .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); } public boolean isResultTag(final PickleTag tag) { - return Arrays.asList(new String[]{FLAKY, KNOWN, MUTED}) + return Arrays.asList(FLAKY, KNOWN, MUTED) .contains(tag.getName().toUpperCase()); } diff --git a/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/AllureCucumber5Jvm.java b/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/AllureCucumber5Jvm.java index 54683810..f7fc242e 100644 --- a/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/AllureCucumber5Jvm.java +++ b/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/AllureCucumber5Jvm.java @@ -395,15 +395,8 @@ private void createDataTableAttachment(final DataTableArgument dataTableArgument final StringBuilder dataTableCsv = new StringBuilder(); for (List columns : rowsInTable) { if (!columns.isEmpty()) { - for (int i = 0; i < columns.size(); i++) { - if (i == columns.size() - 1) { - dataTableCsv.append(columns.get(i)); - } else { - dataTableCsv.append(columns.get(i)); - dataTableCsv.append('\t'); - } - } - dataTableCsv.append('\n'); + final String rowValue = columns.stream().collect(Collectors.joining("\t", "", "\n")); + dataTableCsv.append(rowValue); } } final String attachmentSource = lifecycle diff --git a/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/TagParser.java b/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/TagParser.java index 21193958..ced0a37f 100644 --- a/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/TagParser.java +++ b/allure-cucumber5-jvm/src/main/java/io/qameta/allure/cucumber5jvm/TagParser.java @@ -51,13 +51,13 @@ public boolean isKnown() { private boolean getStatusDetailByTag(final String tagName) { return scenario.getTags().stream() - .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) - || feature.getTags().stream() - .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); + .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) + || feature.getTags().stream() + .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); } public boolean isResultTag(final String tag) { - return Arrays.asList(new String[]{FLAKY, KNOWN, MUTED}) + return Arrays.asList(FLAKY, KNOWN, MUTED) .contains(tag.toUpperCase()); } diff --git a/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/AllureCucumber6Jvm.java b/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/AllureCucumber6Jvm.java index bb0e513b..6dd1dacf 100644 --- a/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/AllureCucumber6Jvm.java +++ b/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/AllureCucumber6Jvm.java @@ -380,15 +380,8 @@ private void createDataTableAttachment(final DataTableArgument dataTableArgument final StringBuilder dataTableCsv = new StringBuilder(); for (List columns : rowsInTable) { if (!columns.isEmpty()) { - for (int i = 0; i < columns.size(); i++) { - if (i == columns.size() - 1) { - dataTableCsv.append(columns.get(i)); - } else { - dataTableCsv.append(columns.get(i)); - dataTableCsv.append('\t'); - } - } - dataTableCsv.append('\n'); + final String rowValue = columns.stream().collect(Collectors.joining("\t", "", "\n")); + dataTableCsv.append(rowValue); } } final String attachmentSource = lifecycle diff --git a/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/TagParser.java b/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/TagParser.java index a594d97d..ada27215 100644 --- a/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/TagParser.java +++ b/allure-cucumber6-jvm/src/main/java/io/qameta/allure/cucumber6jvm/TagParser.java @@ -51,13 +51,13 @@ public boolean isKnown() { private boolean getStatusDetailByTag(final String tagName) { return scenario.getTags().stream() - .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) - || feature.getTagsList().stream() - .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); + .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) + || feature.getTagsList().stream() + .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); } public boolean isResultTag(final String tag) { - return Arrays.asList(new String[]{FLAKY, KNOWN, MUTED}) + return Arrays.asList(FLAKY, KNOWN, MUTED) .contains(tag.toUpperCase()); } diff --git a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java index 5f85512f..9d7c89b3 100644 --- a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java +++ b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java @@ -393,15 +393,8 @@ private void createDataTableAttachment(final DataTableArgument dataTableArgument final StringBuilder dataTableCsv = new StringBuilder(); for (List columns : rowsInTable) { if (!columns.isEmpty()) { - for (int i = 0; i < columns.size(); i++) { - if (i == columns.size() - 1) { - dataTableCsv.append(columns.get(i)); - } else { - dataTableCsv.append(columns.get(i)); - dataTableCsv.append('\t'); - } - } - dataTableCsv.append('\n'); + final String rowValue = columns.stream().collect(Collectors.joining("\t", "", "\n")); + dataTableCsv.append(rowValue); } } final String attachmentSource = lifecycle diff --git a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/TagParser.java b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/TagParser.java index 8efb825a..a20ad07b 100644 --- a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/TagParser.java +++ b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/TagParser.java @@ -51,13 +51,13 @@ public boolean isKnown() { private boolean getStatusDetailByTag(final String tagName) { return scenario.getTags().stream() - .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) - || feature.getTags().stream() - .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); + .anyMatch(tag -> tag.equalsIgnoreCase(tagName)) + || feature.getTags().stream() + .anyMatch(tag -> tag.getName().equalsIgnoreCase(tagName)); } public boolean isResultTag(final String tag) { - return Arrays.asList(new String[]{FLAKY, KNOWN, MUTED}) + return Arrays.asList(FLAKY, KNOWN, MUTED) .contains(tag.toUpperCase()); } diff --git a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/testsourcemodel/TestSourcesModel.java b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/testsourcemodel/TestSourcesModel.java index 37d2fb7f..8b3533d6 100644 --- a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/testsourcemodel/TestSourcesModel.java +++ b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/testsourcemodel/TestSourcesModel.java @@ -124,7 +124,7 @@ private void processScenarioDefinition( for (Step step : child.getSteps()) { nodeMap.put(step.getLocation().getLine(), createAstNode(step, childNode)); } - if (child.getExamples().size() > 0) { + if (!child.getExamples().isEmpty()) { processScenarioOutlineExamples(nodeMap, child, childNode); } } diff --git a/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java b/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java index b4487310..320ffe84 100644 --- a/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java +++ b/allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionsProcessor.java @@ -82,7 +82,7 @@ public boolean process(final Set annotations, final Round } final String docs = rawDocs.trim(); - if ("".equals(docs)) { + if (docs.isEmpty()) { return; } diff --git a/allure-grpc/src/main/java/io/qameta/allure/grpc/AllureGrpc.java b/allure-grpc/src/main/java/io/qameta/allure/grpc/AllureGrpc.java index 1217dcf9..caf8612d 100644 --- a/allure-grpc/src/main/java/io/qameta/allure/grpc/AllureGrpc.java +++ b/allure-grpc/src/main/java/io/qameta/allure/grpc/AllureGrpc.java @@ -85,22 +85,21 @@ public AllureGrpc interceptResponseMetadata(final boolean value) { return this; } - @SuppressWarnings({"PMD.MethodArgumentCouldBeFinal", "PMD.NPathComplexity"}) + @SuppressWarnings({"PMD.NPathComplexity"}) @Override - public ClientCall interceptCall(MethodDescriptor method, - CallOptions callOptions, - Channel next) { + public ClientCall interceptCall(final MethodDescriptor method, + final CallOptions callOptions, + final Channel next) { final AttachmentProcessor processor = new DefaultAttachmentProcessor(); return new ForwardingClientCall.SimpleForwardingClientCall( next.newCall(method, callOptions.withoutWaitForReady())) { private String stepUuid; - private List parsedResponses = new ArrayList<>(); + private final List parsedResponses = new ArrayList<>(); - @SuppressWarnings("PMD.MethodArgumentCouldBeFinal") @Override - public void sendMessage(T message) { + public void sendMessage(final T message) { stepUuid = UUID.randomUUID().toString(); Allure.getLifecycle().startStep(stepUuid, (new StepResult()).setName( "Send gRPC request to " @@ -126,18 +125,17 @@ public void sendMessage(T message) { } } - @SuppressWarnings("PMD.MethodArgumentCouldBeFinal") + @SuppressWarnings({"PMD.NcssCount"}) @Override - public void start(Listener responseListener, Metadata headers) { + public void start(final Listener responseListener, final Metadata headers) { final ClientCall.Listener listener = new ForwardingClientCallListener() { @Override protected Listener delegate() { return responseListener; } - @SuppressWarnings({"PMD.MethodArgumentCouldBeFinal", "PMD.AvoidLiteralsInIfCondition"}) @Override - public void onClose(io.grpc.Status status, Metadata trailers) { + public void onClose(final io.grpc.Status status, final Metadata trailers) { GrpcResponseAttachment.Builder responseAttachmentBuilder = null; if (parsedResponses.size() == 1) { @@ -183,9 +181,8 @@ public void onClose(io.grpc.Status status, Metadata trailers) { super.onClose(status, trailers); } - @SuppressWarnings("PMD.MethodArgumentCouldBeFinal") @Override - public void onMessage(A message) { + public void onMessage(final A message) { try { parsedResponses.add(JSON_PRINTER.print((MessageOrBuilder) message)); super.onMessage(message); diff --git a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java index 2e4ab558..14167a41 100644 --- a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java +++ b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java @@ -34,7 +34,6 @@ /** * @author a-simeshin (Simeshin Artem) */ -@SuppressWarnings("PMD.MethodArgumentCouldBeFinal") public class AllureHttpClient5Request implements HttpRequestInterceptor { private final AttachmentRenderer renderer; @@ -62,7 +61,9 @@ public AllureHttpClient5Request(final AttachmentRenderer rendere * @param context the HTTP context */ @Override - public void process(HttpRequest request, EntityDetails entity, HttpContext context) { + public void process(final HttpRequest request, + final EntityDetails entity, + final HttpContext context) { final String attachmentName = getAttachmentName(request); final HttpRequestAttachment.Builder builder = create(attachmentName, request.getRequestUri()); builder.setMethod(request.getMethod()); diff --git a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java index bf5bff64..f4e53c93 100644 --- a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java +++ b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java @@ -39,7 +39,6 @@ */ @SuppressWarnings({ "checkstyle:ParameterAssignment", - "PMD.MethodArgumentCouldBeFinal", "PMD.AvoidReassigningParameters"}) public class AllureHttpClient5Response implements HttpResponseInterceptor { private final AttachmentRenderer renderer; @@ -69,7 +68,9 @@ public AllureHttpClient5Response(final AttachmentRenderer render * @throws IOException if an I/O error occurs */ @Override - public void process(HttpResponse response, EntityDetails entity, HttpContext context) throws IOException { + public void process(final HttpResponse response, + EntityDetails entity, + final HttpContext context) throws IOException { final HttpResponseAttachment.Builder builder = create("Response"); builder.setResponseCode(response.getCode()); diff --git a/allure-java-commons/src/main/java/io/qameta/allure/internal/AllureThreadContext.java b/allure-java-commons/src/main/java/io/qameta/allure/internal/AllureThreadContext.java index bbf94fd4..e052c8d1 100644 --- a/allure-java-commons/src/main/java/io/qameta/allure/internal/AllureThreadContext.java +++ b/allure-java-commons/src/main/java/io/qameta/allure/internal/AllureThreadContext.java @@ -15,6 +15,7 @@ */ package io.qameta.allure.internal; +import java.util.Deque; import java.util.LinkedList; import java.util.Objects; import java.util.Optional; @@ -32,7 +33,7 @@ public class AllureThreadContext { * Returns last (most recent) uuid. */ public Optional getCurrent() { - final LinkedList uuids = context.get(); + final Deque uuids = context.get(); return uuids.isEmpty() ? Optional.empty() : Optional.of(uuids.getFirst()); @@ -42,7 +43,7 @@ public Optional getCurrent() { * Returns first (oldest) uuid. */ public Optional getRoot() { - final LinkedList uuids = context.get(); + final Deque uuids = context.get(); return uuids.isEmpty() ? Optional.empty() : Optional.of(uuids.getLast()); @@ -62,7 +63,7 @@ public void start(final String uuid) { * @return removed uuid. */ public Optional stop() { - final LinkedList uuids = context.get(); + final Deque uuids = context.get(); if (!uuids.isEmpty()) { return Optional.of(uuids.pop()); } @@ -79,15 +80,15 @@ public void clear() { /** * Thread local context that stores information about not finished tests and steps. */ - private static final class Context extends InheritableThreadLocal> { + private static final class Context extends InheritableThreadLocal> { @Override - public LinkedList initialValue() { + public Deque initialValue() { return new LinkedList<>(); } @Override - protected LinkedList childValue(final LinkedList parentStepContext) { + protected Deque childValue(final Deque parentStepContext) { return new LinkedList<>(parentStepContext); } diff --git a/allure-junit-platform/src/main/java/io/qameta/allure/junitplatform/AllureJunitPlatform.java b/allure-junit-platform/src/main/java/io/qameta/allure/junitplatform/AllureJunitPlatform.java index 5bd8211d..137e24df 100644 --- a/allure-junit-platform/src/main/java/io/qameta/allure/junitplatform/AllureJunitPlatform.java +++ b/allure-junit-platform/src/main/java/io/qameta/allure/junitplatform/AllureJunitPlatform.java @@ -310,6 +310,7 @@ public void reportingEntryPublished(final TestIdentifier testIdentifier, } + @SuppressWarnings("PMD.InefficientEmptyStringCheck") private Map unwrap(final Map data) { final Map res = new HashMap<>(); data.forEach((key, value) -> { diff --git a/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java b/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java index ed594591..b652feb0 100644 --- a/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java +++ b/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4.java @@ -180,7 +180,6 @@ private Optional getDisplayName(final Description result) { .map(DisplayName::value); } - @SuppressWarnings("PMD.AvoidLiteralsInIfCondition") private Optional getDescription(final Description result) { final io.qameta.allure.Description annotation = result .getAnnotation(io.qameta.allure.Description.class); diff --git a/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4Utils.java b/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4Utils.java index ebe87e56..24fa2a8a 100644 --- a/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4Utils.java +++ b/allure-junit4/src/main/java/io/qameta/allure/junit4/AllureJunit4Utils.java @@ -78,10 +78,7 @@ static class CucumberCheck implements Serializable { @Override public boolean equals(final Object obj) { - if (Objects.isNull(obj)) { - return false; - } - return "io.cucumber.junit.PickleRunners.PickleId" + return !Objects.isNull(obj) && "io.cucumber.junit.PickleRunners.PickleId" .equals(obj.getClass().getCanonicalName()); } diff --git a/allure-junit5/src/main/java/io/qameta/allure/junit5/AllureJunit5.java b/allure-junit5/src/main/java/io/qameta/allure/junit5/AllureJunit5.java index 6ede30ed..7413d70a 100644 --- a/allure-junit5/src/main/java/io/qameta/allure/junit5/AllureJunit5.java +++ b/allure-junit5/src/main/java/io/qameta/allure/junit5/AllureJunit5.java @@ -187,6 +187,7 @@ public Map buildFailureEvent(final String type, return map; } + @SuppressWarnings("PMD.InefficientEmptyStringCheck") public Map wrap(final Map data) { final Map res = new HashMap<>(); data.forEach((key, value) -> { diff --git a/allure-model/src/main/java/io/qameta/allure/model/Stage.java b/allure-model/src/main/java/io/qameta/allure/model/Stage.java index 69747812..ff08a614 100644 --- a/allure-model/src/main/java/io/qameta/allure/model/Stage.java +++ b/allure-model/src/main/java/io/qameta/allure/model/Stage.java @@ -57,7 +57,7 @@ public enum Stage { * @return the stage */ public static Stage fromValue(final String v) { - for (Stage c : Stage.values()) { + for (Stage c : values()) { if (c.value.equals(v)) { return c; } diff --git a/allure-model/src/main/java/io/qameta/allure/model/Status.java b/allure-model/src/main/java/io/qameta/allure/model/Status.java index 15c275bd..37ed668f 100644 --- a/allure-model/src/main/java/io/qameta/allure/model/Status.java +++ b/allure-model/src/main/java/io/qameta/allure/model/Status.java @@ -54,7 +54,7 @@ public enum Status { * @return the status */ public static Status fromValue(final String v) { - for (Status c : Status.values()) { + for (Status c : values()) { if (c.value.equals(v)) { return c; } diff --git a/allure-selenide/src/main/java/io/qameta/allure/selenide/AllureSelenide.java b/allure-selenide/src/main/java/io/qameta/allure/selenide/AllureSelenide.java index ca06a32b..1f320f68 100644 --- a/allure-selenide/src/main/java/io/qameta/allure/selenide/AllureSelenide.java +++ b/allure-selenide/src/main/java/io/qameta/allure/selenide/AllureSelenide.java @@ -31,7 +31,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.HashMap; +import java.util.EnumMap; import java.util.Map; import java.util.Optional; import java.util.UUID; @@ -52,7 +52,7 @@ public class AllureSelenide implements LogEventListener { private boolean saveScreenshots = true; private boolean savePageHtml = true; private boolean includeSelenideLocatorsSteps = true; - private final Map logTypesToSave = new HashMap<>(); + private final Map logTypesToSave = new EnumMap<>(LogType.class); private final AllureLifecycle lifecycle; public AllureSelenide() { @@ -93,8 +93,8 @@ public AllureSelenide disableLogs(final LogType logType) { private static Optional getScreenshotBytes() { try { return WebDriverRunner.hasWebDriverStarted() - ? Optional.of(((TakesScreenshot) WebDriverRunner.getWebDriver()).getScreenshotAs(OutputType.BYTES)) - : Optional.empty(); + ? Optional.of(((TakesScreenshot) WebDriverRunner.getWebDriver()).getScreenshotAs(OutputType.BYTES)) + : Optional.empty(); } catch (WebDriverException e) { LOGGER.warn("Could not get screen shot", e); return Optional.empty(); @@ -104,8 +104,8 @@ private static Optional getScreenshotBytes() { private static Optional getPageSourceBytes() { try { return WebDriverRunner.hasWebDriverStarted() - ? Optional.of(WebDriverRunner.getWebDriver().getPageSource().getBytes(UTF_8)) - : Optional.empty(); + ? Optional.of(WebDriverRunner.getWebDriver().getPageSource().getBytes(UTF_8)) + : Optional.empty(); } catch (WebDriverException e) { LOGGER.warn("Could not get page source", e); return Optional.empty(); diff --git a/build.gradle.kts b/build.gradle.kts index d5edada8..3b373809 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -158,7 +158,7 @@ configure(libs) { dependency("io.github.benas:random-beans:3.9.0") dependency("io.github.glytching:junit-extensions:2.6.0") dependency("javax.annotation:javax.annotation-api:1.3.2") - dependency("net.sourceforge.pmd:pmd-java:6.55.0") + dependency("net.sourceforge.pmd:pmd-java:7.3.0") dependency("org.apache.commons:commons-lang3:3.12.0") dependency("org.apache.httpcomponents:httpclient:4.5.14") dependency("org.apache.httpcomponents.client5:httpclient5:5.2.1") diff --git a/gradle/quality-configs/checkstyle/checkstyle.xml b/gradle/quality-configs/checkstyle/checkstyle.xml index f1bbd494..8e3f80a2 100644 --- a/gradle/quality-configs/checkstyle/checkstyle.xml +++ b/gradle/quality-configs/checkstyle/checkstyle.xml @@ -44,7 +44,7 @@ - + @@ -86,7 +86,9 @@ - + + + @@ -152,10 +154,10 @@ - - + + - + @@ -211,7 +213,7 @@ - + diff --git a/gradle/quality-configs/pmd/pmd.xml b/gradle/quality-configs/pmd/pmd.xml index 7a26c293..adc57b64 100644 --- a/gradle/quality-configs/pmd/pmd.xml +++ b/gradle/quality-configs/pmd/pmd.xml @@ -26,9 +26,7 @@ - - @@ -45,6 +43,7 @@ + @@ -57,17 +56,15 @@ + + - - - - @@ -112,13 +109,13 @@ - + + - From 12948ee81f7b18f99468966494ae4280049883d1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:22:36 +0100 Subject: [PATCH 17/44] bump org.junit:junit-bom from 5.9.2 to 5.10.3 (via #1069) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 3b373809..d25878cb 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -145,7 +145,7 @@ configure(libs) { dependencyManagement { imports { mavenBom("com.fasterxml.jackson:jackson-bom:2.14.1") - mavenBom("org.junit:junit-bom:5.9.2") + mavenBom("org.junit:junit-bom:5.10.3") } dependencies { dependency("com.github.spotbugs:spotbugs:4.8.3") From 4069e34ce3bbbbd561db27a6c541581b25bc62cb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:22:49 +0100 Subject: [PATCH 18/44] bump com.puppycrawl.tools:checkstyle from 10.13.0 to 10.17.0 (via #1067) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index d25878cb..382f1363 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -152,7 +152,7 @@ configure(libs) { dependency("com.github.tomakehurst:wiremock:3.0.1") dependency("com.google.inject:guice:7.0.0") dependency("com.google.testing.compile:compile-testing:0.19") - dependency("com.puppycrawl.tools:checkstyle:10.13.0") + dependency("com.puppycrawl.tools:checkstyle:10.17.0") dependency("com.squareup.retrofit2:retrofit:2.9.0") dependency("commons-io:commons-io:2.11.0") dependency("io.github.benas:random-beans:3.9.0") From 540c2aa5ac015205d089127d5fe56ff4d2468276 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:23:06 +0100 Subject: [PATCH 19/44] bump org.freemarker:freemarker from 2.3.31 to 2.3.33 (via #1070) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 382f1363..a3092b53 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -165,7 +165,7 @@ configure(libs) { dependency("org.aspectj:aspectjrt:${assertJVersion}") dependency("org.aspectj:aspectjweaver:${assertJVersion}") dependency("org.assertj:assertj-core:3.23.1") - dependency("org.freemarker:freemarker:2.3.31") + dependency("org.freemarker:freemarker:2.3.33") dependency("org.grpcmock:grpcmock-junit5:0.8.0") dependency("org.hamcrest:hamcrest:2.2") dependency("org.jboss.resteasy:resteasy-client:6.2.1.Final") From 4e692964eba52a0e5ef043712e087ac086342d74 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:23:18 +0100 Subject: [PATCH 20/44] bump protobufVersion from 4.26.1 to 4.27.2 (via #1066) --- allure-grpc/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-grpc/build.gradle.kts b/allure-grpc/build.gradle.kts index bcba01f3..cd1ddfd3 100644 --- a/allure-grpc/build.gradle.kts +++ b/allure-grpc/build.gradle.kts @@ -9,7 +9,7 @@ description = "Allure gRPC Integration" val agent: Configuration by configurations.creating val grpcVersion = "1.57.2" -val protobufVersion = "4.26.1" +val protobufVersion = "4.27.2" dependencies { agent("org.aspectj:aspectjweaver") From 2e9de5b499fa052a4b779e8ae9fa83269c573ddb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:34:23 +0100 Subject: [PATCH 21/44] bump com.diffplug.spotless from 6.11.0 to 6.25.0 (via #1071) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 8d3f7a00..97a47fa3 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -47,7 +47,7 @@ pluginManagement { gradlePluginPortal() } plugins { - id("com.diffplug.spotless") version "6.11.0" + id("com.diffplug.spotless") version "6.25.0" id("com.github.johnrengelman.shadow") version "8.1.1" id("com.gradle.enterprise") version "3.12.5" id("io.github.gradle-nexus.publish-plugin") version "2.0.0" From 80435797a61b070ce6d38098e9408120ffbd0da2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:34:37 +0100 Subject: [PATCH 22/44] bump com.squareup.retrofit2:retrofit from 2.9.0 to 2.11.0 (via #1068) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index a3092b53..7e8ef508 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -153,7 +153,7 @@ configure(libs) { dependency("com.google.inject:guice:7.0.0") dependency("com.google.testing.compile:compile-testing:0.19") dependency("com.puppycrawl.tools:checkstyle:10.17.0") - dependency("com.squareup.retrofit2:retrofit:2.9.0") + dependency("com.squareup.retrofit2:retrofit:2.11.0") dependency("commons-io:commons-io:2.11.0") dependency("io.github.benas:random-beans:3.9.0") dependency("io.github.glytching:junit-extensions:2.6.0") From 9c55fc583409a32ca1ad00c6d9febfe8b7b960b1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:34:56 +0100 Subject: [PATCH 23/44] bump com.intuit.karate:karate-core from 1.4.0 to 1.4.1 (via #1073) --- allure-karate/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-karate/build.gradle.kts b/allure-karate/build.gradle.kts index f300ed9f..f30a2046 100644 --- a/allure-karate/build.gradle.kts +++ b/allure-karate/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure Karate Integration" -val karateVersion = "1.4.0" +val karateVersion = "1.4.1" configurations { testImplementation { From 68eeb8cc8e0bdaf199a5420d390aa6fd03bdd754 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:35:13 +0100 Subject: [PATCH 24/44] bump org.jooq:jooq from 3.18.4 to 3.19.10 (via #1074) --- allure-jooq/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-jooq/build.gradle.kts b/allure-jooq/build.gradle.kts index ef7c3516..5f557fba 100644 --- a/allure-jooq/build.gradle.kts +++ b/allure-jooq/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure JOOQ Integration" -val jooqVersion = "3.18.4" +val jooqVersion = "3.19.10" dependencies { api(project(":allure-java-commons")) From a3417ac15985b1001d9317c289a6b41f6b296d3c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:48:33 +0100 Subject: [PATCH 25/44] bump org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.3.1 (via #1079) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 7e8ef508..c405c8f9 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -161,7 +161,7 @@ configure(libs) { dependency("net.sourceforge.pmd:pmd-java:7.3.0") dependency("org.apache.commons:commons-lang3:3.12.0") dependency("org.apache.httpcomponents:httpclient:4.5.14") - dependency("org.apache.httpcomponents.client5:httpclient5:5.2.1") + dependency("org.apache.httpcomponents.client5:httpclient5:5.3.1") dependency("org.aspectj:aspectjrt:${assertJVersion}") dependency("org.aspectj:aspectjweaver:${assertJVersion}") dependency("org.assertj:assertj-core:3.23.1") From 64857eac65606c4c623169c91565cdf3fa7b52d8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:48:53 +0100 Subject: [PATCH 26/44] bump io.rest-assured:rest-assured from 5.4.0 to 5.5.0 (via #1078) --- allure-rest-assured/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-rest-assured/build.gradle.kts b/allure-rest-assured/build.gradle.kts index 9fa2af59..809f433b 100644 --- a/allure-rest-assured/build.gradle.kts +++ b/allure-rest-assured/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure Rest-Assured Integration" -val restAssuredVersion = "5.4.0" +val restAssuredVersion = "5.5.0" dependencies { api(project(":allure-attachments")) From 3ceb6651f32236f322af3504a0d70649f8ab6a7b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:49:11 +0100 Subject: [PATCH 27/44] bump commons-io:commons-io from 2.11.0 to 2.16.1 (via #1075) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index c405c8f9..b62e426d 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -154,7 +154,7 @@ configure(libs) { dependency("com.google.testing.compile:compile-testing:0.19") dependency("com.puppycrawl.tools:checkstyle:10.17.0") dependency("com.squareup.retrofit2:retrofit:2.11.0") - dependency("commons-io:commons-io:2.11.0") + dependency("commons-io:commons-io:2.16.1") dependency("io.github.benas:random-beans:3.9.0") dependency("io.github.glytching:junit-extensions:2.6.0") dependency("javax.annotation:javax.annotation-api:1.3.2") From 7fc6768a941121435424ad1a66fd8cc57fe7632f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:49:30 +0100 Subject: [PATCH 28/44] bump org.jboss.resteasy:resteasy-client from 6.2.1.Final to 6.2.9.Final (via #1076) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index b62e426d..9ef0be4b 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -168,7 +168,7 @@ configure(libs) { dependency("org.freemarker:freemarker:2.3.33") dependency("org.grpcmock:grpcmock-junit5:0.8.0") dependency("org.hamcrest:hamcrest:2.2") - dependency("org.jboss.resteasy:resteasy-client:6.2.1.Final") + dependency("org.jboss.resteasy:resteasy-client:6.2.9.Final") dependency("org.mock-server:mockserver-netty:5.15.0") dependency("org.mockito:mockito-core:5.12.0") dependency("org.slf4j:slf4j-api:${orgSlf4jVersion}") From b88b72aa163f24f875d9c8fd48f2202aa1893bb2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:49:49 +0100 Subject: [PATCH 29/44] bump io.zonky.test.postgres:embedded-postgres-binaries-bom from 15.3.0 to 16.2.0 (via #1077) --- allure-jooq/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-jooq/build.gradle.kts b/allure-jooq/build.gradle.kts index 5f557fba..51a65567 100644 --- a/allure-jooq/build.gradle.kts +++ b/allure-jooq/build.gradle.kts @@ -10,7 +10,7 @@ dependencies { testImplementation("org.junit.jupiter:junit-jupiter-api") testImplementation("org.mockito:mockito-core") testImplementation("org.slf4j:slf4j-simple") - testImplementation(platform("io.zonky.test.postgres:embedded-postgres-binaries-bom:15.3.0")) + testImplementation(platform("io.zonky.test.postgres:embedded-postgres-binaries-bom:16.2.0")) testImplementation(project(":allure-assertj")) testImplementation(project(":allure-java-commons-test")) testImplementation(project(":allure-junit-platform")) From 213b22155a67dfbe20472076feeb5bccee9673c0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:06:16 +0100 Subject: [PATCH 30/44] bump org.springframework:spring-web from 5.3.20 to 5.3.37 (via #1080) --- allure-spring-web/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-spring-web/build.gradle.kts b/allure-spring-web/build.gradle.kts index 5d7d4fcd..07f25818 100644 --- a/allure-spring-web/build.gradle.kts +++ b/allure-spring-web/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure Spring Web Integration" -val springWebVersion = "5.3.20" +val springWebVersion = "5.3.37" dependencies { api(project(":allure-attachments")) From 77b0001e339fad5090f10424eb93fb9b587e070f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:06:35 +0100 Subject: [PATCH 31/44] bump assertJVersion from 1.9.9.1 to 1.9.22.1 (via #1082) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 9ef0be4b..3b1f2234 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -140,7 +140,7 @@ configure(libs) { apply(plugin = "java-library") val orgSlf4jVersion = "2.0.13" - val assertJVersion = "1.9.9.1" + val assertJVersion = "1.9.22.1" dependencyManagement { imports { From f1c8ab638629ebf751905c5bd3526cbb9fc279b3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:07:00 +0100 Subject: [PATCH 32/44] bump com.gradle.enterprise from 3.12.5 to 3.17.5 (via #1084) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 97a47fa3..43beb901 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -49,7 +49,7 @@ pluginManagement { plugins { id("com.diffplug.spotless") version "6.25.0" id("com.github.johnrengelman.shadow") version "8.1.1" - id("com.gradle.enterprise") version "3.12.5" + id("com.gradle.enterprise") version "3.17.5" id("io.github.gradle-nexus.publish-plugin") version "2.0.0" id("io.qameta.allure-adapter") version "2.11.2" id("io.qameta.allure-aggregate-report") version "2.11.2" From f5fd60063ca493ebb97a2bca2108e99237c94394 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:08:34 +0100 Subject: [PATCH 33/44] bump com.google.testing.compile:compile-testing from 0.19 to 0.21.0 (via #1083) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 3b1f2234..bb4c056e 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -151,7 +151,7 @@ configure(libs) { dependency("com.github.spotbugs:spotbugs:4.8.3") dependency("com.github.tomakehurst:wiremock:3.0.1") dependency("com.google.inject:guice:7.0.0") - dependency("com.google.testing.compile:compile-testing:0.19") + dependency("com.google.testing.compile:compile-testing:0.21.0") dependency("com.puppycrawl.tools:checkstyle:10.17.0") dependency("com.squareup.retrofit2:retrofit:2.11.0") dependency("commons-io:commons-io:2.16.1") From be4c07fa943b053c1ffef7955b2d37392be10a2c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 19:34:31 +0100 Subject: [PATCH 34/44] bump io.zonky.test:embedded-postgres from 2.0.4 to 2.0.7 (via #1087) --- allure-jooq/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-jooq/build.gradle.kts b/allure-jooq/build.gradle.kts index 51a65567..b0b1c788 100644 --- a/allure-jooq/build.gradle.kts +++ b/allure-jooq/build.gradle.kts @@ -5,7 +5,7 @@ val jooqVersion = "3.19.10" dependencies { api(project(":allure-java-commons")) implementation("org.jooq:jooq:${jooqVersion}") - testImplementation("io.zonky.test:embedded-postgres:2.0.4") + testImplementation("io.zonky.test:embedded-postgres:2.0.7") testImplementation("org.assertj:assertj-core") testImplementation("org.junit.jupiter:junit-jupiter-api") testImplementation("org.mockito:mockito-core") From 36ebd1b2a0dabf0e461c46d5740bb815a54f6fca Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 20:20:12 +0100 Subject: [PATCH 35/44] bump jvm from 1.7.10 to 2.0.0 (via #1089) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 43beb901..9ca48019 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -58,7 +58,7 @@ pluginManagement { id("io.spring.dependency-management") version "1.1.5" id("com.google.protobuf") version "0.9.4" id("com.github.spotbugs") version "6.0.6" - kotlin("jvm") version "1.7.10" + kotlin("jvm") version "2.0.0" } } From 43e38eae723ffa7c6ad1faf3389e71f598b20633 Mon Sep 17 00:00:00 2001 From: Dmitry Baev Date: Fri, 5 Jul 2024 20:47:27 +0100 Subject: [PATCH 36/44] build with java 21 (via #1090) --- .github/workflows/build.yml | 12 ++++-------- .github/workflows/publish.yml | 4 ++-- allure-scalatest/build.gradle.kts | 12 +++++------- allure-spock/build.gradle.kts | 2 +- allure-spock2/build.gradle.kts | 2 +- build.gradle.kts | 2 +- settings.gradle.kts | 9 +++++---- 7 files changed, 19 insertions(+), 24 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ad77feb7..cb14edb6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -14,22 +14,18 @@ jobs: build: name: "Build" runs-on: ubuntu-latest - strategy: - fail-fast: false - matrix: - java-version: [ '17.0.x' ] steps: - uses: actions/checkout@v4.1.1 - - name: Set up JDK ${{ matrix.java-version }} + - name: "Set up JDK" uses: actions/setup-java@v4 with: distribution: 'zulu' - java-version: ${{ matrix.java-version }} + java-version: 21 - - name: Build with Gradle + - name: "Build with Gradle" run: ./gradlew build -x test --scan - - name: Run tests + - name: "Run tests" if: always() run: ./gradlew --no-build-cache cleanTest test diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 75b78957..28af62d5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -10,11 +10,11 @@ jobs: steps: - uses: actions/checkout@v4.1.1 - - name: "Set up JDK 17.0.x" + - name: "Set up JDK" uses: actions/setup-java@v4 with: distribution: 'zulu' - java-version: '17.0.x' + java-version: '21' - name: Set up GPG run: echo -n "${GPG_PRIVATE_KEY}" | base64 --decode > ${GITHUB_WORKSPACE}/${GPG_KEY_ID}.gpg diff --git a/allure-scalatest/build.gradle.kts b/allure-scalatest/build.gradle.kts index 910d28ad..2aa0f8d3 100644 --- a/allure-scalatest/build.gradle.kts +++ b/allure-scalatest/build.gradle.kts @@ -4,17 +4,15 @@ description = "Allure ScalaTest Integration" apply(plugin = "scala") -val availableScalaVersions = listOf("2.11", "2.12", "2.13") -val defaultScala211Version = "2.11.12" -val defaultScala212Version = "2.12.8" -val defaultScala213Version = "2.13.1" +val availableScalaVersions = listOf("2.12", "2.13") +val defaultScala212Version = "2.12.19" +val defaultScala213Version = "2.13.14" var selectedScalaVersion = defaultScala213Version if (hasProperty("scalaVersion")) { val scalaVersion: String by project selectedScalaVersion = when (scalaVersion) { - "2.11" -> defaultScala211Version "2.12" -> defaultScala212Version "2.13" -> defaultScala213Version else -> scalaVersion @@ -80,8 +78,8 @@ val installAll by tasks.creating { dependencies { api(project(":allure-java-commons")) - implementation("org.scalatest:scalatest_$baseScalaVersion:3.1.1") - implementation("org.scala-lang.modules:scala-collection-compat_$baseScalaVersion:2.1.4") + implementation("org.scalatest:scalatest_$baseScalaVersion:3.2.19") + implementation("org.scala-lang.modules:scala-collection-compat_$baseScalaVersion:2.12.0") testAnnotationProcessor(project(":allure-descriptions-javadoc")) testImplementation("io.github.glytching:junit-extensions") testImplementation("org.assertj:assertj-core") diff --git a/allure-spock/build.gradle.kts b/allure-spock/build.gradle.kts index 9fbbe98a..f65503f4 100644 --- a/allure-spock/build.gradle.kts +++ b/allure-spock/build.gradle.kts @@ -3,7 +3,7 @@ description = "Allure Spock Framework Integration" apply(plugin = "groovy") val spockFrameworkVersion = "1.3-groovy-2.5" -val groovyVersion = "2.5.19" +val groovyVersion = "2.5.23" dependencies { api(project(":allure-java-commons")) diff --git a/allure-spock2/build.gradle.kts b/allure-spock2/build.gradle.kts index 50c5c4ba..fbbe45a5 100644 --- a/allure-spock2/build.gradle.kts +++ b/allure-spock2/build.gradle.kts @@ -5,7 +5,7 @@ plugins { } val spockFrameworkVersion = "2.3-groovy-3.0" -val groovyVersion = "3.0.13" +val groovyVersion = "3.0.22" dependencies { api(project(":allure-java-commons")) diff --git a/build.gradle.kts b/build.gradle.kts index bb4c056e..8232a0d3 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -27,7 +27,7 @@ plugins { java { toolchain { - languageVersion.set(JavaLanguageVersion.of(17)) + languageVersion.set(JavaLanguageVersion.of(21)) } } diff --git a/settings.gradle.kts b/settings.gradle.kts index 9ca48019..6e1af8fd 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -63,16 +63,17 @@ pluginManagement { } plugins { - id("com.gradle.enterprise") + id("com.gradle.develocity") version "3.17.5" apply false } val isCiServer = System.getenv().containsKey("CI") if (isCiServer) { - gradleEnterprise { + apply(plugin = "com.gradle.develocity") + develocity { buildScan { - termsOfServiceUrl = "https://gradle.com/terms-of-service" - termsOfServiceAgree = "yes" + termsOfUseUrl = "https://gradle.com/terms-of-service" + termsOfUseAgree = "yes" tag("CI") } } From b416eaa98cba174fd166fc7c601724550b54c518 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 22:29:44 +0100 Subject: [PATCH 37/44] bump com.fasterxml.jackson:jackson-bom from 2.14.1 to 2.17.2 (#1086) --- allure-java-commons/build.gradle.kts | 2 +- allure-test-filter/build.gradle.kts | 2 +- build.gradle.kts | 3 ++- settings.gradle.kts | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/allure-java-commons/build.gradle.kts b/allure-java-commons/build.gradle.kts index 65c5ae82..34a9a2ed 100644 --- a/allure-java-commons/build.gradle.kts +++ b/allure-java-commons/build.gradle.kts @@ -1,5 +1,5 @@ plugins { - id("com.github.johnrengelman.shadow") + id("io.github.goooler.shadow") } description = "Allure Java Commons" diff --git a/allure-test-filter/build.gradle.kts b/allure-test-filter/build.gradle.kts index 547df012..b2198ce3 100644 --- a/allure-test-filter/build.gradle.kts +++ b/allure-test-filter/build.gradle.kts @@ -1,5 +1,5 @@ plugins { - id("com.github.johnrengelman.shadow") + id("io.github.goooler.shadow") } description = "Allure Test Filter" diff --git a/build.gradle.kts b/build.gradle.kts index 8232a0d3..33e53ac4 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -144,7 +144,7 @@ configure(libs) { dependencyManagement { imports { - mavenBom("com.fasterxml.jackson:jackson-bom:2.14.1") + mavenBom("com.fasterxml.jackson:jackson-bom:2.17.2") mavenBom("org.junit:junit-bom:5.10.3") } dependencies { @@ -193,6 +193,7 @@ configure(libs) { tasks { compileJava { + options.compilerArgs.add("-Xlint:-options") if (JavaVersion.current().isJava8) { java.targetCompatibility = JavaVersion.VERSION_1_8 } else { diff --git a/settings.gradle.kts b/settings.gradle.kts index 6e1af8fd..3b27fe7c 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -48,7 +48,7 @@ pluginManagement { } plugins { id("com.diffplug.spotless") version "6.25.0" - id("com.github.johnrengelman.shadow") version "8.1.1" + id("io.github.goooler.shadow") version "8.1.8" id("com.gradle.enterprise") version "3.17.5" id("io.github.gradle-nexus.publish-plugin") version "2.0.0" id("io.qameta.allure-adapter") version "2.11.2" From 97f0e9c51c7ebddc3f3aa42cbc39eef6e34c9a2c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 22:30:44 +0100 Subject: [PATCH 38/44] bump org.assertj:assertj-core from 3.23.1 to 3.26.0 (#1092) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 33e53ac4..e1d28ee2 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -164,7 +164,7 @@ configure(libs) { dependency("org.apache.httpcomponents.client5:httpclient5:5.3.1") dependency("org.aspectj:aspectjrt:${assertJVersion}") dependency("org.aspectj:aspectjweaver:${assertJVersion}") - dependency("org.assertj:assertj-core:3.23.1") + dependency("org.assertj:assertj-core:3.26.0") dependency("org.freemarker:freemarker:2.3.33") dependency("org.grpcmock:grpcmock-junit5:0.8.0") dependency("org.hamcrest:hamcrest:2.2") From 5cdb7b4f98da0829c85766fc8b4e89921264a456 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Jul 2024 22:40:00 +0100 Subject: [PATCH 39/44] bump com.github.spotbugs from 6.0.6 to 6.0.18 (via #1091) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index 3b27fe7c..c0b6759d 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -57,7 +57,7 @@ pluginManagement { id("io.qameta.allure-report") version "2.11.2" id("io.spring.dependency-management") version "1.1.5" id("com.google.protobuf") version "0.9.4" - id("com.github.spotbugs") version "6.0.6" + id("com.github.spotbugs") version "6.0.18" kotlin("jvm") version "2.0.0" } } From 1a5306b682ba0c05c179c9ca3954648ecf3a8eab Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Jul 2024 12:45:47 +0100 Subject: [PATCH 40/44] bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 (via #1093) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index e1d28ee2..bffc8633 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -159,7 +159,7 @@ configure(libs) { dependency("io.github.glytching:junit-extensions:2.6.0") dependency("javax.annotation:javax.annotation-api:1.3.2") dependency("net.sourceforge.pmd:pmd-java:7.3.0") - dependency("org.apache.commons:commons-lang3:3.12.0") + dependency("org.apache.commons:commons-lang3:3.14.0") dependency("org.apache.httpcomponents:httpclient:4.5.14") dependency("org.apache.httpcomponents.client5:httpclient5:5.3.1") dependency("org.aspectj:aspectjrt:${assertJVersion}") From d552349bb66474916fa1ebeb05cb5efff7fba944 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Jul 2024 13:11:12 +0100 Subject: [PATCH 41/44] build(deps): bump io.spring.dependency-management from 1.1.5 to 1.1.6 (via #1094) --- settings.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings.gradle.kts b/settings.gradle.kts index c0b6759d..4bc95c3d 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -55,7 +55,7 @@ pluginManagement { id("io.qameta.allure-aggregate-report") version "2.11.2" id("io.qameta.allure-download") version "2.11.2" id("io.qameta.allure-report") version "2.11.2" - id("io.spring.dependency-management") version "1.1.5" + id("io.spring.dependency-management") version "1.1.6" id("com.google.protobuf") version "0.9.4" id("com.github.spotbugs") version "6.0.18" kotlin("jvm") version "2.0.0" From 9dee4443b318f7b046ff4590ea3e9b760379d1ed Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Jul 2024 13:11:34 +0100 Subject: [PATCH 42/44] bump com.github.spotbugs:spotbugs from 4.8.3 to 4.8.6 (via #1081) --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index bffc8633..d4b5d1fd 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -148,7 +148,7 @@ configure(libs) { mavenBom("org.junit:junit-bom:5.10.3") } dependencies { - dependency("com.github.spotbugs:spotbugs:4.8.3") + dependency("com.github.spotbugs:spotbugs:4.8.6") dependency("com.github.tomakehurst:wiremock:3.0.1") dependency("com.google.inject:guice:7.0.0") dependency("com.google.testing.compile:compile-testing:0.21.0") From 515752a5a689228d1f1c06c35bd118f2a398af51 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Jul 2024 16:24:36 +0100 Subject: [PATCH 43/44] bump com.codeborne:selenide from 6.17.1 to 7.3.3 (via #1088) --- allure-selenide/build.gradle.kts | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/allure-selenide/build.gradle.kts b/allure-selenide/build.gradle.kts index 39ca99aa..9e086e1d 100644 --- a/allure-selenide/build.gradle.kts +++ b/allure-selenide/build.gradle.kts @@ -1,6 +1,6 @@ description = "Allure Selenide Integration" -val selenideVersion = "6.17.1" +val selenideVersion = "7.3.3" dependencies { api(project(":allure-java-commons")) @@ -15,14 +15,23 @@ dependencies { testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine") } -tasks.jar { - manifest { - attributes(mapOf( - "Automatic-Module-Name" to "io.qameta.allure.selenide" - )) +tasks { + compileJava { + options.release.set(17) + } + compileTestJava { + options.release.set(17) + } + jar { + manifest { + attributes( + mapOf( + "Automatic-Module-Name" to "io.qameta.allure.selenide" + ) + ) + } + } + test { + useJUnitPlatform() } -} - -tasks.test { - useJUnitPlatform() } From 254d2f2b1ffd69f4505f0f520d0cc6099a0d18f8 Mon Sep 17 00:00:00 2001 From: qameta-ci Date: Tue, 9 Jul 2024 09:40:45 +0000 Subject: [PATCH 44/44] release 2.28.0 --- gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle.properties b/gradle.properties index 872642fb..ff0fe585 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,4 +1,4 @@ -version=2.28-SNAPSHOT +version=2.28.0 org.gradle.daemon=true org.gradle.parallel=true