Merged
Conversation
86d26f3 to
56c6f8a
Compare
- Introduced a new method `Approval` in the ImageHash struct to generate a digest that must be signed for subsequent ImageHash approvals. - Utilized a predefined salt for the hashing process to ensure consistency and security in the approval mechanism.
VojtechVitek
reviewed
Aug 7, 2025
VojtechVitek
reviewed
Aug 7, 2025
Contributor
There was a problem hiding this comment.
@shunkakinoki @attente before I go through the PR in detail, what's the high-level update on this PR? Did we stabilize the v3 contracts? Is this backward-compatible regarding v1/v2?
Co-authored-by: Shun Kakinoki <shunkakinoki@gmail.com>
…721cdd882f92521a2742d07
VojtechVitek
reviewed
Sep 4, 2025
VojtechVitek
approved these changes
Sep 11, 2025
Contributor
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM.
Current go-sequence@master saved at "v2" branch: https://github.com/0xsequence/go-sequence/tree/v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes all required core
configuration,imageHash,signaturemodules derived from sequence-core forv3and ensures that all critical tests are passing.Steps to test
rpc:Caveats
Some gas-estimation commands, etc. are commented out because of the scope of this PR. will follow up in a later PR. Also,
Permission,SmartSession,SessionManagerrelated modules will follow up later.