Conversation
| seqsale1155v0 "github.com/0xsequence/go-sequence/contracts/gen/seq_sale/erc1155v0" | ||
| seqsale1155v1 "github.com/0xsequence/go-sequence/contracts/gen/seq_sale/erc1155v1" | ||
| seqsale721v0 "github.com/0xsequence/go-sequence/contracts/gen/seq_sale/erc721v0" |
There was a problem hiding this comment.
Hi, @ScreamingHawk Can you please review this PR?
It looks like we need some guidance on the semver versioning of the contracts.
I might be looking wrong but I don't see any versions at https://github.com/0xsequence/contracts-library. Can you help me understand how do we version the contracts right now? Is there any page (or source of truth) with the list of contracts and their addresses / versions when you deploy them on chains?
There was a problem hiding this comment.
I wonder who should be responsible for maintaining https://github.com/0xsequence/go-sequence/tree/master/contracts/artifacts and when we introduce any breaking changes, how do we upgrade repos like stack/api / relayer / marketplace etc.
Sorry I'm new to this, so I might be missing something obvious :D
There was a problem hiding this comment.
It's a good question – We need to handle contract versioning and notifications within the team with a good process so rest of the team are not struggling to keep up. @ScreamingHawk Let us know if there is anything around this for now, then we can discuss and plan a process.
There was a problem hiding this comment.
I consider the Builder database is the source of truth.
Updating these artifacts could be my (the contract developer) responsibility.
I have a notion page with information on what to update with a new contract deployment but it's missing a lot of details. I'm also going to start pinging in Slack for new versions so everyone is aware.
|
Added the ERC721Salev1 ABI to this PR |
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM. Thank you both!
No description provided.