24.8.14 Backport of #87303 - Fix condition not being moved to PREWHERE in case there is a row policy (version 2)#1080
Merged
zvonand merged 2 commits intocustomizations/24.8.14from Oct 16, 2025
Conversation
This commit is a manual backport of two PRs: 1. ClickHouse#87303 2. ClickHouse#88017 Additionally, the test from ClickHouse#88036 was added.
Collaborator
|
This is an automated comment for commit 0aed477 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
|
Guess that failed test Am I right that ClickHouse#8730 has some changes for some post-24.8 stuff, which are safely removed from PR (like FormatFactory, etc)? |
Collaborator
Author
|
Thanks for the review!
Fixed in a follow-up commit.
Yes, it had quite a bit of stuff that was missing in this version, and that's why I decided to apply it manually. The extra stuff was safely removed, but I wanted to have more eyes looking into this code to spot a possible mistake. |
ilejn
reviewed
Oct 15, 2025
ilejn
reviewed
Oct 15, 2025
zvonand
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a manual backport of two PRs:
Additionally, the test from ClickHouse#88036 was added.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed move-to-prewhere optimization, which did not work in the presence of row policy (ClickHouse#87303 by @KochetovNicolai)
CI/CD Options
Exclude tests:
Regression jobs to run: