Implement clear parquet metadata cache command#713
Merged
Conversation
Collaborator
|
This is an automated comment for commit 6971379 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
ianton-ru
previously approved these changes
Apr 5, 2025
Collaborator
Author
|
I have added some tests, but haven't executed them locally yet. When I get home, with better internet connection to download dependencies, I'll run it |
ianton-ru
previously approved these changes
Apr 7, 2025
| getContext()->checkAccess(AccessType::SYSTEM_DROP_PARQUET_METADATA_CACHE); | ||
| ParquetFileMetaDataCache::instance()->clear(); | ||
| #endif | ||
| break; |
There was a problem hiding this comment.
NIT: May be throw exception when USE_PARQUET not defined, as for USE_EMBEDDED_COMPILER below?
(I don't think than sometimes someone assemble clickhouse without parquet support)
f0e46ab to
97ca59e
Compare
arthurpassos
pushed a commit
that referenced
this pull request
May 22, 2025
Implement clear parquet metadata cache command
13 tasks
Collaborator
Author
|
Marking it as obsolete in favor of #1039 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
SYSTEM DROP PARQUET METADATA CACHE command
Documentation entry for user-facing changes