Do not check for cyclic dependencies on create table with no dependencies#83077

Merged

Avogar merged 1 commit intomasterfrom

Jul 3, 2025

Member

Avogar commented Jul 2, 2025

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Do not check for cyclic dependencies on create table with no dependencies. It fixes performance degradation of the use cases with creation of thousands of tables that was introduced in #65405.

Closes #79366
Closes #82883

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)


          Do not check for cyclic dependencies on create table with no dependen…

fdc336f

…cies

Avogar added the pr-must-backport label

Contributor

clickhouse-gh bot commented Jul 2, 2025 •

edited

Loading

Workflow [PR], commit [fdc336f]

Summary: ❌

job_name	test_name	status	info	comment
Stateless tests (amd_tsan, s3 storage, 3/3)		failure
	00988_expansion_aliases_limit	FAIL
	03352_concurrent_rename_alter	FAIL
	Killed by signal (in clickhouse-server.log)	FAIL
	Fatal messages (in clickhouse-server.log)	FAIL
	Found signal in gdb.log	FAIL
Finish Workflow		failure
	python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py	failure

clickhouse-gh bot added the pr-bugfix label

hanfei1991 self-assigned this

hanfei1991 approved these changes

View reviewed changes

filimonov mentioned this pull request

Table creation speed in 25.3 is significantly slower than in 24.3 #82883

Closed

Member Author

Avogar commented Jul 3, 2025

Stateless tests (amd_tsan, s3 storage, 3/3) - The test runner was terminated unexpectedly
CH Inc sync - Job timeout expired in integration tests

Avogar added this pull request to the merge queue

Merged via the queue into master with commit 3c2720e

118 of 123 checks passed

Avogar deleted the Avogar-patch-8 branch

July 3, 2025 17:52

robot-ch-test-poll4 added the pr-synced-to-cloud label

robot-ch-test-poll3 added pr-backports-created-cloud pr-must-backport-synced labels

robot-ch-test-poll3 mentioned this pull request

Cherry pick #83077 to 24.8: Do not check for cyclic dependencies on create table with no dependencies #83192

Merged

robot-ch-test-poll3 added a commit that referenced this pull request


          Merge pull request #83192 from ClickHouse/cherrypick/24.8/83077

d169028

Cherry pick #83077 to 24.8: Do not check for cyclic dependencies on create table with no dependencies

robot-clickhouse added a commit that referenced this pull request


          Backport #83077 to 24.8: Do not check for cyclic dependencies on crea…

c67ee5e

…te table with no dependencies

This was referenced Jul 3, 2025

Backport #83077 to 24.8: Do not check for cyclic dependencies on create table with no dependencies #83193

Merged

Cherry pick #83077 to 25.3: Do not check for cyclic dependencies on create table with no dependencies #83194

Merged

robot-ch-test-poll3 added a commit that referenced this pull request


          Merge pull request #83194 from ClickHouse/cherrypick/25.3/83077

7111d11

Cherry pick #83077 to 25.3: Do not check for cyclic dependencies on create table with no dependencies

robot-clickhouse added a commit that referenced this pull request


          Backport #83077 to 25.3: Do not check for cyclic dependencies on crea…

6d19028

…te table with no dependencies

This was referenced Jul 3, 2025

Backport #83077 to 25.3: Do not check for cyclic dependencies on create table with no dependencies #83195

Merged

Cherry pick #83077 to 25.4: Do not check for cyclic dependencies on create table with no dependencies #83196

Merged

robot-ch-test-poll3 added a commit that referenced this pull request


          Merge pull request #83196 from ClickHouse/cherrypick/25.4/83077

483465c

Cherry pick #83077 to 25.4: Do not check for cyclic dependencies on create table with no dependencies

robot-clickhouse added a commit that referenced this pull request


          Backport #83077 to 25.4: Do not check for cyclic dependencies on crea…

ee6aebc

…te table with no dependencies

This was referenced Jul 3, 2025

Backport #83077 to 25.4: Do not check for cyclic dependencies on create table with no dependencies #83197

Merged

Cherry pick #83077 to 25.5: Do not check for cyclic dependencies on create table with no dependencies #83198

Merged

robot-ch-test-poll3 added a commit that referenced this pull request


          Merge pull request #83198 from ClickHouse/cherrypick/25.5/83077

0587f8c

Cherry pick #83077 to 25.5: Do not check for cyclic dependencies on create table with no dependencies

robot-clickhouse added a commit that referenced this pull request


          Backport #83077 to 25.5: Do not check for cyclic dependencies on crea…

7272c75

…te table with no dependencies

This was referenced Jul 3, 2025

Backport #83077 to 25.5: Do not check for cyclic dependencies on create table with no dependencies #83199

Merged

Cherry pick #83077 to 25.6: Do not check for cyclic dependencies on create table with no dependencies #83200

Merged

robot-ch-test-poll3 added a commit that referenced this pull request


          Merge pull request #83200 from ClickHouse/cherrypick/25.6/83077

858b943

Cherry pick #83077 to 25.6: Do not check for cyclic dependencies on create table with no dependencies

robot-clickhouse added a commit that referenced this pull request


          Backport #83077 to 25.6: Do not check for cyclic dependencies on crea…

241f136

…te table with no dependencies

robot-ch-test-poll3 mentioned this pull request

Backport #83077 to 25.6: Do not check for cyclic dependencies on create table with no dependencies #83201

Merged

robot-ch-test-poll2 added the pr-backports-created label

filimonov mentioned this pull request

O(n²) performance in CREATE TABLE with dynamic workloads (regression in checkTableCanBeAddedWithNoCyclicDependencies) #79366

Closed

clickhouse-gh bot added a commit that referenced this pull request


          Merge pull request #83201 from ClickHouse/backport/25.6/83077

5c2c6e4

Backport #83077 to 25.6: Do not check for cyclic dependencies on create table with no dependencies

alexey-milovidov added a commit that referenced this pull request


          Merge pull request #83197 from ClickHouse/backport/25.4/83077

d4ce4e4

Backport #83077 to 25.4: Do not check for cyclic dependencies on create table with no dependencies

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request


          Merge pull request ClickHouse#83077 from ClickHouse/Avogar-patch-8

ef568d3

Do not check for cyclic dependencies on create table with no dependencies

zvonand mentioned this pull request

25.3.5 Backport of #83077: Do not check for cyclic dependencies on create table with no dependencies Altinity/ClickHouse#892

Merged

Enmk added a commit to Altinity/ClickHouse that referenced this pull request


          Merge pull request #892 from Altinity/backports/25.3.5/83077

25.3.5 Backport of ClickHouse#83077: Do not check for cyclic dependencies on create table with no dependencies

Avogar added a commit that referenced this pull request


          Merge pull request #83199 from ClickHouse/backport/25.5/83077

f484613

Backport #83077 to 25.5: Do not check for cyclic dependencies on create table with no dependencies

Avogar added a commit that referenced this pull request


          Merge pull request #83195 from ClickHouse/backport/25.3/83077

1deec30

Backport #83077 to 25.3: Do not check for cyclic dependencies on create table with no dependencies

Avogar added a commit that referenced this pull request


          Merge pull request #83193 from ClickHouse/backport/24.8/83077

67bf66a

Backport #83077 to 24.8: Do not check for cyclic dependencies on create table with no dependencies

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request


          Merge pull request ClickHouse#83077 from ClickHouse/Avogar-patch-8

30ee39a

Do not check for cyclic dependencies on create table with no dependencies

zvonand mentioned this pull request

25.3.6 Backport of #83077: Do not check for cyclic dependencies on create table with no dependencies Altinity/ClickHouse#916

Merged

13 tasks

zvonand added a commit to Altinity/ClickHouse that referenced this pull request


          Merge pull request #916 from Altinity/backports/25.3.6/83077

26ba19a

25.3.6 Backport of ClickHouse#83077: Do not check for cyclic dependencies on create table with no dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created pr-backports-created-cloud pr-bugfix pr-must-backport pr-must-backport-synced pr-synced-to-cloud