Conversation
|
It seems that https://github.com/CodeEditApp/CodeEditTextView/pull/123 needs to be merged and the |
# Description Adds `useThemeBackground` to `CodeEditTextView` which dictates whether the background of `CodeEditTextView` is clear or uses the given theme background color # Related * CodeEditApp/CodeEdit#1004
|
Please update |
There was a problem hiding this comment.
This same should also apply to the terminal, this checkbox does not exist in the terminal tab, so it will need to be added underneath, "Always use dark terminal appearance"
In the terminal tab, it looks like you repurposed the "Always use dark terminal appearance" instead of adding a "Use theme background" checkbox underneath it. Please correct this.
The "Always use dark terminal appearance" should restrict the terminal to only using dark themes, even when in light mode.
The "Use theme background" checkbox should enable or disable the theme background in the terminal.
Ohh I misread that, I'll fix it 👍 |
austincondiff
left a comment
There was a problem hiding this comment.
Looks good, nice work!
Description
Passes theme background preference bindings to
TerminalEmulatorViewandCodeEditTextViewto change their backgrounds based on these preferences.Related Issue
Checklist
Screenshots
With a dark system appearance, the light editor themes will default to a white background if the
use theme backgroundbutton is toggled off due to some of the text blending into the background and vice versa for the light system appearance with dark editor themes as mentioned in #982 (comment)Screen.Recording.2023-01-19.at.11.34.22.PM.mov
Screen.Recording.2023-01-19.at.11.32.55.PM.mov