feat(settings): section with glob pattern crud#1507
feat(settings): section with glob pattern crud#1507tom-ludwig merged 15 commits intoCodeEditApp:mainfrom LeoBorai:1463-exclude-files-and-folders-from-project-find-and-open-quickly
Conversation
|
A pop-up might by a bit much. I think a table approach might be better? With editable rows |
Totally! Thats tho current approach now! Thanks for the feedback! |
|
Hey @EstebanBorai, how's it going on your end? Is the UI all set? If so, I can lend a hand in integrating it with the indexer. By the way, I've got #1465 on my plate, so feel free to merge the UI, and I'll roll out another PR incorporating your improvements for the actual indexing. |
Hey @activcoding! Yes please take a look, basically this implement the CRUD logic for Globs, its already loading from the settings file. Whats missing is the GlobPattern validation and actually make use of the GlobPatterns to ignore them |
|
@EstebanBorai thanks, I had a chat with Austin yesterday, and he's all good with merging this PR as long as the CRUD logic is solid in settings. Your changes will come into play in a future PR. I'll work on it as soon as I'm done with mine. |
tom-ludwig
left a comment
There was a problem hiding this comment.
Cheers, this is looking great. If you could make these minor tweaks, we'll be all set to merge.
CodeEdit/Features/Settings/Pages/SearchSettings/Models/SearchSettings.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SearchSettings/SearchSettingsIgnoreGlobPatternAddView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SearchSettings/SearchSettingsView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SearchSettings/SearchSettingsView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SearchSettings/SearchSettingsView.swift
Outdated
Show resolved
Hide resolved
…ettings.swift Co-authored-by: Tom Ludwig <tommludwig@icloud.com>
…View.swift Co-authored-by: Tom Ludwig <tommludwig@icloud.com>
tom-ludwig
left a comment
There was a problem hiding this comment.
Brilliant! Thanks for your great work.
Thanxs for you and @austincondiff for all the support guys! |


Description
Introduces a
Searchsection for Application Settings where the user is able toadd Glob Patterns for files that should be ignored in:
This PR adds UI primitives while enforcing ignored files will be implemented by @activcoding in a separate PR.
Refer to: #1507 (comment)
CleanShot.2024-01-30.at.23.01.14.mp4
Related Issues
Checklist
Screenshots