Fix Empty Editor State Bug#1556
Merged
thecoolwinter merged 3 commits intoCodeEditApp:mainfrom Jan 9, 2024
Merged
Conversation
Collaborator
austincondiff
left a comment
There was a problem hiding this comment.
Looks really good but it looks like you have a small SwiftLint error.
Collaborator
Author
|
@austincondiff fixed! |
LeoBorai
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a workspace is closed via an application quit with a split editor, the editor will allow the user to close all editors when the app is re-opened. This leaves the workspace completely unresponsive with no active editor splits.
To fix, moved logic that should be in
EditorManagerinto that class and cleaned up some files, then added a private state variable toEditorTabBarLeadingAccessoriesthat tracks an "other" editor if it exists. It updates that state variable when the editor manager updates at all now instead of doing the check on a view update.Related Issues
Checklist
Screenshots
mainbuild, after quitting the app with a split open:editor_layout_broken.mov
Fixed:
editor_layout_fixed.mov