fix(#1545): Split Editor Causes Hang#1565
Merged
austincondiff merged 4 commits intoCodeEditApp:mainfrom Jan 16, 2024
Merged
Conversation
- Adds `OpenOptions` to `CodeFileDocument` - Adds a new `EditorInstance` observable class to represent tabs for files instead of just `CEWorkspaceFile` - Refactors to use new `EditorInstance` everywhere.
austincondiff
approved these changes
Jan 16, 2024
Collaborator
austincondiff
left a comment
There was a problem hiding this comment.
Great work! Love the new EditorInstance class!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where opening the same file in a split editor would cause an infinite hang. The hang was caused by both editors in the split sharing a single published
cursorPositionsvariable. When one editor was unfocused, it would try to set that variable to be empty, but it was immediately updated by the newly focused editor to contain a new cursor position. This led to an infinite loop of both editors attempting to update the shared variable.To fix, I've added the notion of an 'instance' of an editor. There's now three levels of abstraction for a single editor:
The editor manager now manages editor instances instead of files.
I'd have liked to have #1564 merged before this one, but there are other problems with the CI making it take longer than expected, so this can be merged before that.
Related Issues
Checklist
Screenshots
N/A