fix: maximized button color issue#1607
Merged
austincondiff merged 6 commits intoCodeEditApp:mainfrom Mar 9, 2024
Merged
Conversation
austincondiff
requested changes
Mar 9, 2024
Collaborator
austincondiff
left a comment
There was a problem hiding this comment.
Good catch! It looks good and it does work, however I'd recommend a slightly different approach so we don't need a new ButtonStyle. See my comments for recommended changes. Thanks for your contribution!
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Contributor
Author
Thanks for your comments, looks better now. |
austincondiff
previously approved these changes
Mar 9, 2024
austincondiff
approved these changes
Mar 9, 2024
0xWDG
approved these changes
Mar 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Screenshots
before:
after:
dark theme
light theme