New tabs after current focused tab#1704#1715
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom May 14, 2024
Merged
Conversation
changed tab append to tab insert at index after selected tab
Fixed issue where tab deleted tab next to it.
thecoolwinter
approved these changes
May 14, 2024
Contributor
Author
|
Hey guys. I found an issue in this PR. When you open up a side window with a file and attempt to close that side window, it throws an exception. It occurs because the guard portion returns without completing the rest of the function. (The history and openfile portion). I'm new to the repo(open source in general) so I don't know what the right steps to take are. |
Member
|
Instead of using a guard, you could use an if let: if let selectedTab, let currentIndex = tabs.firstIndex(of: selectedTab) {
tabs.insert(item, at: tabs.index(after: currentIndex)
} else {
tabs.append(item)
} |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue where new tabs opened at the end of all opened files instead of next to currently selected file.
Within the open tab function, found the currently selected tab and appended the file to be opened in the next index.
Related Issues
Checklist
Screenshots