Activity View Resize, Inspector Toggle, Window Consistency#1776
Merged
austincondiff merged 7 commits intoCodeEditApp:mainfrom Jun 26, 2024
Merged
Activity View Resize, Inspector Toggle, Window Consistency#1776austincondiff merged 7 commits intoCodeEditApp:mainfrom
austincondiff merged 7 commits intoCodeEditApp:mainfrom
Conversation
austincondiff
requested changes
Jun 24, 2024
tom-ludwig
previously approved these changes
Jun 25, 2024
Member
tom-ludwig
left a comment
There was a problem hiding this comment.
Thanks for making those changes! 🚀🚀🚀
Collaborator
Author
I probably can, but it'll likely require going a different route than is implemented here. Why don't we make an issue for that and merge this, since it fixes a few critical bugs beyond that. I can begin working on it in the meantime. |
FastestMolasses
requested changes
Jun 25, 2024
Member
FastestMolasses
left a comment
There was a problem hiding this comment.
Just a small change, otherwise LGTM
austincondiff
approved these changes
Jun 26, 2024
Collaborator
|
@thecoolwinter I hope you don't mind me committing @FastestMolasses's request. I then approved and merged this PR and created #1780. |
This was referenced Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few issues with the windowing system, the toolbar, and the inspector.
focusedSceneObjectwe'll have to hack it into each of the three split views.Misc:
There's still some work to do on the toolbar. In the example video the branch picker disappears before the activity view, which imo should be the other way around. But it's def a step in the right direction.
Related Issues
Checklist
Screenshots
Before:
Toolbar removing wrong view:
Screen.Recording.2024-06-23.at.5.40.58.PM.mov
Resizing is awful:
Screen.Recording.2024-06-23.at.5.41.19.PM.mov
Now:
toolbar.mov
Still works w/ side tabs
