Fix WorkspaceDocument Leak#1808
Merged
thecoolwinter merged 12 commits intoCodeEditApp:mainfrom Jul 17, 2024
Merged
Conversation
CodeEdit/Features/Documents/Controllers/CodeEditSplitViewController.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Documents/Controllers/CodeEditSplitViewController.swift
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@austincondiff updated to have no force unwraps. Also after merging the CESE changes the last reference to |
austincondiff
previously approved these changes
Jul 15, 2024
tom-ludwig
previously approved these changes
Jul 16, 2024
...es/NavigatorArea/FindNavigator/FindNavigatorResultList/FindNavigatorListViewController.swift
Outdated
Show resolved
Hide resolved
...ea/ProjectNavigator/OutlineView/ProjectNavigatorViewController+NSOutlineViewDataSource.swift
Outdated
Show resolved
Hide resolved
0xWDG
previously approved these changes
Jul 16, 2024
4caf125
Collaborator
Author
|
@FastestMolasses @activcoding @0xWDG sorry need another review, had a merge conflict. I addressed the comments left earlier. |
0xWDG
approved these changes
Jul 17, 2024
FastestMolasses
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes various strong reference cycles throughout the app relating to either
WorkspaceDocument, related window controllers, view controllers, or sub-models.This does not entirely close # 1794. There is still some leaked outline view cells that are strongly referencing workspace files (no idea why).After updating CESE,
CodeFileDocumentis no longer strongly referenced. There is still an issue with the project navigator's cells staying alive after the window closing but I think this PR is substantial enough to merge now.Substantial changes:
StandardTableViewCellto use the built-in label and icon properties, and adding the secondary label on top ofNSTableViewCell.ExtensionDiscoveryslightly reworked to better support cancellation of tasks.performCloseovercloseon window objects (this will animate the close button being pressed, and is what should be used in window commands).@UpdatingWindowControllerthat weakly references and auto-updates a window controller variable. Useful in SwiftUI views or commands that need updating access to the current window controller.Note
For reviewers, this has a lot of small changes, but there should be no functionality changes.
Related Issues
Checklist
Screenshots
N/A. No UI changes.