Use NSApp.keyWindow Over Global keyWindow#1819
Merged
matthijseikelenboom merged 1 commit intoCodeEditApp:mainfrom Jul 22, 2024
Merged
Use NSApp.keyWindow Over Global keyWindow#1819matthijseikelenboom merged 1 commit intoCodeEditApp:mainfrom
NSApp.keyWindow Over Global keyWindow#1819matthijseikelenboom merged 1 commit intoCodeEditApp:mainfrom
Conversation
FastestMolasses
approved these changes
Jul 22, 2024
bombardier200
approved these changes
Jul 22, 2024
0xWDG
approved these changes
Jul 22, 2024
matthijseikelenboom
approved these changes
Jul 22, 2024
Contributor
|
Insane. This also helped with a bug when working on #1820. After interacting with a preview, pressing #1796. This fix also doesn't let |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the current build, using command-W throws an exception. This fixes that by swapping out the use of the global
keyWindowwithNSApp.keyWindow.This error appears to have appeared recently, but the global
keyWindowshould never have been used in the first place. It may have been the case that the use of this variable was previously linked to a different, similarly named, one by the compiler. But it now points to this header.I've also added UI tests for all windows for the command-w command, and the command-shift-w command in workspaces.
Related Issues
Checklist