Fixed terminal resize and scroll layout issues, improved utility area toggle animation#1845
Merged
thecoolwinter merged 6 commits intoCodeEditApp:mainfrom Aug 16, 2024
Merged
Conversation
…l. Removed the maximize drawer button in favor of simply dragging to resize up.
FastestMolasses
previously approved these changes
Aug 11, 2024
tom-ludwig
requested changes
Aug 13, 2024
Member
tom-ludwig
left a comment
There was a problem hiding this comment.
Just one little thing, and it’s good to go!
Co-authored-by: Tom Ludwig <tommludwig@icloud.com>
tom-ludwig
approved these changes
Aug 13, 2024
Collaborator
Author
|
It might be nice to fix the terminal to the top (how it was before) if the scroll position is at the very top. This way the terminal contents are both aligned to the top and when the utility area drawer is resized, the terminal content follows it smoothly. I am not sure how to grab the terminal scroll position we'd need in order to do this though. |
thecoolwinter
approved these changes
Aug 16, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the terminal was resized, it displayed partial lines at the bottom due to a remainder in the line height multiple. This caused two things:
The terminal height must now be a multiple of a single line’s height to resolve these issues.
Utility area drawer now has a push/pull animation rather than a reveal.
Checklist
Screenshots
Before
codeedit-terminal-height-fix-before-resize-scroll.mov
codeedit-terminal-height-fix-before-resize.mov
After
codeedit-terminal-height-fix-after.mov
VS Code handles this in a similar way
vscode-terminal-height-resize.mov
Improved utility area animation
Screen.Recording.2024-08-10.at.12.44.40.AM.mov
Note
I removed the maximize drawer toggle in favor of simply dragging to resize up. This simplifies things greatly.