LSP Activates On Workspace Files, LSP Document Open/Close#1879
Merged
thecoolwinter merged 10 commits intoCodeEditApp:mainfrom Sep 18, 2024
Merged
LSP Activates On Workspace Files, LSP Document Open/Close#1879thecoolwinter merged 10 commits intoCodeEditApp:mainfrom
thecoolwinter merged 10 commits intoCodeEditApp:mainfrom
Conversation
austincondiff
previously approved these changes
Sep 14, 2024
Collaborator
austincondiff
left a comment
There was a problem hiding this comment.
Real solid work @thecoolwinter! 👍
tom-ludwig
previously requested changes
Sep 15, 2024
Member
tom-ludwig
left a comment
There was a problem hiding this comment.
Amazing PR! 🎉 Just a few updates needed in the docs 👍
CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFileManager+FileManagement.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/LSP/LanguageServer/Capabilities/LanguageServer+DocumentSync.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/LSP/LanguageServer/Capabilities/LanguageServer+DocumentSync.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/LSP/LanguageServer/Capabilities/LanguageServer+DocumentSync.swift
Outdated
Show resolved
Hide resolved
austincondiff
previously approved these changes
Sep 16, 2024
6 tasks
Collaborator
Author
|
Sorry @austincondiff need another approval, fixed a failing test related to a subtle bug in #1840. |
6 tasks
matthijseikelenboom
previously approved these changes
Sep 18, 2024
Contributor
matthijseikelenboom
left a comment
There was a problem hiding this comment.
Great progress! Left some a small amount of comments
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift
Outdated
Show resolved
Hide resolved
0xWDG
previously approved these changes
Sep 18, 2024
Collaborator
0xWDG
left a comment
There was a problem hiding this comment.
LGTM, i agree with the points of @matthijseikelenboom
ecd03c8
Collaborator
Author
|
Tracking issue for the commented-out event and notification handlers: #1888 |
matthijseikelenboom
approved these changes
Sep 18, 2024
0xWDG
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Main changes:
LanguageServertype to use the existing workspace file management system.Misc details:
LanguageServermethods to read more like sentences. Eg: instead ofserver.requestDocumentHighlight(document: document)an API consumer would readserver. requestHighlight(for: document)CodeFileDocumentclass. A new methodgetLanguage()guesses the language for the document unless it has been overriden.LazyServicedep injection property wrapper that is the same asServicebut evaluates the service lazily. See usage.URLextensions to one folder.LanguageServerstruct to a class. It's a long-living value that we'll need to reference in things like a text coordinator so a class makes more sense here. @FastestMolasses and I have had a bit of a back and forth on this. Originally it was made a struct to make async/await easier. So I investigated making itSendableto fulfill that goal. However it needs to manage state like opened files, which breaks the immutability of sendable values.Related Issues
N/A
Checklist