Fix Edited Indicator Behavior#1910
Merged
tom-ludwig merged 3 commits intoCodeEditApp:mainfrom Oct 19, 2024
Merged
Conversation
- The autosave() method provided by NSDocument automatically calls updateChangeCount accordingly, as such, removing the direct call to updateChangeCount with a value of .changeCleared resolves the issue - This aligns with Xcode's current implementation
tom-ludwig
requested changes
Oct 18, 2024
Contributor
Author
|
Just added a comment 👍 |
austincondiff
approved these changes
Oct 19, 2024
tom-ludwig
approved these changes
Oct 19, 2024
Member
tom-ludwig
left a comment
There was a problem hiding this comment.
Perfect 👊🏼. Thank you very much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The edited indicator behavior now properly updates and aligns with Xcode's implementation.
The autosave() method provided by NSDocument automatically calls updateChangeCount accordingly. The else block in the function executed regardless of whether autosaving occurred or was enabled, triggering an unintended cleared state. As such, removing the direct call to updateChangeCount(.changeCleared) resolved the issue as the change count state is now handled properly by the autosave() method.
Related Issues
Checklist
Screenshots
With Manual Saving
Screen.Recording.2024-10-17.at.1.31.39.AM.mov
With Auto Save
Screen.Recording.2024-10-17.at.1.32.48.AM.mov