Support DataProvider attribute in unit tests#6491
Merged
Naktibalda merged 2 commits into5.0from Jul 6, 2022
Merged
Conversation
2813c81 to
d7a2c86
Compare
Drops support for @backupGlobals, @backupStaticAttributes, @preserveGlobalState and @testwith annotations
TavoNiievez
reviewed
Jul 4, 2022
DavertMik
approved these changes
Jul 4, 2022
| use function array_merge; | ||
| use function sprintf; | ||
|
|
||
| class DataProvider |
Member
There was a problem hiding this comment.
Creating this class is a brilliant idea! 👏
TavoNiievez
approved these changes
Jul 4, 2022
|
Hey @Naktibalda could you give a bit more context why did you replaced and do you have any recommendation which one use?
|
Member
Author
|
@eerison |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for
#[\Codeception\Attribute\DataProvider],#[\Codeception\Attribute\Examples]and@exampleannotation in unit tests.Drops support for
#[\PHPUnit\Attribute\DataProvider],@backupGlobals,@backupStaticAttributes,@preserveGlobalStateand @testwithannotations.I reused new DataProvider class is Cest Loader.
New possibilities: