Fix include path for behat/gherkin v4.12#6836
Closed
W0rma wants to merge 1 commit intoCodeception:mainfrom
Closed
Conversation
9cb8593 to
426e50c
Compare
…herkin This makes the determination of the include path for the i18n file independent from the location of some class of this package. That's especially helpful because v4.12 relocated some source files which broke the previous approach.
426e50c to
a4c6b09
Compare
Contributor
Author
|
@Naktibalda @TavoNiievez What's your opinion here? Currently, test pipelines for some codeception modules fail if the latest |
Member
|
@W0rma If this is the only place in the code where |
Contributor
Author
|
@TavoNiievez Thank you for your reply. I created the new PR #6839 which uses a much more cleaner way to fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6833
https://getcomposer.org/doc/07-runtime.md#knowing-the-path-in-which-a-package-is-installed is used to determine the vendor directory of the
behat/gherkincomposer package.This way it is no longer necessary to work with paths relative to some source files which was broken because
behat/gherkin:4.12relocated some source files.