Feat: haveInDatabase tear down use row values if primary key values are available#44
Merged
Naktibalda merged 2 commits intoCodeception:2.xfrom Dec 3, 2022
Conversation
Naktibalda
reviewed
Dec 2, 2022
Member
|
Thank you |
|
@JesusTheHun What about using |
Member
|
yes, it is a bug, please raise pull request to fix it. |
Contributor
Author
|
@YaakovR can you tell me what db you are using ? I tried with MySQL which (sadly) returns |
|
@JesusTheHun SQL Server |
This was referenced Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
Db::addInsertedRow()uses thelastInsertIdto remove the row during tear down.In some case the primary key is not auto incremented but another column is.
The row being referenced with
['id' => 1]because$driver->lastInsertId()returns1, and the module assumes it's the PK value.This PR fixes this behaviour by checking if the provided values cover the primary key. If so, it uses those value, if not it follows the default behaviour.