fix Kafka consumer instrumentation#10102
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: b35f5ef | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 12 performance improvements and 10 performance regressions! Performance is the same for 33 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1099490
Total [baseline] (8.837 s) : 0, 8837159
Agent [candidate] (1.06 s) : 0, 1059716
Total [candidate] (8.711 s) : 0, 8711480
section iast
Agent [baseline] (1.239 s) : 0, 1238787
Total [baseline] (9.579 s) : 0, 9579014
Agent [candidate] (1.191 s) : 0, 1191486
Total [candidate] (9.354 s) : 0, 9354437
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (707.088 ms) : 0, 707088
BytebuddyAgent [candidate] (713.665 ms) : 0, 713665
GlobalTracer [baseline] (248.654 ms) : 0, 248654
GlobalTracer [candidate] (250.301 ms) : 0, 250301
AppSec [baseline] (32.021 ms) : 0, 32021
AppSec [candidate] (31.981 ms) : 0, 31981
Debugger [baseline] (63.024 ms) : 0, 63024
Debugger [candidate] (6.395 ms) : 0, 6395
Remote Config [baseline] (644.355 µs) : 0, 644
Remote Config [candidate] (683.473 µs) : 0, 683
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (14.661 ms) : 0, 14661
Flare Poller [baseline] (3.623 ms) : 0, 3623
Flare Poller [candidate] (5.519 ms) : 0, 5519
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (831.428 ms) : 0, 831428
BytebuddyAgent [candidate] (831.113 ms) : 0, 831113
GlobalTracer [baseline] (237.783 ms) : 0, 237783
GlobalTracer [candidate] (237.356 ms) : 0, 237356
IAST [baseline] (27.481 ms) : 0, 27481
IAST [candidate] (31.459 ms) : 0, 31459
AppSec [baseline] (33.961 ms) : 0, 33961
AppSec [candidate] (29.784 ms) : 0, 29784
Debugger [baseline] (60.029 ms) : 0, 60029
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (535.868 µs) : 0, 536
Remote Config [candidate] (611.891 µs) : 0, 612
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.949 ms) : 0, 7949
Flare Poller [baseline] (3.456 ms) : 0, 3456
Flare Poller [candidate] (10.745 ms) : 0, 10745
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.119 s) : 0, 1119053
Total [baseline] (10.811 s) : 0, 10810687
Agent [candidate] (1.053 s) : 0, 1053280
Total [candidate] (10.853 s) : 0, 10852817
section appsec
Agent [baseline] (1.288 s) : 0, 1288416
Total [baseline] (11.136 s) : 0, 11135985
Agent [candidate] (1.231 s) : 0, 1230667
Total [candidate] (10.884 s) : 0, 10883534
section iast
Agent [baseline] (1.242 s) : 0, 1241969
Total [baseline] (11.284 s) : 0, 11284265
Agent [candidate] (1.189 s) : 0, 1188984
Total [candidate] (11.196 s) : 0, 11196485
section profiling
Agent [baseline] (1.235 s) : 0, 1234808
Total [baseline] (11.174 s) : 0, 11174143
Agent [candidate] (1.198 s) : 0, 1198430
Total [candidate] (10.876 s) : 0, 10876353
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (718.723 ms) : 0, 718723
BytebuddyAgent [candidate] (707.717 ms) : 0, 707717
GlobalTracer [baseline] (252.618 ms) : 0, 252618
GlobalTracer [candidate] (250.113 ms) : 0, 250113
AppSec [baseline] (32.734 ms) : 0, 32734
AppSec [candidate] (31.882 ms) : 0, 31882
Debugger [baseline] (65.531 ms) : 0, 65531
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (642.987 µs) : 0, 643
Remote Config [candidate] (666.316 µs) : 0, 666
Telemetry [baseline] (8.365 ms) : 0, 8365
Telemetry [candidate] (14.62 ms) : 0, 14620
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (5.569 ms) : 0, 5569
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (734.855 ms) : 0, 734855
BytebuddyAgent [candidate] (732.835 ms) : 0, 732835
GlobalTracer [baseline] (243.01 ms) : 0, 243010
GlobalTracer [candidate] (241.456 ms) : 0, 241456
IAST [baseline] (25.061 ms) : 0, 25061
IAST [candidate] (24.82 ms) : 0, 24820
AppSec [baseline] (174.579 ms) : 0, 174579
AppSec [candidate] (175.563 ms) : 0, 175563
Debugger [baseline] (61.571 ms) : 0, 61571
Debugger [candidate] (6.366 ms) : 0, 6366
Remote Config [baseline] (682.752 µs) : 0, 683
Remote Config [candidate] (680.254 µs) : 0, 680
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.206 ms) : 0, 8206
Flare Poller [baseline] (3.905 ms) : 0, 3905
Flare Poller [candidate] (4.087 ms) : 0, 4087
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (832.823 ms) : 0, 832823
BytebuddyAgent [candidate] (829.165 ms) : 0, 829165
GlobalTracer [baseline] (238.321 ms) : 0, 238321
GlobalTracer [candidate] (236.865 ms) : 0, 236865
IAST [baseline] (27.707 ms) : 0, 27707
IAST [candidate] (28.868 ms) : 0, 28868
AppSec [baseline] (34.012 ms) : 0, 34012
AppSec [candidate] (32.179 ms) : 0, 32179
Debugger [baseline] (60.9 ms) : 0, 60900
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (544.478 µs) : 0, 544
Remote Config [candidate] (610.326 µs) : 0, 610
Telemetry [baseline] (7.592 ms) : 0, 7592
Telemetry [candidate] (7.965 ms) : 0, 7965
Flare Poller [baseline] (3.549 ms) : 0, 3549
Flare Poller [candidate] (10.89 ms) : 0, 10890
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (734.52 ms) : 0, 734520
BytebuddyAgent [candidate] (734.086 ms) : 0, 734086
GlobalTracer [baseline] (222.887 ms) : 0, 222887
GlobalTracer [candidate] (222.681 ms) : 0, 222681
AppSec [baseline] (32.005 ms) : 0, 32005
AppSec [candidate] (32.017 ms) : 0, 32017
Debugger [baseline] (63.902 ms) : 0, 63902
Debugger [candidate] (6.804 ms) : 0, 6804
Remote Config [baseline] (654.599 µs) : 0, 655
Remote Config [candidate] (673.339 µs) : 0, 673
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (16.613 ms) : 0, 16613
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (4.138 ms) : 0, 4138
ProfilingAgent [baseline] (97.869 ms) : 0, 97869
ProfilingAgent [candidate] (110.21 ms) : 0, 110210
Profiling [baseline] (98.472 ms) : 0, 98472
Profiling [candidate] (110.852 ms) : 0, 110852
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (19.045 ms) : 18855, 19236
. : milestone, 19045,
appsec (18.771 ms) : 18577, 18964
. : milestone, 18771,
code_origins (17.942 ms) : 17758, 18127
. : milestone, 17942,
iast (17.504 ms) : 17330, 17678
. : milestone, 17504,
profiling (18.938 ms) : 18747, 19130
. : milestone, 18938,
tracing (17.428 ms) : 17258, 17599
. : milestone, 17428,
section candidate
no_agent (18.001 ms) : 17816, 18185
. : milestone, 18001,
appsec (18.472 ms) : 18288, 18656
. : milestone, 18472,
code_origins (17.88 ms) : 17704, 18055
. : milestone, 17880,
iast (19.055 ms) : 18863, 19248
. : milestone, 19055,
profiling (19.36 ms) : 19165, 19555
. : milestone, 19360,
tracing (19.443 ms) : 19248, 19639
. : milestone, 19443,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.219 ms) : 1207, 1230
. : milestone, 1219,
iast (3.197 ms) : 3150, 3243
. : milestone, 3197,
iast_FULL (5.948 ms) : 5888, 6008
. : milestone, 5948,
iast_GLOBAL (3.701 ms) : 3637, 3764
. : milestone, 3701,
profiling (2.12 ms) : 2100, 2140
. : milestone, 2120,
tracing (1.832 ms) : 1816, 1848
. : milestone, 1832,
section candidate
no_agent (1.205 ms) : 1192, 1218
. : milestone, 1205,
iast (3.235 ms) : 3191, 3280
. : milestone, 3235,
iast_FULL (6.04 ms) : 5978, 6101
. : milestone, 6040,
iast_GLOBAL (3.546 ms) : 3495, 3598
. : milestone, 3546,
profiling (2.143 ms) : 2124, 2162
. : milestone, 2143,
tracing (1.834 ms) : 1819, 1849
. : milestone, 1834,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (15.527 s) : 15527000, 15527000
. : milestone, 15527000,
appsec (14.765 s) : 14765000, 14765000
. : milestone, 14765000,
iast (18.589 s) : 18589000, 18589000
. : milestone, 18589000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
. : milestone, 17930000,
profiling (14.537 s) : 14537000, 14537000
. : milestone, 14537000,
tracing (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
section candidate
no_agent (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
appsec (14.692 s) : 14692000, 14692000
. : milestone, 14692000,
iast (18.488 s) : 18488000, 18488000
. : milestone, 18488000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
. : milestone, 18215000,
profiling (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
tracing (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b35f5efcf4, baseline=1.56.0~c05874d84e
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.656 ms) : 3439, 3873
. : milestone, 3656,
iast (2.216 ms) : 2151, 2280
. : milestone, 2216,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.081 ms) : 2027, 2136
. : milestone, 2081,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.699 ms) : 3482, 3916
. : milestone, 3699,
iast (2.212 ms) : 2147, 2276
. : milestone, 2212,
iast_GLOBAL (2.258 ms) : 2193, 2322
. : milestone, 2258,
profiling (2.079 ms) : 2026, 2133
. : milestone, 2079,
tracing (2.041 ms) : 1990, 2091
. : milestone, 2041,
|
|
Bypassing a flaky test for to unblock a patch release to resolve an incident. |
What Does This Do
Backport: #10100
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]