remove colons from process tags values by vandonr · Pull Request #10109 · DataDog/dd-trace-java

vandonr · 2025-12-09T07:21:11Z

What Does This Do

I realized that Java "only" applied the normal tag value normalization, but for process tags, the spec states that colons are forbidden, so I added that extra step (before normalization to make sure consecutive _ are collapsed).
Also added tests on normalization.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-12-09T07:21:23Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-12-09T08:06:34Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1765234372	1765264464
git_commit_sha	`aff0473`	`9f819c3`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~9f819c356e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765266518	1765266518
ci_job_id	1278340772	1278340772
ci_pipeline_id	85491678	85491678
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-r8beso8f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-r8beso8f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092050
Total [baseline] (8.772 s) : 0, 8772481
Agent [candidate] (1.081 s) : 0, 1081017
Total [candidate] (8.729 s) : 0, 8728924
section iast
Agent [baseline] (1.221 s) : 0, 1220758
Total [baseline] (9.445 s) : 0, 9445162
Agent [candidate] (1.221 s) : 0, 1220633
Total [candidate] (9.414 s) : 0, 9414225

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	iast	1.221 s	128.708 ms (11.8%)
Total	tracing	8.772 s	-
Total	iast	9.445 s	672.681 ms (7.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.221 s	139.615 ms (12.9%)
Total	tracing	8.729 s	-
Total	iast	9.414 s	685.302 ms (7.9%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (656.173 ms) : 0, 656173
BytebuddyAgent [candidate] (649.236 ms) : 0, 649236
GlobalTracer [baseline] (284.251 ms) : 0, 284251
GlobalTracer [candidate] (281.937 ms) : 0, 281937
AppSec [baseline] (32.814 ms) : 0, 32814
AppSec [candidate] (32.445 ms) : 0, 32445
Debugger [baseline] (68.169 ms) : 0, 68169
Debugger [candidate] (67.189 ms) : 0, 67189
Remote Config [baseline] (665.804 µs) : 0, 666
Remote Config [candidate] (654.994 µs) : 0, 655
Telemetry [baseline] (9.195 ms) : 0, 9195
Telemetry [candidate] (9.042 ms) : 0, 9042
Flare Poller [baseline] (3.846 ms) : 0, 3846
Flare Poller [candidate] (3.814 ms) : 0, 3814
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (790.255 ms) : 0, 790255
BytebuddyAgent [candidate] (789.847 ms) : 0, 789847
GlobalTracer [baseline] (255.139 ms) : 0, 255139
GlobalTracer [candidate] (255.318 ms) : 0, 255318
IAST [baseline] (27.02 ms) : 0, 27020
IAST [candidate] (26.907 ms) : 0, 26907
AppSec [baseline] (35.152 ms) : 0, 35152
AppSec [candidate] (35.094 ms) : 0, 35094
Debugger [baseline] (64.405 ms) : 0, 64405
Debugger [candidate] (64.563 ms) : 0, 64563
Remote Config [baseline] (556.29 µs) : 0, 556
Remote Config [candidate] (578.716 µs) : 0, 579
Telemetry [baseline] (8.347 ms) : 0, 8347
Telemetry [candidate] (8.357 ms) : 0, 8357
Flare Poller [baseline] (3.42 ms) : 0, 3420
Flare Poller [candidate] (3.477 ms) : 0, 3477

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078981
Total [baseline] (10.817 s) : 0, 10817110
Agent [candidate] (1.08 s) : 0, 1079670
Total [candidate] (10.855 s) : 0, 10854960
section appsec
Agent [baseline] (1.274 s) : 0, 1273549
Total [baseline] (11.14 s) : 0, 11139717
Agent [candidate] (1.262 s) : 0, 1261791
Total [candidate] (11.078 s) : 0, 11078405
section iast
Agent [baseline] (1.22 s) : 0, 1220167
Total [baseline] (11.139 s) : 0, 11139434
Agent [candidate] (1.219 s) : 0, 1219245
Total [candidate] (11.124 s) : 0, 11124242
section profiling
Agent [baseline] (1.204 s) : 0, 1203517
Total [baseline] (11.126 s) : 0, 11126390
Agent [candidate] (1.202 s) : 0, 1202216
Total [candidate] (11.029 s) : 0, 11028762

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	appsec	1.274 s	194.568 ms (18.0%)
Agent	iast	1.22 s	141.186 ms (13.1%)
Agent	profiling	1.204 s	124.536 ms (11.5%)
Total	tracing	10.817 s	-
Total	appsec	11.14 s	322.607 ms (3.0%)
Total	iast	11.139 s	322.324 ms (3.0%)
Total	profiling	11.126 s	309.28 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	appsec	1.262 s	182.121 ms (16.9%)
Agent	iast	1.219 s	139.575 ms (12.9%)
Agent	profiling	1.202 s	122.546 ms (11.4%)
Total	tracing	10.855 s	-
Total	appsec	11.078 s	223.445 ms (2.1%)
Total	iast	11.124 s	269.282 ms (2.5%)
Total	profiling	11.029 s	173.802 ms (1.6%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (647.153 ms) : 0, 647153
BytebuddyAgent [candidate] (647.831 ms) : 0, 647831
GlobalTracer [baseline] (280.831 ms) : 0, 280831
GlobalTracer [candidate] (281.665 ms) : 0, 281665
AppSec [baseline] (32.347 ms) : 0, 32347
AppSec [candidate] (32.018 ms) : 0, 32018
Debugger [baseline] (68.7 ms) : 0, 68700
Debugger [candidate] (68.006 ms) : 0, 68006
Remote Config [baseline] (624.38 µs) : 0, 624
Remote Config [candidate] (636.802 µs) : 0, 637
Telemetry [baseline] (8.999 ms) : 0, 8999
Telemetry [candidate] (9.111 ms) : 0, 9111
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.78 ms) : 0, 3780
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (694.529 ms) : 0, 694529
BytebuddyAgent [candidate] (687.764 ms) : 0, 687764
GlobalTracer [baseline] (261.172 ms) : 0, 261172
GlobalTracer [candidate] (258.739 ms) : 0, 258739
IAST [baseline] (24.757 ms) : 0, 24757
IAST [candidate] (24.702 ms) : 0, 24702
AppSec [baseline] (175.637 ms) : 0, 175637
AppSec [candidate] (174.678 ms) : 0, 174678
Debugger [baseline] (66.603 ms) : 0, 66603
Debugger [candidate] (65.783 ms) : 0, 65783
Remote Config [baseline] (725.135 µs) : 0, 725
Remote Config [candidate] (688.235 µs) : 0, 688
Telemetry [baseline] (9.193 ms) : 0, 9193
Telemetry [candidate] (8.989 ms) : 0, 8989
Flare Poller [baseline] (4.039 ms) : 0, 4039
Flare Poller [candidate] (3.798 ms) : 0, 3798
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (788.843 ms) : 0, 788843
BytebuddyAgent [candidate] (788.409 ms) : 0, 788409
GlobalTracer [baseline] (254.639 ms) : 0, 254639
GlobalTracer [candidate] (254.387 ms) : 0, 254387
IAST [baseline] (27.057 ms) : 0, 27057
IAST [candidate] (26.765 ms) : 0, 26765
AppSec [baseline] (35.35 ms) : 0, 35350
AppSec [candidate] (34.444 ms) : 0, 34444
Debugger [baseline] (65.448 ms) : 0, 65448
Debugger [candidate] (66.279 ms) : 0, 66279
Remote Config [baseline] (534.444 µs) : 0, 534
Remote Config [candidate] (587.777 µs) : 0, 588
Telemetry [baseline] (8.429 ms) : 0, 8429
Telemetry [candidate] (8.382 ms) : 0, 8382
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.49 ms) : 0, 3490
section profiling
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (701.927 ms) : 0, 701927
BytebuddyAgent [candidate] (700.538 ms) : 0, 700538
GlobalTracer [baseline] (220.217 ms) : 0, 220217
GlobalTracer [candidate] (220.788 ms) : 0, 220788
AppSec [baseline] (32.299 ms) : 0, 32299
AppSec [candidate] (32.199 ms) : 0, 32199
Debugger [baseline] (68.136 ms) : 0, 68136
Debugger [candidate] (67.917 ms) : 0, 67917
Remote Config [baseline] (675.714 µs) : 0, 676
Remote Config [candidate] (613.935 µs) : 0, 614
Telemetry [baseline] (9.103 ms) : 0, 9103
Telemetry [candidate] (8.932 ms) : 0, 8932
Flare Poller [baseline] (3.86 ms) : 0, 3860
Flare Poller [candidate] (3.778 ms) : 0, 3778
ProfilingAgent [baseline] (96.686 ms) : 0, 96686
ProfilingAgent [candidate] (96.894 ms) : 0, 96894
Profiling [baseline] (97.276 ms) : 0, 97276
Profiling [candidate] (97.459 ms) : 0, 97459

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1765234372	1765264464
git_commit_sha	`aff0473`	`9f819c3`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~9f819c356e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765267010	1765267010
ci_job_id	1278340773	1278340773
ci_pipeline_id	85491678	85491678
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-6h63fzg2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-6h63fzg2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	better [-343.674µs; -126.170µs] or [-6.481%; -2.379%]	better [-814.543µs; -337.718µs] or [-6.464%; -2.680%]	unstable [-50.979op/s; +111.166op/s] or [-6.569%; +14.324%]	5.068ms	12.026ms	806.156op/s	5.303ms	12.602ms	776.062op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-387.712µs; -226.014µs] or [-12.439%; -7.251%]	better [-795.156µs; -306.779µs] or [-9.197%; -3.548%]	unstable [-45.751op/s; +227.063op/s] or [-3.883%; +19.270%]	2.810ms	8.095ms	1269.000op/s	3.117ms	8.646ms	1178.344op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.195 ms) : 1183, 1207
.   : milestone, 1195,
iast (3.266 ms) : 3224, 3309
.   : milestone, 3266,
iast_FULL (5.958 ms) : 5898, 6018
.   : milestone, 5958,
iast_GLOBAL (3.896 ms) : 3839, 3954
.   : milestone, 3896,
profiling (2.104 ms) : 2086, 2123
.   : milestone, 2104,
tracing (1.776 ms) : 1762, 1791
.   : milestone, 1776,
section candidate
no_agent (1.203 ms) : 1191, 1215
.   : milestone, 1203,
iast (3.212 ms) : 3167, 3257
.   : milestone, 3212,
iast_FULL (5.732 ms) : 5675, 5789
.   : milestone, 5732,
iast_GLOBAL (3.614 ms) : 3557, 3671
.   : milestone, 3614,
profiling (2.195 ms) : 2175, 2215
.   : milestone, 2195,
tracing (1.884 ms) : 1867, 1901
.   : milestone, 1884,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.195 ms [1.183 ms, 1.207 ms]	-
iast	3.266 ms [3.224 ms, 3.309 ms]	2.071 ms (173.3%)
iast_FULL	5.958 ms [5.898 ms, 6.018 ms]	4.763 ms (398.5%)
iast_GLOBAL	3.896 ms [3.839 ms, 3.954 ms]	2.701 ms (226.0%)
profiling	2.104 ms [2.086 ms, 2.123 ms]	909.211 µs (76.1%)
tracing	1.776 ms [1.762 ms, 1.791 ms]	581.048 µs (48.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.203 ms [1.191 ms, 1.215 ms]	-
iast	3.212 ms [3.167 ms, 3.257 ms]	2.009 ms (167.0%)
iast_FULL	5.732 ms [5.675 ms, 5.789 ms]	4.529 ms (376.5%)
iast_GLOBAL	3.614 ms [3.557 ms, 3.671 ms]	2.411 ms (200.4%)
profiling	2.195 ms [2.175 ms, 2.215 ms]	992.147 µs (82.5%)
tracing	1.884 ms [1.867 ms, 1.901 ms]	681.073 µs (56.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.64 ms) : 19437, 19844
.   : milestone, 19640,
appsec (19.055 ms) : 18859, 19251
.   : milestone, 19055,
code_origins (17.846 ms) : 17668, 18024
.   : milestone, 17846,
iast (17.936 ms) : 17758, 18115
.   : milestone, 17936,
profiling (18.729 ms) : 18539, 18920
.   : milestone, 18729,
tracing (17.656 ms) : 17482, 17830
.   : milestone, 17656,
section candidate
no_agent (19.407 ms) : 19209, 19605
.   : milestone, 19407,
appsec (18.866 ms) : 18674, 19059
.   : milestone, 18866,
code_origins (17.962 ms) : 17785, 18138
.   : milestone, 17962,
iast (17.737 ms) : 17562, 17911
.   : milestone, 17737,
profiling (18.614 ms) : 18428, 18799
.   : milestone, 18614,
tracing (17.843 ms) : 17663, 18023
.   : milestone, 17843,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.64 ms [19.437 ms, 19.844 ms]	-
appsec	19.055 ms [18.859 ms, 19.251 ms]	-585.069 µs (-3.0%)
code_origins	17.846 ms [17.668 ms, 18.024 ms]	-1.794 ms (-9.1%)
iast	17.936 ms [17.758 ms, 18.115 ms]	-1.704 ms (-8.7%)
profiling	18.729 ms [18.539 ms, 18.92 ms]	-910.733 µs (-4.6%)
tracing	17.656 ms [17.482 ms, 17.83 ms]	-1.984 ms (-10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.407 ms [19.209 ms, 19.605 ms]	-
appsec	18.866 ms [18.674 ms, 19.059 ms]	-540.869 µs (-2.8%)
code_origins	17.962 ms [17.785 ms, 18.138 ms]	-1.445 ms (-7.4%)
iast	17.737 ms [17.562 ms, 17.911 ms]	-1.67 ms (-8.6%)
profiling	18.614 ms [18.428 ms, 18.799 ms]	-793.421 µs (-4.1%)
tracing	17.843 ms [17.663 ms, 18.023 ms]	-1.564 ms (-8.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1765234372	1765264464
git_commit_sha	`aff0473`	`9f819c3`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~9f819c356e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765266777	1765266777
ci_job_id	1278340774	1278340774
ci_pipeline_id	85491678	85491678
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-oy0nz9hi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-oy0nz9hi 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.736 ms) : 3514, 3958
.   : milestone, 3736,
iast (2.24 ms) : 2175, 2304
.   : milestone, 2240,
iast_GLOBAL (2.28 ms) : 2214, 2345
.   : milestone, 2280,
profiling (2.084 ms) : 2031, 2136
.   : milestone, 2084,
tracing (2.054 ms) : 2003, 2105
.   : milestone, 2054,
section candidate
no_agent (1.483 ms) : 1472, 1495
.   : milestone, 1483,
appsec (3.71 ms) : 3493, 3927
.   : milestone, 3710,
iast (2.229 ms) : 2164, 2293
.   : milestone, 2229,
iast_GLOBAL (2.277 ms) : 2212, 2343
.   : milestone, 2277,
profiling (2.109 ms) : 2055, 2164
.   : milestone, 2109,
tracing (2.06 ms) : 2010, 2111
.   : milestone, 2060,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.736 ms [3.514 ms, 3.958 ms]	2.257 ms (152.6%)
iast	2.24 ms [2.175 ms, 2.304 ms]	760.424 µs (51.4%)
iast_GLOBAL	2.28 ms [2.214 ms, 2.345 ms]	800.422 µs (54.1%)
profiling	2.084 ms [2.031 ms, 2.136 ms]	604.388 µs (40.9%)
tracing	2.054 ms [2.003 ms, 2.105 ms]	575.183 µs (38.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.472 ms, 1.495 ms]	-
appsec	3.71 ms [3.493 ms, 3.927 ms]	2.227 ms (150.1%)
iast	2.229 ms [2.164 ms, 2.293 ms]	745.399 µs (50.3%)
iast_GLOBAL	2.277 ms [2.212 ms, 2.343 ms]	794.319 µs (53.6%)
profiling	2.109 ms [2.055 ms, 2.164 ms]	626.188 µs (42.2%)
tracing	2.06 ms [2.01 ms, 2.111 ms]	577.31 µs (38.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f819c356e, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.976 s) : 14976000, 14976000
.   : milestone, 14976000,
appsec (14.693 s) : 14693000, 14693000
.   : milestone, 14693000,
iast (18.179 s) : 18179000, 18179000
.   : milestone, 18179000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
.   : milestone, 17877000,
profiling (14.576 s) : 14576000, 14576000
.   : milestone, 14576000,
tracing (14.538 s) : 14538000, 14538000
.   : milestone, 14538000,
section candidate
no_agent (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
appsec (14.723 s) : 14723000, 14723000
.   : milestone, 14723000,
iast (18.393 s) : 18393000, 18393000
.   : milestone, 18393000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (14.57 s) : 14570000, 14570000
.   : milestone, 14570000,
tracing (14.944 s) : 14944000, 14944000
.   : milestone, 14944000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.976 s [14.976 s, 14.976 s]	-
appsec	14.693 s [14.693 s, 14.693 s]	-283.0 ms (-1.9%)
iast	18.179 s [18.179 s, 18.179 s]	3.203 s (21.4%)
iast_GLOBAL	17.877 s [17.877 s, 17.877 s]	2.901 s (19.4%)
profiling	14.576 s [14.576 s, 14.576 s]	-400.0 ms (-2.7%)
tracing	14.538 s [14.538 s, 14.538 s]	-438.0 ms (-2.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.948 s [14.948 s, 14.948 s]	-
appsec	14.723 s [14.723 s, 14.723 s]	-225.0 ms (-1.5%)
iast	18.393 s [18.393 s, 18.393 s]	3.445 s (23.0%)
iast_GLOBAL	18.054 s [18.054 s, 18.054 s]	3.106 s (20.8%)
profiling	14.57 s [14.57 s, 14.57 s]	-378.0 ms (-2.5%)
tracing	14.944 s [14.944 s, 14.944 s]	-4.0 ms (-0.0%)

amarziali · 2025-12-09T16:15:27Z

internal-api/src/main/java/datadog/trace/api/ProcessTags.java

+                            entry.getKey()
+                                + ":"
+                                + TraceUtils.normalizeTagValue(
+                                    entry.getValue().replace(':', '_'))));


ideally it can also be factorised somewhere to have it reusable but not a hard requirement.

yeah, I'm not sure it's something we're going to need somewhere else any time soon

amarziali

Thanks for the improvement

remove colons from process tags values

9f819c3

vandonr requested a review from a team as a code owner December 9, 2025 07:21

vandonr requested a review from amarziali December 9, 2025 07:21

vandonr temporarily deployed to ci-build December 9, 2025 07:21 — with GitHub Actions Inactive

vandonr added type: bug Bug report and fix comp: core Tracer core labels Dec 9, 2025

amarziali reviewed Dec 9, 2025

View reviewed changes

amarziali approved these changes Dec 9, 2025

View reviewed changes

vandonr merged commit 75bbf22 into master Dec 10, 2025
548 of 549 checks passed

vandonr deleted the vandonr/fix branch December 10, 2025 09:23

github-actions bot added this to the 1.57.0 milestone Dec 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove colons from process tags values#10109

remove colons from process tags values#10109
vandonr merged 1 commit intomasterfrom
vandonr/fix

vandonr commented Dec 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

pr-commenter bot commented Dec 9, 2025

Uh oh!

amarziali Dec 9, 2025

Uh oh!

vandonr Dec 10, 2025

Uh oh!

amarziali left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vandonr commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

pr-commenter bot commented Dec 9, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

amarziali Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

vandonr Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vandonr commented Dec 9, 2025 •

edited

Loading