Enable websocket instrumentation by default#10437
Merged
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 8 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086701
Total [baseline] (10.652 s) : 0, 10651866
Agent [candidate] (1.09 s) : 0, 1090058
Total [candidate] (10.732 s) : 0, 10731550
section appsec
Agent [baseline] (1.27 s) : 0, 1270442
Total [baseline] (10.922 s) : 0, 10921676
Agent [candidate] (1.269 s) : 0, 1269451
Total [candidate] (11.038 s) : 0, 11038468
section iast
Agent [baseline] (1.231 s) : 0, 1231347
Total [baseline] (11.138 s) : 0, 11137619
Agent [candidate] (1.238 s) : 0, 1238220
Total [candidate] (11.035 s) : 0, 11034701
section profiling
Agent [baseline] (1.211 s) : 0, 1210931
Total [baseline] (10.936 s) : 0, 10935666
Agent [candidate] (1.209 s) : 0, 1208742
Total [candidate] (10.942 s) : 0, 10941813
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (650.912 ms) : 0, 650912
BytebuddyAgent [candidate] (653.282 ms) : 0, 653282
AgentMeter [baseline] (28.722 ms) : 0, 28722
AgentMeter [candidate] (28.991 ms) : 0, 28991
GlobalTracer [baseline] (256.826 ms) : 0, 256826
GlobalTracer [candidate] (257.351 ms) : 0, 257351
AppSec [baseline] (32.857 ms) : 0, 32857
AppSec [candidate] (32.898 ms) : 0, 32898
Debugger [baseline] (66.919 ms) : 0, 66919
Debugger [candidate] (68.004 ms) : 0, 68004
Remote Config [baseline] (599.864 µs) : 0, 600
Remote Config [candidate] (608.708 µs) : 0, 609
Telemetry [baseline] (8.854 ms) : 0, 8854
Telemetry [candidate] (8.856 ms) : 0, 8856
Flare Poller [baseline] (4.501 ms) : 0, 4501
Flare Poller [candidate] (3.593 ms) : 0, 3593
section appsec
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (691.31 ms) : 0, 691310
BytebuddyAgent [candidate] (691.993 ms) : 0, 691993
AgentMeter [baseline] (12.035 ms) : 0, 12035
AgentMeter [candidate] (11.954 ms) : 0, 11954
GlobalTracer [baseline] (250.682 ms) : 0, 250682
GlobalTracer [candidate] (250.654 ms) : 0, 250654
IAST [baseline] (24.762 ms) : 0, 24762
IAST [candidate] (24.377 ms) : 0, 24377
AppSec [baseline] (173.488 ms) : 0, 173488
AppSec [candidate] (174.008 ms) : 0, 174008
Debugger [baseline] (67.746 ms) : 0, 67746
Debugger [candidate] (66.175 ms) : 0, 66175
Remote Config [baseline] (687.724 µs) : 0, 688
Remote Config [candidate] (708.617 µs) : 0, 709
Telemetry [baseline] (9.482 ms) : 0, 9482
Telemetry [candidate] (9.48 ms) : 0, 9480
Flare Poller [baseline] (3.642 ms) : 0, 3642
Flare Poller [candidate] (3.584 ms) : 0, 3584
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (794.338 ms) : 0, 794338
BytebuddyAgent [candidate] (800.623 ms) : 0, 800623
AgentMeter [baseline] (11.353 ms) : 0, 11353
AgentMeter [candidate] (11.543 ms) : 0, 11543
GlobalTracer [baseline] (249.447 ms) : 0, 249447
GlobalTracer [candidate] (249.082 ms) : 0, 249082
IAST [baseline] (26.879 ms) : 0, 26879
IAST [candidate] (27.039 ms) : 0, 27039
AppSec [baseline] (34.434 ms) : 0, 34434
AppSec [candidate] (33.773 ms) : 0, 33773
Debugger [baseline] (65.855 ms) : 0, 65855
Debugger [candidate] (67.102 ms) : 0, 67102
Remote Config [baseline] (554.574 µs) : 0, 555
Remote Config [candidate] (535.373 µs) : 0, 535
Telemetry [baseline] (8.459 ms) : 0, 8459
Telemetry [candidate] (8.437 ms) : 0, 8437
Flare Poller [baseline] (3.534 ms) : 0, 3534
Flare Poller [candidate] (3.395 ms) : 0, 3395
section profiling
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (704.409 ms) : 0, 704409
BytebuddyAgent [candidate] (704.425 ms) : 0, 704425
AgentMeter [baseline] (8.88 ms) : 0, 8880
AgentMeter [candidate] (8.8 ms) : 0, 8800
GlobalTracer [baseline] (216.809 ms) : 0, 216809
GlobalTracer [candidate] (216.009 ms) : 0, 216009
AppSec [baseline] (32.716 ms) : 0, 32716
AppSec [candidate] (32.208 ms) : 0, 32208
Debugger [baseline] (67.413 ms) : 0, 67413
Debugger [candidate] (66.654 ms) : 0, 66654
Remote Config [baseline] (621.615 µs) : 0, 622
Remote Config [candidate] (599.635 µs) : 0, 600
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.719 ms) : 0, 8719
Flare Poller [baseline] (4.167 ms) : 0, 4167
Flare Poller [candidate] (9.204 ms) : 0, 9204
ProfilingAgent [baseline] (95.873 ms) : 0, 95873
ProfilingAgent [candidate] (91.129 ms) : 0, 91129
Profiling [baseline] (96.443 ms) : 0, 96443
Profiling [candidate] (91.715 ms) : 0, 91715
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085604
Total [baseline] (8.691 s) : 0, 8690977
Agent [candidate] (1.093 s) : 0, 1093469
Total [candidate] (8.727 s) : 0, 8727450
section iast
Agent [baseline] (1.228 s) : 0, 1228339
Total [baseline] (9.32 s) : 0, 9320483
Agent [candidate] (1.228 s) : 0, 1228039
Total [candidate] (9.282 s) : 0, 9281995
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (650.791 ms) : 0, 650791
BytebuddyAgent [candidate] (656.001 ms) : 0, 656001
AgentMeter [baseline] (28.772 ms) : 0, 28772
AgentMeter [candidate] (29.196 ms) : 0, 29196
GlobalTracer [baseline] (256.95 ms) : 0, 256950
GlobalTracer [candidate] (258.491 ms) : 0, 258491
AppSec [baseline] (32.679 ms) : 0, 32679
AppSec [candidate] (33.041 ms) : 0, 33041
Debugger [baseline] (65.267 ms) : 0, 65267
Debugger [candidate] (66.167 ms) : 0, 66167
Remote Config [baseline] (600.485 µs) : 0, 600
Remote Config [candidate] (611.858 µs) : 0, 612
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.924 ms) : 0, 8924
Flare Poller [baseline] (5.206 ms) : 0, 5206
Flare Poller [candidate] (4.359 ms) : 0, 4359
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (793.495 ms) : 0, 793495
BytebuddyAgent [candidate] (794.043 ms) : 0, 794043
AgentMeter [baseline] (11.276 ms) : 0, 11276
AgentMeter [candidate] (11.233 ms) : 0, 11233
GlobalTracer [baseline] (248.534 ms) : 0, 248534
GlobalTracer [candidate] (247.745 ms) : 0, 247745
AppSec [baseline] (33.377 ms) : 0, 33377
AppSec [candidate] (34.111 ms) : 0, 34111
Debugger [baseline] (65.727 ms) : 0, 65727
Debugger [candidate] (65.353 ms) : 0, 65353
Remote Config [baseline] (533.387 µs) : 0, 533
Remote Config [candidate] (526.497 µs) : 0, 526
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.352 ms) : 0, 8352
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.398 ms) : 0, 3398
IAST [baseline] (26.938 ms) : 0, 26938
IAST [candidate] (26.859 ms) : 0, 26859
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section baseline
no_agent (18.209 ms) : 18018, 18399
. : milestone, 18209,
appsec (20.049 ms) : 19843, 20254
. : milestone, 20049,
code_origins (17.487 ms) : 17312, 17662
. : milestone, 17487,
iast (17.58 ms) : 17406, 17755
. : milestone, 17580,
profiling (18.591 ms) : 18405, 18776
. : milestone, 18591,
tracing (17.437 ms) : 17265, 17610
. : milestone, 17437,
section candidate
no_agent (18.085 ms) : 17902, 18268
. : milestone, 18085,
appsec (18.771 ms) : 18584, 18958
. : milestone, 18771,
code_origins (17.463 ms) : 17291, 17634
. : milestone, 17463,
iast (17.655 ms) : 17484, 17826
. : milestone, 17655,
profiling (18.631 ms) : 18444, 18818
. : milestone, 18631,
tracing (17.562 ms) : 17388, 17737
. : milestone, 17562,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.226 ms) : 3184, 3269
. : milestone, 3226,
iast_FULL (5.644 ms) : 5588, 5699
. : milestone, 5644,
iast_GLOBAL (3.52 ms) : 3469, 3571
. : milestone, 3520,
profiling (1.975 ms) : 1959, 1992
. : milestone, 1975,
tracing (1.765 ms) : 1750, 1779
. : milestone, 1765,
section candidate
no_agent (1.183 ms) : 1172, 1195
. : milestone, 1183,
iast (3.153 ms) : 3117, 3189
. : milestone, 3153,
iast_FULL (5.678 ms) : 5622, 5735
. : milestone, 5678,
iast_GLOBAL (3.538 ms) : 3483, 3594
. : milestone, 3538,
profiling (1.921 ms) : 1905, 1936
. : milestone, 1921,
tracing (1.801 ms) : 1786, 1816
. : milestone, 1801,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section baseline
no_agent (15.713 s) : 15713000, 15713000
. : milestone, 15713000,
appsec (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
profiling (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
tracing (14.631 s) : 14631000, 14631000
. : milestone, 14631000,
section candidate
no_agent (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.259 s) : 18259000, 18259000
. : milestone, 18259000,
iast_GLOBAL (17.789 s) : 17789000, 17789000
. : milestone, 17789000,
profiling (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
tracing (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.662 ms) : 3446, 3878
. : milestone, 3662,
iast (2.205 ms) : 2140, 2270
. : milestone, 2205,
iast_GLOBAL (2.255 ms) : 2190, 2321
. : milestone, 2255,
profiling (2.06 ms) : 2007, 2112
. : milestone, 2060,
tracing (2.024 ms) : 1973, 2075
. : milestone, 2024,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.7 ms) : 3481, 3919
. : milestone, 3700,
iast (2.233 ms) : 2164, 2301
. : milestone, 2233,
iast_GLOBAL (2.279 ms) : 2210, 2347
. : milestone, 2279,
profiling (2.078 ms) : 2023, 2134
. : milestone, 2078,
tracing (2.066 ms) : 2012, 2121
. : milestone, 2066,
|
amarziali
reviewed
Jan 24, 2026
| "aliases": ["DD_WEBSOCKET_ANALYTICS_SAMPLE_RATE"] | ||
| } | ||
| ], | ||
| "DD_TRACE_WEBSOCKET_ENABLED": [ |
Contributor
There was a problem hiding this comment.
this looks an alias so should be also updated accordingly
amarziali
approved these changes
Jan 24, 2026
Contributor
amarziali
left a comment
There was a problem hiding this comment.
left one minor comment. thanks for having opened it
7c3b739 to
adc63a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enables websocket instrumentation by default
Motivation
Users want to enjoy websocket instrumentation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]