Skip to content

Enable websocket instrumentation by default#10437

Merged
tlhunter merged 4 commits intomasterfrom
tlhunter/enable-websockets-default
Jan 26, 2026
Merged

Enable websocket instrumentation by default#10437
tlhunter merged 4 commits intomasterfrom
tlhunter/enable-websockets-default

Conversation

@tlhunter
Copy link
Member

What Does This Do

Enables websocket instrumentation by default

Motivation

Users want to enjoy websocket instrumentation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@tlhunter tlhunter added the inst: websocket WebSocket Instrumentation label Jan 23, 2026
@tlhunter tlhunter requested a review from a team as a code owner January 23, 2026 17:36
@tlhunter tlhunter requested a review from ygree January 23, 2026 17:36
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@tlhunter tlhunter added comp: library injection Library Injection type: enhancement Enhancements and improvements labels Jan 23, 2026
@tlhunter tlhunter requested a review from a team as a code owner January 23, 2026 17:44
@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/enable-websockets-default
git_commit_date 1769446658 1769449096
git_commit_sha 569b4a9 adc63a0
release_version 1.59.0-SNAPSHOT~569b4a96e3 1.59.0-SNAPSHOT~adc63a013f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769450885 1769450885
ci_job_id 1377625647 1377625647
ci_pipeline_id 92869857 92869857
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-o35kx678 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-o35kx678 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 8 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent better
[-6.610ms; -2.877ms] or [-6.895%; -3.001%]
91.129ms 95.873ms
scenario:startup:petclinic:profiling:Profiling better
[-6.594ms; -2.863ms] or [-6.837%; -2.969%]
91.715ms 96.443ms
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086701
Total [baseline] (10.652 s) : 0, 10651866
Agent [candidate] (1.09 s) : 0, 1090058
Total [candidate] (10.732 s) : 0, 10731550
section appsec
Agent [baseline] (1.27 s) : 0, 1270442
Total [baseline] (10.922 s) : 0, 10921676
Agent [candidate] (1.269 s) : 0, 1269451
Total [candidate] (11.038 s) : 0, 11038468
section iast
Agent [baseline] (1.231 s) : 0, 1231347
Total [baseline] (11.138 s) : 0, 11137619
Agent [candidate] (1.238 s) : 0, 1238220
Total [candidate] (11.035 s) : 0, 11034701
section profiling
Agent [baseline] (1.211 s) : 0, 1210931
Total [baseline] (10.936 s) : 0, 10935666
Agent [candidate] (1.209 s) : 0, 1208742
Total [candidate] (10.942 s) : 0, 10941813
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent appsec 1.27 s 183.741 ms (16.9%)
Agent iast 1.231 s 144.646 ms (13.3%)
Agent profiling 1.211 s 124.23 ms (11.4%)
Total tracing 10.652 s -
Total appsec 10.922 s 269.81 ms (2.5%)
Total iast 11.138 s 485.753 ms (4.6%)
Total profiling 10.936 s 283.8 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.269 s 179.393 ms (16.5%)
Agent iast 1.238 s 148.162 ms (13.6%)
Agent profiling 1.209 s 118.684 ms (10.9%)
Total tracing 10.732 s -
Total appsec 11.038 s 306.918 ms (2.9%)
Total iast 11.035 s 303.151 ms (2.8%)
Total profiling 10.942 s 210.263 ms (2.0%)
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (650.912 ms) : 0, 650912
BytebuddyAgent [candidate] (653.282 ms) : 0, 653282
AgentMeter [baseline] (28.722 ms) : 0, 28722
AgentMeter [candidate] (28.991 ms) : 0, 28991
GlobalTracer [baseline] (256.826 ms) : 0, 256826
GlobalTracer [candidate] (257.351 ms) : 0, 257351
AppSec [baseline] (32.857 ms) : 0, 32857
AppSec [candidate] (32.898 ms) : 0, 32898
Debugger [baseline] (66.919 ms) : 0, 66919
Debugger [candidate] (68.004 ms) : 0, 68004
Remote Config [baseline] (599.864 µs) : 0, 600
Remote Config [candidate] (608.708 µs) : 0, 609
Telemetry [baseline] (8.854 ms) : 0, 8854
Telemetry [candidate] (8.856 ms) : 0, 8856
Flare Poller [baseline] (4.501 ms) : 0, 4501
Flare Poller [candidate] (3.593 ms) : 0, 3593
section appsec
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (691.31 ms) : 0, 691310
BytebuddyAgent [candidate] (691.993 ms) : 0, 691993
AgentMeter [baseline] (12.035 ms) : 0, 12035
AgentMeter [candidate] (11.954 ms) : 0, 11954
GlobalTracer [baseline] (250.682 ms) : 0, 250682
GlobalTracer [candidate] (250.654 ms) : 0, 250654
IAST [baseline] (24.762 ms) : 0, 24762
IAST [candidate] (24.377 ms) : 0, 24377
AppSec [baseline] (173.488 ms) : 0, 173488
AppSec [candidate] (174.008 ms) : 0, 174008
Debugger [baseline] (67.746 ms) : 0, 67746
Debugger [candidate] (66.175 ms) : 0, 66175
Remote Config [baseline] (687.724 µs) : 0, 688
Remote Config [candidate] (708.617 µs) : 0, 709
Telemetry [baseline] (9.482 ms) : 0, 9482
Telemetry [candidate] (9.48 ms) : 0, 9480
Flare Poller [baseline] (3.642 ms) : 0, 3642
Flare Poller [candidate] (3.584 ms) : 0, 3584
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (794.338 ms) : 0, 794338
BytebuddyAgent [candidate] (800.623 ms) : 0, 800623
AgentMeter [baseline] (11.353 ms) : 0, 11353
AgentMeter [candidate] (11.543 ms) : 0, 11543
GlobalTracer [baseline] (249.447 ms) : 0, 249447
GlobalTracer [candidate] (249.082 ms) : 0, 249082
IAST [baseline] (26.879 ms) : 0, 26879
IAST [candidate] (27.039 ms) : 0, 27039
AppSec [baseline] (34.434 ms) : 0, 34434
AppSec [candidate] (33.773 ms) : 0, 33773
Debugger [baseline] (65.855 ms) : 0, 65855
Debugger [candidate] (67.102 ms) : 0, 67102
Remote Config [baseline] (554.574 µs) : 0, 555
Remote Config [candidate] (535.373 µs) : 0, 535
Telemetry [baseline] (8.459 ms) : 0, 8459
Telemetry [candidate] (8.437 ms) : 0, 8437
Flare Poller [baseline] (3.534 ms) : 0, 3534
Flare Poller [candidate] (3.395 ms) : 0, 3395
section profiling
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (704.409 ms) : 0, 704409
BytebuddyAgent [candidate] (704.425 ms) : 0, 704425
AgentMeter [baseline] (8.88 ms) : 0, 8880
AgentMeter [candidate] (8.8 ms) : 0, 8800
GlobalTracer [baseline] (216.809 ms) : 0, 216809
GlobalTracer [candidate] (216.009 ms) : 0, 216009
AppSec [baseline] (32.716 ms) : 0, 32716
AppSec [candidate] (32.208 ms) : 0, 32208
Debugger [baseline] (67.413 ms) : 0, 67413
Debugger [candidate] (66.654 ms) : 0, 66654
Remote Config [baseline] (621.615 µs) : 0, 622
Remote Config [candidate] (599.635 µs) : 0, 600
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.719 ms) : 0, 8719
Flare Poller [baseline] (4.167 ms) : 0, 4167
Flare Poller [candidate] (9.204 ms) : 0, 9204
ProfilingAgent [baseline] (95.873 ms) : 0, 95873
ProfilingAgent [candidate] (91.129 ms) : 0, 91129
Profiling [baseline] (96.443 ms) : 0, 96443
Profiling [candidate] (91.715 ms) : 0, 91715
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085604
Total [baseline] (8.691 s) : 0, 8690977
Agent [candidate] (1.093 s) : 0, 1093469
Total [candidate] (8.727 s) : 0, 8727450
section iast
Agent [baseline] (1.228 s) : 0, 1228339
Total [baseline] (9.32 s) : 0, 9320483
Agent [candidate] (1.228 s) : 0, 1228039
Total [candidate] (9.282 s) : 0, 9281995
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.228 s 142.735 ms (13.1%)
Total tracing 8.691 s -
Total iast 9.32 s 629.507 ms (7.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent iast 1.228 s 134.57 ms (12.3%)
Total tracing 8.727 s -
Total iast 9.282 s 554.545 ms (6.4%)
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (650.791 ms) : 0, 650791
BytebuddyAgent [candidate] (656.001 ms) : 0, 656001
AgentMeter [baseline] (28.772 ms) : 0, 28772
AgentMeter [candidate] (29.196 ms) : 0, 29196
GlobalTracer [baseline] (256.95 ms) : 0, 256950
GlobalTracer [candidate] (258.491 ms) : 0, 258491
AppSec [baseline] (32.679 ms) : 0, 32679
AppSec [candidate] (33.041 ms) : 0, 33041
Debugger [baseline] (65.267 ms) : 0, 65267
Debugger [candidate] (66.167 ms) : 0, 66167
Remote Config [baseline] (600.485 µs) : 0, 600
Remote Config [candidate] (611.858 µs) : 0, 612
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.924 ms) : 0, 8924
Flare Poller [baseline] (5.206 ms) : 0, 5206
Flare Poller [candidate] (4.359 ms) : 0, 4359
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (793.495 ms) : 0, 793495
BytebuddyAgent [candidate] (794.043 ms) : 0, 794043
AgentMeter [baseline] (11.276 ms) : 0, 11276
AgentMeter [candidate] (11.233 ms) : 0, 11233
GlobalTracer [baseline] (248.534 ms) : 0, 248534
GlobalTracer [candidate] (247.745 ms) : 0, 247745
AppSec [baseline] (33.377 ms) : 0, 33377
AppSec [candidate] (34.111 ms) : 0, 34111
Debugger [baseline] (65.727 ms) : 0, 65727
Debugger [candidate] (65.353 ms) : 0, 65353
Remote Config [baseline] (533.387 µs) : 0, 533
Remote Config [candidate] (526.497 µs) : 0, 526
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.352 ms) : 0, 8352
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.398 ms) : 0, 3398
IAST [baseline] (26.938 ms) : 0, 26938
IAST [candidate] (26.859 ms) : 0, 26859
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/enable-websockets-default
git_commit_date 1769446658 1769449096
git_commit_sha 569b4a9 adc63a0
release_version 1.59.0-SNAPSHOT~569b4a96e3 1.59.0-SNAPSHOT~adc63a013f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1769451528 1769451528
ci_job_id 1377625649 1377625649
ci_pipeline_id 92869857 92869857
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-5k83frx4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-5k83frx4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:appsec:high_load better
[-2.005ms; -0.918ms] or [-10.102%; -4.628%]
better
[-2.761ms; -1.091ms] or [-8.719%; -3.445%]
unstable
[-10.682op/s; +42.182op/s] or [-4.587%; +18.113%]
18.382ms 29.737ms 248.625op/s 19.843ms 31.662ms 232.875op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.209 ms) : 18018, 18399
.   : milestone, 18209,
appsec (20.049 ms) : 19843, 20254
.   : milestone, 20049,
code_origins (17.487 ms) : 17312, 17662
.   : milestone, 17487,
iast (17.58 ms) : 17406, 17755
.   : milestone, 17580,
profiling (18.591 ms) : 18405, 18776
.   : milestone, 18591,
tracing (17.437 ms) : 17265, 17610
.   : milestone, 17437,
section candidate
no_agent (18.085 ms) : 17902, 18268
.   : milestone, 18085,
appsec (18.771 ms) : 18584, 18958
.   : milestone, 18771,
code_origins (17.463 ms) : 17291, 17634
.   : milestone, 17463,
iast (17.655 ms) : 17484, 17826
.   : milestone, 17655,
profiling (18.631 ms) : 18444, 18818
.   : milestone, 18631,
tracing (17.562 ms) : 17388, 17737
.   : milestone, 17562,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.209 ms [18.018 ms, 18.399 ms] -
appsec 20.049 ms [19.843 ms, 20.254 ms] 1.84 ms (10.1%)
code_origins 17.487 ms [17.312 ms, 17.662 ms] -721.185 µs (-4.0%)
iast 17.58 ms [17.406 ms, 17.755 ms] -628.082 µs (-3.4%)
profiling 18.591 ms [18.405 ms, 18.776 ms] 381.965 µs (2.1%)
tracing 17.437 ms [17.265 ms, 17.61 ms] -771.13 µs (-4.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.085 ms [17.902 ms, 18.268 ms] -
appsec 18.771 ms [18.584 ms, 18.958 ms] 685.911 µs (3.8%)
code_origins 17.463 ms [17.291 ms, 17.634 ms] -622.421 µs (-3.4%)
iast 17.655 ms [17.484 ms, 17.826 ms] -429.879 µs (-2.4%)
profiling 18.631 ms [18.444 ms, 18.818 ms] 546.048 µs (3.0%)
tracing 17.562 ms [17.388 ms, 17.737 ms] -522.644 µs (-2.9%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1209
.   : milestone, 1197,
iast (3.226 ms) : 3184, 3269
.   : milestone, 3226,
iast_FULL (5.644 ms) : 5588, 5699
.   : milestone, 5644,
iast_GLOBAL (3.52 ms) : 3469, 3571
.   : milestone, 3520,
profiling (1.975 ms) : 1959, 1992
.   : milestone, 1975,
tracing (1.765 ms) : 1750, 1779
.   : milestone, 1765,
section candidate
no_agent (1.183 ms) : 1172, 1195
.   : milestone, 1183,
iast (3.153 ms) : 3117, 3189
.   : milestone, 3153,
iast_FULL (5.678 ms) : 5622, 5735
.   : milestone, 5678,
iast_GLOBAL (3.538 ms) : 3483, 3594
.   : milestone, 3538,
profiling (1.921 ms) : 1905, 1936
.   : milestone, 1921,
tracing (1.801 ms) : 1786, 1816
.   : milestone, 1801,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.197 ms [1.185 ms, 1.209 ms] -
iast 3.226 ms [3.184 ms, 3.269 ms] 2.029 ms (169.6%)
iast_FULL 5.644 ms [5.588 ms, 5.699 ms] 4.447 ms (371.6%)
iast_GLOBAL 3.52 ms [3.469 ms, 3.571 ms] 2.323 ms (194.1%)
profiling 1.975 ms [1.959 ms, 1.992 ms] 778.623 µs (65.1%)
tracing 1.765 ms [1.75 ms, 1.779 ms] 567.904 µs (47.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.183 ms [1.172 ms, 1.195 ms] -
iast 3.153 ms [3.117 ms, 3.189 ms] 1.969 ms (166.4%)
iast_FULL 5.678 ms [5.622 ms, 5.735 ms] 4.495 ms (379.8%)
iast_GLOBAL 3.538 ms [3.483 ms, 3.594 ms] 2.355 ms (199.0%)
profiling 1.921 ms [1.905 ms, 1.936 ms] 737.544 µs (62.3%)
tracing 1.801 ms [1.786 ms, 1.816 ms] 617.687 µs (52.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/enable-websockets-default
git_commit_date 1769446658 1769449096
git_commit_sha 569b4a9 adc63a0
release_version 1.59.0-SNAPSHOT~569b4a96e3 1.59.0-SNAPSHOT~adc63a013f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1769451118 1769451118
ci_job_id 1377625652 1377625652
ci_pipeline_id 92869857 92869857
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-g0p3mbxt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-g0p3mbxt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.713 s) : 15713000, 15713000
.   : milestone, 15713000,
appsec (14.629 s) : 14629000, 14629000
.   : milestone, 14629000,
iast (18.67 s) : 18670000, 18670000
.   : milestone, 18670000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
.   : milestone, 17949000,
profiling (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
tracing (14.631 s) : 14631000, 14631000
.   : milestone, 14631000,
section candidate
no_agent (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
appsec (14.818 s) : 14818000, 14818000
.   : milestone, 14818000,
iast (18.259 s) : 18259000, 18259000
.   : milestone, 18259000,
iast_GLOBAL (17.789 s) : 17789000, 17789000
.   : milestone, 17789000,
profiling (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
tracing (14.74 s) : 14740000, 14740000
.   : milestone, 14740000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.713 s [15.713 s, 15.713 s] -
appsec 14.629 s [14.629 s, 14.629 s] -1.084 s (-6.9%)
iast 18.67 s [18.67 s, 18.67 s] 2.957 s (18.8%)
iast_GLOBAL 17.949 s [17.949 s, 17.949 s] 2.236 s (14.2%)
profiling 15.031 s [15.031 s, 15.031 s] -682.0 ms (-4.3%)
tracing 14.631 s [14.631 s, 14.631 s] -1.082 s (-6.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.028 s [15.028 s, 15.028 s] -
appsec 14.818 s [14.818 s, 14.818 s] -210.0 ms (-1.4%)
iast 18.259 s [18.259 s, 18.259 s] 3.231 s (21.5%)
iast_GLOBAL 17.789 s [17.789 s, 17.789 s] 2.761 s (18.4%)
profiling 15.154 s [15.154 s, 15.154 s] 126.0 ms (0.8%)
tracing 14.74 s [14.74 s, 14.74 s] -288.0 ms (-1.9%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~adc63a013f, baseline=1.59.0-SNAPSHOT~569b4a96e3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.662 ms) : 3446, 3878
.   : milestone, 3662,
iast (2.205 ms) : 2140, 2270
.   : milestone, 2205,
iast_GLOBAL (2.255 ms) : 2190, 2321
.   : milestone, 2255,
profiling (2.06 ms) : 2007, 2112
.   : milestone, 2060,
tracing (2.024 ms) : 1973, 2075
.   : milestone, 2024,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (3.7 ms) : 3481, 3919
.   : milestone, 3700,
iast (2.233 ms) : 2164, 2301
.   : milestone, 2233,
iast_GLOBAL (2.279 ms) : 2210, 2347
.   : milestone, 2279,
profiling (2.078 ms) : 2023, 2134
.   : milestone, 2078,
tracing (2.066 ms) : 2012, 2121
.   : milestone, 2066,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 3.662 ms [3.446 ms, 3.878 ms] 2.19 ms (148.8%)
iast 2.205 ms [2.14 ms, 2.27 ms] 733.211 µs (49.8%)
iast_GLOBAL 2.255 ms [2.19 ms, 2.321 ms] 783.482 µs (53.2%)
profiling 2.06 ms [2.007 ms, 2.112 ms] 587.767 µs (39.9%)
tracing 2.024 ms [1.973 ms, 2.075 ms] 552.221 µs (37.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 3.7 ms [3.481 ms, 3.919 ms] 2.232 ms (152.0%)
iast 2.233 ms [2.164 ms, 2.301 ms] 764.135 µs (52.0%)
iast_GLOBAL 2.279 ms [2.21 ms, 2.347 ms] 810.061 µs (55.2%)
profiling 2.078 ms [2.023 ms, 2.134 ms] 609.989 µs (41.5%)
tracing 2.066 ms [2.012 ms, 2.121 ms] 597.668 µs (40.7%)

Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

"aliases": ["DD_WEBSOCKET_ANALYTICS_SAMPLE_RATE"]
}
],
"DD_TRACE_WEBSOCKET_ENABLED": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks an alias so should be also updated accordingly

Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one minor comment. thanks for having opened it

@tlhunter tlhunter requested a review from a team as a code owner January 26, 2026 17:07
@tlhunter tlhunter requested review from dougqh and removed request for a team January 26, 2026 17:07
@tlhunter tlhunter force-pushed the tlhunter/enable-websockets-default branch from 7c3b739 to adc63a0 Compare January 26, 2026 17:38
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tlhunter tlhunter merged commit e9c77bf into master Jan 26, 2026
548 checks passed
@tlhunter tlhunter deleted the tlhunter/enable-websockets-default branch January 26, 2026 18:39
@github-actions github-actions bot added this to the 1.59.0 milestone Jan 26, 2026
@PerfectSlayer PerfectSlayer changed the title feat(websockets): enable websocket instrumentation by default Enable websocket instrumentation by default Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: library injection Library Injection inst: websocket WebSocket Instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants