Avoid throwing exception for invalid modifiers#10458
Conversation
OpenJ9 is behaving weirdly for access modifiers
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (314.851 µs) : 285, 345
. : milestone, 315,
basic (273.292 µs) : 267, 280
. : milestone, 273,
loop (8.956 ms) : 8951, 8960
. : milestone, 8956,
section candidate
noprobe (320.925 µs) : 284, 358
. : milestone, 321,
basic (277.153 µs) : 271, 283
. : milestone, 277,
loop (8.964 ms) : 8959, 8968
. : milestone, 8964,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 8 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063207
Total [baseline] (10.96 s) : 0, 10960410
Agent [candidate] (1.058 s) : 0, 1057593
Total [candidate] (10.925 s) : 0, 10924707
section appsec
Agent [baseline] (1.231 s) : 0, 1230724
Total [baseline] (10.97 s) : 0, 10969501
Agent [candidate] (1.228 s) : 0, 1228390
Total [candidate] (10.881 s) : 0, 10880744
section iast
Agent [baseline] (1.224 s) : 0, 1224430
Total [baseline] (11.089 s) : 0, 11088949
Agent [candidate] (1.224 s) : 0, 1223571
Total [candidate] (11.17 s) : 0, 11170229
section profiling
Agent [baseline] (1.182 s) : 0, 1182479
Total [baseline] (10.974 s) : 0, 10974462
Agent [candidate] (1.185 s) : 0, 1185347
Total [candidate] (10.949 s) : 0, 10948568
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (625.333 ms) : 0, 625333
BytebuddyAgent [candidate] (622.285 ms) : 0, 622285
AgentMeter [baseline] (29.031 ms) : 0, 29031
AgentMeter [candidate] (28.767 ms) : 0, 28767
GlobalTracer [baseline] (258.845 ms) : 0, 258845
GlobalTracer [candidate] (257.154 ms) : 0, 257154
AppSec [baseline] (33.241 ms) : 0, 33241
AppSec [candidate] (32.978 ms) : 0, 32978
Debugger [baseline] (60.964 ms) : 0, 60964
Debugger [candidate] (62.64 ms) : 0, 62640
Remote Config [baseline] (637.77 µs) : 0, 638
Remote Config [candidate] (618.038 µs) : 0, 618
Telemetry [baseline] (11.678 ms) : 0, 11678
Telemetry [candidate] (10.623 ms) : 0, 10623
Flare Poller [baseline] (6.842 ms) : 0, 6842
Flare Poller [candidate] (6.003 ms) : 0, 6003
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (652.142 ms) : 0, 652142
BytebuddyAgent [candidate] (650.002 ms) : 0, 650002
AgentMeter [baseline] (11.771 ms) : 0, 11771
AgentMeter [candidate] (11.739 ms) : 0, 11739
GlobalTracer [baseline] (256.99 ms) : 0, 256990
GlobalTracer [candidate] (256.953 ms) : 0, 256953
AppSec [baseline] (167.141 ms) : 0, 167141
AppSec [candidate] (166.776 ms) : 0, 166776
Debugger [baseline] (67.426 ms) : 0, 67426
Debugger [candidate] (67.722 ms) : 0, 67722
Remote Config [baseline] (673.197 µs) : 0, 673
Remote Config [candidate] (667.41 µs) : 0, 667
Telemetry [baseline] (9.184 ms) : 0, 9184
Telemetry [candidate] (9.295 ms) : 0, 9295
Flare Poller [baseline] (3.627 ms) : 0, 3627
Flare Poller [candidate] (3.614 ms) : 0, 3614
IAST [baseline] (25.346 ms) : 0, 25346
IAST [candidate] (25.25 ms) : 0, 25250
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (789.297 ms) : 0, 789297
BytebuddyAgent [candidate] (788.364 ms) : 0, 788364
AgentMeter [baseline] (11.146 ms) : 0, 11146
AgentMeter [candidate] (11.164 ms) : 0, 11164
GlobalTracer [baseline] (247.684 ms) : 0, 247684
GlobalTracer [candidate] (247.692 ms) : 0, 247692
AppSec [baseline] (33.897 ms) : 0, 33897
AppSec [candidate] (33.699 ms) : 0, 33699
Debugger [baseline] (66.644 ms) : 0, 66644
Debugger [candidate] (66.845 ms) : 0, 66845
Remote Config [baseline] (544.868 µs) : 0, 545
Remote Config [candidate] (551.613 µs) : 0, 552
Telemetry [baseline] (8.504 ms) : 0, 8504
Telemetry [candidate] (8.51 ms) : 0, 8510
Flare Poller [baseline] (3.463 ms) : 0, 3463
Flare Poller [candidate] (3.412 ms) : 0, 3412
IAST [baseline] (26.785 ms) : 0, 26785
IAST [candidate] (26.899 ms) : 0, 26899
section profiling
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (675.081 ms) : 0, 675081
BytebuddyAgent [candidate] (676.236 ms) : 0, 676236
AgentMeter [baseline] (8.594 ms) : 0, 8594
AgentMeter [candidate] (8.6 ms) : 0, 8600
GlobalTracer [baseline] (216.538 ms) : 0, 216538
GlobalTracer [candidate] (216.779 ms) : 0, 216779
AppSec [baseline] (32.25 ms) : 0, 32250
AppSec [candidate] (32.501 ms) : 0, 32501
Debugger [baseline] (67.881 ms) : 0, 67881
Debugger [candidate] (67.805 ms) : 0, 67805
Remote Config [baseline] (586.292 µs) : 0, 586
Remote Config [candidate] (595.897 µs) : 0, 596
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.731 ms) : 0, 8731
Flare Poller [baseline] (3.75 ms) : 0, 3750
Flare Poller [candidate] (3.767 ms) : 0, 3767
ProfilingAgent [baseline] (98.314 ms) : 0, 98314
ProfilingAgent [candidate] (99.268 ms) : 0, 99268
Profiling [baseline] (98.907 ms) : 0, 98907
Profiling [candidate] (99.836 ms) : 0, 99836
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064056
Total [baseline] (8.69 s) : 0, 8689569
Agent [candidate] (1.056 s) : 0, 1056227
Total [candidate] (8.691 s) : 0, 8691464
section iast
Agent [baseline] (1.227 s) : 0, 1226959
Total [baseline] (9.356 s) : 0, 9356090
Agent [candidate] (1.223 s) : 0, 1223355
Total [candidate] (9.368 s) : 0, 9367947
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (627.317 ms) : 0, 627317
BytebuddyAgent [candidate] (622.24 ms) : 0, 622240
AgentMeter [baseline] (28.969 ms) : 0, 28969
AgentMeter [candidate] (28.639 ms) : 0, 28639
GlobalTracer [baseline] (258.46 ms) : 0, 258460
GlobalTracer [candidate] (257.142 ms) : 0, 257142
AppSec [baseline] (33.213 ms) : 0, 33213
AppSec [candidate] (32.764 ms) : 0, 32764
Debugger [baseline] (63.507 ms) : 0, 63507
Debugger [candidate] (59.414 ms) : 0, 59414
Remote Config [baseline] (622.453 µs) : 0, 622
Remote Config [candidate] (618.585 µs) : 0, 619
Telemetry [baseline] (9.846 ms) : 0, 9846
Telemetry [candidate] (9.82 ms) : 0, 9820
Flare Poller [baseline] (5.446 ms) : 0, 5446
Flare Poller [candidate] (9.035 ms) : 0, 9035
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.167 ms) : 0, 1167
BytebuddyAgent [baseline] (791.243 ms) : 0, 791243
BytebuddyAgent [candidate] (789.803 ms) : 0, 789803
AgentMeter [baseline] (11.15 ms) : 0, 11150
AgentMeter [candidate] (11.086 ms) : 0, 11086
GlobalTracer [baseline] (248.421 ms) : 0, 248421
GlobalTracer [candidate] (247.497 ms) : 0, 247497
AppSec [baseline] (32.043 ms) : 0, 32043
AppSec [candidate] (31.787 ms) : 0, 31787
Debugger [baseline] (68.015 ms) : 0, 68015
Debugger [candidate] (67.219 ms) : 0, 67219
Remote Config [baseline] (540.78 µs) : 0, 541
Remote Config [candidate] (540.62 µs) : 0, 541
Telemetry [baseline] (8.515 ms) : 0, 8515
Telemetry [candidate] (8.639 ms) : 0, 8639
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.511 ms) : 0, 3511
IAST [baseline] (26.939 ms) : 0, 26939
IAST [candidate] (26.8 ms) : 0, 26800
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1217
. : milestone, 1206,
iast (3.256 ms) : 3211, 3300
. : milestone, 3256,
iast_FULL (5.73 ms) : 5673, 5788
. : milestone, 5730,
iast_GLOBAL (3.604 ms) : 3545, 3664
. : milestone, 3604,
profiling (1.994 ms) : 1977, 2010
. : milestone, 1994,
tracing (1.853 ms) : 1837, 1868
. : milestone, 1853,
section candidate
no_agent (1.178 ms) : 1166, 1189
. : milestone, 1178,
iast (3.314 ms) : 3268, 3360
. : milestone, 3314,
iast_FULL (5.9 ms) : 5840, 5960
. : milestone, 5900,
iast_GLOBAL (3.67 ms) : 3618, 3723
. : milestone, 3670,
profiling (2.058 ms) : 2040, 2076
. : milestone, 2058,
tracing (1.802 ms) : 1787, 1816
. : milestone, 1802,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section baseline
no_agent (19.154 ms) : 18960, 19348
. : milestone, 19154,
appsec (18.686 ms) : 18495, 18877
. : milestone, 18686,
code_origins (18.238 ms) : 18060, 18416
. : milestone, 18238,
iast (17.503 ms) : 17330, 17677
. : milestone, 17503,
profiling (18.741 ms) : 18550, 18932
. : milestone, 18741,
tracing (17.582 ms) : 17407, 17757
. : milestone, 17582,
section candidate
no_agent (16.997 ms) : 16827, 17166
. : milestone, 16997,
appsec (18.439 ms) : 18248, 18629
. : milestone, 18439,
code_origins (17.628 ms) : 17452, 17804
. : milestone, 17628,
iast (17.683 ms) : 17507, 17860
. : milestone, 17683,
profiling (18.317 ms) : 18136, 18499
. : milestone, 18317,
tracing (17.917 ms) : 17743, 18092
. : milestone, 17917,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section baseline
no_agent (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (17.887 s) : 17887000, 17887000
. : milestone, 17887000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
tracing (14.705 s) : 14705000, 14705000
. : milestone, 14705000,
section candidate
no_agent (15.441 s) : 15441000, 15441000
. : milestone, 15441000,
appsec (14.643 s) : 14643000, 14643000
. : milestone, 14643000,
iast (18.502 s) : 18502000, 18502000
. : milestone, 18502000,
iast_GLOBAL (18.145 s) : 18145000, 18145000
. : milestone, 18145000,
profiling (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
tracing (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0c2d2cc5ac, baseline=1.59.0-SNAPSHOT~02d5dc0038
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.489 ms) : 2434, 2544
. : milestone, 2489,
iast (2.244 ms) : 2175, 2313
. : milestone, 2244,
iast_GLOBAL (2.292 ms) : 2222, 2361
. : milestone, 2292,
profiling (2.074 ms) : 2019, 2129
. : milestone, 2074,
tracing (2.051 ms) : 1998, 2105
. : milestone, 2051,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.691 ms) : 3473, 3909
. : milestone, 3691,
iast (2.246 ms) : 2176, 2315
. : milestone, 2246,
iast_GLOBAL (2.3 ms) : 2229, 2370
. : milestone, 2300,
profiling (2.112 ms) : 2055, 2169
. : milestone, 2112,
tracing (2.051 ms) : 1998, 2104
. : milestone, 2051,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
You might want to run manually the pipeline with all the JDKs to test with J9 if you haven't already 😉
not enough. could not reproduced the issue locally with unit tests. only with a petclinic app |
What Does This Do
OpenJ9 is behaving weirdly for access modifiers
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5053