Conversation
When SymDB explicitly disabled and Dynamic Instrumentation is enabled honor correctly the disablemennt Same for Code Origin
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
| return INSTANCE; | ||
| } | ||
|
|
||
| public static boolean isExplicitlyDisabled(String booleanKey) { |
There was a problem hiding this comment.
This code in Agent.java can also be replaced with this new method: https://github.com/DataDog/dd-trace-java/blob/v1.58.2/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java#L1436
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060076
Total [baseline] (8.783 s) : 0, 8783406
Agent [candidate] (1.077 s) : 0, 1077449
Total [candidate] (8.802 s) : 0, 8802082
section iast
Agent [baseline] (1.23 s) : 0, 1230275
Total [baseline] (9.38 s) : 0, 9380436
Agent [candidate] (1.235 s) : 0, 1234687
Total [candidate] (9.444 s) : 0, 9444277
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (627.261 ms) : 0, 627261
BytebuddyAgent [candidate] (633.663 ms) : 0, 633663
AgentMeter [baseline] (28.658 ms) : 0, 28658
AgentMeter [candidate] (29.229 ms) : 0, 29229
GlobalTracer [baseline] (257.087 ms) : 0, 257087
GlobalTracer [candidate] (261.892 ms) : 0, 261892
AppSec [baseline] (32.884 ms) : 0, 32884
AppSec [candidate] (33.782 ms) : 0, 33782
Debugger [baseline] (61.733 ms) : 0, 61733
Debugger [candidate] (62.674 ms) : 0, 62674
Remote Config [baseline] (620.284 µs) : 0, 620
Remote Config [candidate] (633.908 µs) : 0, 634
Telemetry [baseline] (10.692 ms) : 0, 10692
Telemetry [candidate] (14.88 ms) : 0, 14880
Flare Poller [baseline] (4.604 ms) : 0, 4604
Flare Poller [candidate] (3.949 ms) : 0, 3949
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (795.178 ms) : 0, 795178
BytebuddyAgent [candidate] (798.23 ms) : 0, 798230
AgentMeter [baseline] (11.142 ms) : 0, 11142
AgentMeter [candidate] (11.182 ms) : 0, 11182
GlobalTracer [baseline] (247.907 ms) : 0, 247907
GlobalTracer [candidate] (248.52 ms) : 0, 248520
AppSec [baseline] (34.011 ms) : 0, 34011
AppSec [candidate] (33.368 ms) : 0, 33368
Debugger [baseline] (65.845 ms) : 0, 65845
Debugger [candidate] (67.139 ms) : 0, 67139
Remote Config [baseline] (543.236 µs) : 0, 543
Remote Config [candidate] (547.686 µs) : 0, 548
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.741 ms) : 0, 8741
Flare Poller [baseline] (3.511 ms) : 0, 3511
Flare Poller [candidate] (3.506 ms) : 0, 3506
IAST [baseline] (26.97 ms) : 0, 26970
IAST [candidate] (26.99 ms) : 0, 26990
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069169
Total [baseline] (10.887 s) : 0, 10887398
Agent [candidate] (1.068 s) : 0, 1067918
Total [candidate] (10.903 s) : 0, 10902946
section appsec
Agent [baseline] (1.239 s) : 0, 1239176
Total [baseline] (11.074 s) : 0, 11073622
Agent [candidate] (1.243 s) : 0, 1242653
Total [candidate] (11.108 s) : 0, 11107904
section iast
Agent [baseline] (1.233 s) : 0, 1233249
Total [baseline] (11.133 s) : 0, 11132504
Agent [candidate] (1.232 s) : 0, 1231796
Total [candidate] (11.287 s) : 0, 11286512
section profiling
Agent [baseline] (1.2 s) : 0, 1200235
Total [baseline] (11.043 s) : 0, 11043149
Agent [candidate] (1.194 s) : 0, 1193640
Total [candidate] (11.033 s) : 0, 11033384
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (630.922 ms) : 0, 630922
BytebuddyAgent [candidate] (630.543 ms) : 0, 630543
AgentMeter [baseline] (28.999 ms) : 0, 28999
AgentMeter [candidate] (28.866 ms) : 0, 28866
GlobalTracer [baseline] (259.263 ms) : 0, 259263
GlobalTracer [candidate] (258.683 ms) : 0, 258683
AppSec [baseline] (33.088 ms) : 0, 33088
AppSec [candidate] (32.994 ms) : 0, 32994
Debugger [baseline] (61.639 ms) : 0, 61639
Debugger [candidate] (62.609 ms) : 0, 62609
Remote Config [baseline] (619.272 µs) : 0, 619
Remote Config [candidate] (609.183 µs) : 0, 609
Telemetry [baseline] (11.0 ms) : 0, 11000
Telemetry [candidate] (11.616 ms) : 0, 11616
Flare Poller [baseline] (6.947 ms) : 0, 6947
Flare Poller [candidate] (5.374 ms) : 0, 5374
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (658.173 ms) : 0, 658173
BytebuddyAgent [candidate] (659.963 ms) : 0, 659963
AgentMeter [baseline] (11.786 ms) : 0, 11786
AgentMeter [candidate] (11.796 ms) : 0, 11796
GlobalTracer [baseline] (258.817 ms) : 0, 258817
GlobalTracer [candidate] (259.445 ms) : 0, 259445
AppSec [baseline] (167.831 ms) : 0, 167831
AppSec [candidate] (168.533 ms) : 0, 168533
Debugger [baseline] (67.45 ms) : 0, 67450
Debugger [candidate] (67.437 ms) : 0, 67437
Remote Config [baseline] (673.591 µs) : 0, 674
Remote Config [candidate] (676.53 µs) : 0, 677
Telemetry [baseline] (9.09 ms) : 0, 9090
Telemetry [candidate] (9.161 ms) : 0, 9161
Flare Poller [baseline] (3.667 ms) : 0, 3667
Flare Poller [candidate] (3.681 ms) : 0, 3681
IAST [baseline] (25.087 ms) : 0, 25087
IAST [candidate] (25.34 ms) : 0, 25340
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (796.282 ms) : 0, 796282
BytebuddyAgent [candidate] (796.325 ms) : 0, 796325
AgentMeter [baseline] (11.159 ms) : 0, 11159
AgentMeter [candidate] (11.144 ms) : 0, 11144
GlobalTracer [baseline] (248.472 ms) : 0, 248472
GlobalTracer [candidate] (248.137 ms) : 0, 248137
AppSec [baseline] (33.169 ms) : 0, 33169
AppSec [candidate] (33.924 ms) : 0, 33924
Debugger [baseline] (68.174 ms) : 0, 68174
Debugger [candidate] (66.257 ms) : 0, 66257
Remote Config [baseline] (554.273 µs) : 0, 554
Remote Config [candidate] (537.137 µs) : 0, 537
Telemetry [baseline] (8.625 ms) : 0, 8625
Telemetry [candidate] (8.658 ms) : 0, 8658
Flare Poller [baseline] (3.45 ms) : 0, 3450
Flare Poller [candidate] (3.421 ms) : 0, 3421
IAST [baseline] (26.944 ms) : 0, 26944
IAST [candidate] (27.012 ms) : 0, 27012
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (687.195 ms) : 0, 687195
BytebuddyAgent [candidate] (683.263 ms) : 0, 683263
AgentMeter [baseline] (8.732 ms) : 0, 8732
AgentMeter [candidate] (8.682 ms) : 0, 8682
GlobalTracer [baseline] (217.862 ms) : 0, 217862
GlobalTracer [candidate] (216.272 ms) : 0, 216272
AppSec [baseline] (32.836 ms) : 0, 32836
AppSec [candidate] (32.526 ms) : 0, 32526
Debugger [baseline] (68.123 ms) : 0, 68123
Debugger [candidate] (67.841 ms) : 0, 67841
Remote Config [baseline] (609.433 µs) : 0, 609
Remote Config [candidate] (596.852 µs) : 0, 597
Telemetry [baseline] (8.861 ms) : 0, 8861
Telemetry [candidate] (8.849 ms) : 0, 8849
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.756 ms) : 0, 3756
ProfilingAgent [baseline] (100.657 ms) : 0, 100657
ProfilingAgent [candidate] (100.802 ms) : 0, 100802
Profiling [baseline] (101.233 ms) : 0, 101233
Profiling [candidate] (101.37 ms) : 0, 101370
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.162 ms) : 3124, 3199
. : milestone, 3162,
iast_FULL (5.763 ms) : 5704, 5822
. : milestone, 5763,
iast_GLOBAL (3.597 ms) : 3535, 3659
. : milestone, 3597,
profiling (2.044 ms) : 2026, 2061
. : milestone, 2044,
tracing (1.878 ms) : 1863, 1893
. : milestone, 1878,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.141 ms) : 3103, 3180
. : milestone, 3141,
iast_FULL (5.792 ms) : 5735, 5850
. : milestone, 5792,
iast_GLOBAL (3.634 ms) : 3581, 3687
. : milestone, 3634,
profiling (2.054 ms) : 2035, 2073
. : milestone, 2054,
tracing (1.811 ms) : 1794, 1827
. : milestone, 1811,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (18.231 ms) : 18044, 18417
. : milestone, 18231,
appsec (19.033 ms) : 18844, 19222
. : milestone, 19033,
code_origins (17.805 ms) : 17628, 17982
. : milestone, 17805,
iast (17.898 ms) : 17722, 18073
. : milestone, 17898,
profiling (18.631 ms) : 18446, 18815
. : milestone, 18631,
tracing (17.812 ms) : 17633, 17991
. : milestone, 17812,
section candidate
no_agent (18.037 ms) : 17855, 18218
. : milestone, 18037,
appsec (18.638 ms) : 18448, 18827
. : milestone, 18638,
code_origins (17.471 ms) : 17300, 17641
. : milestone, 17471,
iast (17.656 ms) : 17480, 17833
. : milestone, 17656,
profiling (18.511 ms) : 18324, 18698
. : milestone, 18511,
tracing (17.649 ms) : 17476, 17822
. : milestone, 17649,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
appsec (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
iast (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
tracing (14.769 s) : 14769000, 14769000
. : milestone, 14769000,
section candidate
no_agent (15.352 s) : 15352000, 15352000
. : milestone, 15352000,
appsec (14.553 s) : 14553000, 14553000
. : milestone, 14553000,
iast (18.305 s) : 18305000, 18305000
. : milestone, 18305000,
iast_GLOBAL (18.025 s) : 18025000, 18025000
. : milestone, 18025000,
profiling (14.691 s) : 14691000, 14691000
. : milestone, 14691000,
tracing (14.57 s) : 14570000, 14570000
. : milestone, 14570000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~d3d708ce7d, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.493 ms) : 2439, 2548
. : milestone, 2493,
iast (2.257 ms) : 2187, 2326
. : milestone, 2257,
iast_GLOBAL (2.307 ms) : 2237, 2378
. : milestone, 2307,
profiling (2.094 ms) : 2038, 2151
. : milestone, 2094,
tracing (2.054 ms) : 2001, 2108
. : milestone, 2054,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.75 ms) : 3527, 3972
. : milestone, 3750,
iast (2.249 ms) : 2180, 2319
. : milestone, 2249,
iast_GLOBAL (2.301 ms) : 2231, 2371
. : milestone, 2301,
profiling (2.073 ms) : 2018, 2128
. : milestone, 2073,
tracing (2.056 ms) : 2003, 2110
. : milestone, 2056,
|
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (326.517 µs) : 269, 384
. : milestone, 327,
basic (276.109 µs) : 269, 283
. : milestone, 276,
loop (8.964 ms) : 8959, 8969
. : milestone, 8964,
section candidate
noprobe (312.483 µs) : 286, 339
. : milestone, 312,
basic (274.444 µs) : 268, 280
. : milestone, 274,
loop (8.964 ms) : 8960, 8969
. : milestone, 8964,
|
What Does This Do
When SymDB explicitly disabled and Dynamic Instrumentation is enabled honor correctly the disablemennt
Same for Code Origin
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5124