Update generic signature when adding field-injection marker…#2203
Merged
Update generic signature when adding field-injection marker…#2203
Conversation
…sor interfaces to a generic type.
b5b8b6d to
ec0eaac
Compare
richardstartin
approved these changes
Dec 15, 2020
tylerbenson
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and accessor interfaces to a generic type.
If we don't do this then the result from
getInterfacesandgetGenericInterfaceswon't be aligned which can cause issues when application/framework code inspects the class using reflection. Normally this sort of thing is managed by the Java compiler, but since we're modifying things at the bytecode level we have to manage this ourselves.https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.3.4