JAX-WS WebService and WebServiceProvider instrumentation#2473
Merged
Conversation
...ws-annotations-1/src/main/java/datadog/trace/instrumentation/jaxws1/WebServiceDecorator.java
Outdated
Show resolved
Hide resolved
...otations-1/src/main/java/datadog/trace/instrumentation/jaxws1/WebServiceInstrumentation.java
Outdated
Show resolved
Hide resolved
...otations-1/src/main/java/datadog/trace/instrumentation/jaxws1/WebServiceInstrumentation.java
Show resolved
Hide resolved
...ations-2/src/main/java/datadog/trace/instrumentation/jaxws2/WebServiceProviderDecorator.java
Outdated
Show resolved
Hide resolved
...-2/src/main/java/datadog/trace/instrumentation/jaxws2/WebServiceProviderInstrumentation.java
Outdated
Show resolved
Hide resolved
Contributor
|
Given the complexity of the matching, and SOAP being a relatively rare format these days, I think the quickest path to getting this merged without impacting non-SOAP users would be to disable this by default and have SOAP users opt in. |
richardstartin
approved these changes
Mar 9, 2021
tylerbenson
approved these changes
Mar 9, 2021
Contributor
tylerbenson
left a comment
There was a problem hiding this comment.
Looks good. You can combine the instrumentation if you want or leave separate. (I'm ok either way.)
dd-java-agent/instrumentation/jax-ws-annotations-1/jax-ws-annotations-1.gradle
Show resolved
Hide resolved
dd-java-agent/instrumentation/jax-ws-annotations-2/jax-ws-annotations-2.gradle
Show resolved
Hide resolved
...otations-1/src/main/java/datadog/trace/instrumentation/jaxws1/WebServiceInstrumentation.java
Show resolved
Hide resolved
bantonsson
approved these changes
Mar 9, 2021
This was referenced Mar 11, 2021
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruments endpoints annotated with
@WebService(JAX-WS 1.x) and@WebServiceProvider(JAX-WS 2.x)This support is turned off by default, but can be enabled with
-Ddd.integration.jax-ws.enabled=trueor by setting