Conversation
| httpCon.setRequestProperty("Content-Type", "application/json"); | ||
| httpCon.setRequestProperty("Datadog-Meta-Lang", "java"); | ||
| httpCon.setRequestProperty("Datadog-Meta-Lang-Version", DDTracer.JAVA_VERSION); | ||
| httpCon.setRequestProperty("Datadog-Meta-Tracer-Version", DDTracer.CURRENT_VERSION); |
| public class DDApi { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName()); | ||
| private static final Logger logger = LoggerFactory.getLogger(DDApi.class.getName()); |
There was a problem hiding this comment.
Looks like formatting changed a lot. Was this intentional? Perhaps we should have a discussion on applying and enforcing standardized formatting?
There was a problem hiding this comment.
mhhhhh thought it was intentional / agreed... if we're changing the code-style, let's agree on that plus update all the rest. If it's a mistake, just undo the code style refactoring.
There was a problem hiding this comment.
I would rather we do all the reformatting in one PR, otherwise it will pollute PR's going forward. I'm ok getting this merged as is though. Merging now.
tylerbenson
left a comment
There was a problem hiding this comment.
With the test improvements I'm adding to DDApi, it should be easy to verify this. I'll add those tests in my branch.
|
Yes that's fine, we can enforce the code-style with tools and guidelines as you said before. 👍 to me. |
Sorry, old file format.
Adding