Skip to content

Fix for Vert.x 4.0 null path case#5203

Merged
ygree merged 1 commit intomasterfrom
ygree/vertx-null-path-fix
May 17, 2023
Merged

Fix for Vert.x 4.0 null path case#5203
ygree merged 1 commit intomasterfrom
ygree/vertx-null-path-fix

Conversation

@ygree
Copy link
Contributor

@ygree ygree commented May 12, 2023

What Does This Do

Fixes use case when the current route path is null

Motivation

routingContext.currentRoute().getPath() can be null

Additional Notes

#5177

@ygree ygree added type: bug Bug report and fix inst: others All other instrumentations labels May 12, 2023
@ygree ygree self-assigned this May 12, 2023
@ygree ygree requested a review from a team as a code owner May 12, 2023 20:31
@pr-commenter
Copy link

pr-commenter bot commented May 12, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~1dbd02ab57 1.15.0-SNAPSHOT~691c397346
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config unsure
[+0.677µs; +14.980µs] or [+0.109%; +2.408%]
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start unsure
[+0.000s; +0.006s] or [+0.014%; +0.619%]
scenario:Startup-waf-BytebuddyAgent unsure
[+0.177ms; +3.685ms] or [+0.030%; +0.623%]
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants