Migrate agent and instrumentations to environment component#9093
Migrate agent and instrumentations to environment component#9093PerfectSlayer merged 1 commit intomasterfrom
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (311.315 µs) : 290, 332
. : milestone, 311,
basic (315.175 µs) : 306, 324
. : milestone, 315,
loop (10.821 ms) : 10816, 10826
. : milestone, 10821,
section candidate
noprobe (323.793 µs) : 282, 365
. : milestone, 324,
basic (316.345 µs) : 306, 327
. : milestone, 316,
loop (10.168 ms) : 10124, 10213
. : milestone, 10168,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (999.174 ms) : 0, 999174
Total [baseline] (10.6 s) : 0, 10600095
Agent [candidate] (996.057 ms) : 0, 996057
Total [candidate] (10.576 s) : 0, 10575531
section appsec
Agent [baseline] (1.184 s) : 0, 1183533
Total [baseline] (10.8 s) : 0, 10800321
Agent [candidate] (1.183 s) : 0, 1182806
Total [candidate] (10.804 s) : 0, 10804095
section iast
Agent [baseline] (1.133 s) : 0, 1133332
Total [baseline] (10.809 s) : 0, 10808838
Agent [candidate] (1.14 s) : 0, 1139682
Total [candidate] (10.816 s) : 0, 10815892
section profiling
Agent [baseline] (1.252 s) : 0, 1252320
Total [baseline] (11.016 s) : 0, 11015678
Agent [candidate] (1.246 s) : 0, 1246149
Total [candidate] (11.0 s) : 0, 10999507
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.654 ms) : 0, 690654
BytebuddyAgent [candidate] (687.501 ms) : 0, 687501
GlobalTracer [baseline] (242.427 ms) : 0, 242427
GlobalTracer [candidate] (241.998 ms) : 0, 241998
AppSec [baseline] (30.398 ms) : 0, 30398
AppSec [candidate] (30.256 ms) : 0, 30256
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (685.408 µs) : 0, 685
Remote Config [candidate] (681.701 µs) : 0, 682
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.259 ms) : 0, 8259
section appsec
BytebuddyAgent [baseline] (716.315 ms) : 0, 716315
BytebuddyAgent [candidate] (715.585 ms) : 0, 715585
GlobalTracer [baseline] (236.344 ms) : 0, 236344
GlobalTracer [candidate] (236.525 ms) : 0, 236525
AppSec [baseline] (171.928 ms) : 0, 171928
AppSec [candidate] (171.157 ms) : 0, 171157
Debugger [baseline] (5.796 ms) : 0, 5796
Debugger [candidate] (5.744 ms) : 0, 5744
Remote Config [baseline] (609.116 µs) : 0, 609
Remote Config [candidate] (594.892 µs) : 0, 595
Telemetry [baseline] (8.151 ms) : 0, 8151
Telemetry [candidate] (8.098 ms) : 0, 8098
IAST [baseline] (23.501 ms) : 0, 23501
IAST [candidate] (23.525 ms) : 0, 23525
section iast
BytebuddyAgent [baseline] (807.968 ms) : 0, 807968
BytebuddyAgent [candidate] (813.682 ms) : 0, 813682
GlobalTracer [baseline] (232.819 ms) : 0, 232819
GlobalTracer [candidate] (232.904 ms) : 0, 232904
AppSec [baseline] (29.637 ms) : 0, 29637
AppSec [candidate] (30.163 ms) : 0, 30163
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.835 ms) : 0, 5835
Remote Config [baseline] (586.756 µs) : 0, 587
Remote Config [candidate] (577.68 µs) : 0, 578
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (8.042 ms) : 0, 8042
IAST [baseline] (27.72 ms) : 0, 27720
IAST [candidate] (27.07 ms) : 0, 27070
section profiling
ProfilingAgent [baseline] (104.811 ms) : 0, 104811
ProfilingAgent [candidate] (102.93 ms) : 0, 102930
BytebuddyAgent [baseline] (683.027 ms) : 0, 683027
BytebuddyAgent [candidate] (679.481 ms) : 0, 679481
GlobalTracer [baseline] (362.465 ms) : 0, 362465
GlobalTracer [candidate] (361.482 ms) : 0, 361482
AppSec [baseline] (33.282 ms) : 0, 33282
AppSec [candidate] (33.811 ms) : 0, 33811
Debugger [baseline] (9.838 ms) : 0, 9838
Debugger [candidate] (9.115 ms) : 0, 9115
Remote Config [baseline] (667.336 µs) : 0, 667
Remote Config [candidate] (660.17 µs) : 0, 660
Telemetry [baseline] (8.803 ms) : 0, 8803
Telemetry [candidate] (9.476 ms) : 0, 9476
Profiling [baseline] (104.836 ms) : 0, 104836
Profiling [candidate] (102.954 ms) : 0, 102954
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.387 ms) : 0, 996387
Total [baseline] (8.561 s) : 0, 8561268
Agent [candidate] (995.524 ms) : 0, 995524
Total [candidate] (8.607 s) : 0, 8607241
section iast
Agent [baseline] (1.136 s) : 0, 1135979
Total [baseline] (9.265 s) : 0, 9265211
Agent [candidate] (1.133 s) : 0, 1132953
Total [candidate] (9.26 s) : 0, 9260462
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.803 ms) : 0, 688803
BytebuddyAgent [candidate] (687.173 ms) : 0, 687173
GlobalTracer [baseline] (241.575 ms) : 0, 241575
GlobalTracer [candidate] (241.729 ms) : 0, 241729
AppSec [baseline] (30.348 ms) : 0, 30348
AppSec [candidate] (30.273 ms) : 0, 30273
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (670.228 µs) : 0, 670
Remote Config [candidate] (686.374 µs) : 0, 686
Telemetry [baseline] (8.216 ms) : 0, 8216
Telemetry [candidate] (8.284 ms) : 0, 8284
section iast
BytebuddyAgent [baseline] (810.175 ms) : 0, 810175
BytebuddyAgent [candidate] (807.139 ms) : 0, 807139
GlobalTracer [baseline] (233.283 ms) : 0, 233283
GlobalTracer [candidate] (232.61 ms) : 0, 232610
AppSec [baseline] (28.632 ms) : 0, 28632
AppSec [candidate] (31.231 ms) : 0, 31231
Debugger [baseline] (5.805 ms) : 0, 5805
Debugger [candidate] (5.805 ms) : 0, 5805
Remote Config [baseline] (573.136 µs) : 0, 573
Remote Config [candidate] (590.965 µs) : 0, 591
Telemetry [baseline] (8.076 ms) : 0, 8076
Telemetry [candidate] (7.987 ms) : 0, 7987
IAST [baseline] (28.739 ms) : 0, 28739
IAST [candidate] (26.339 ms) : 0, 26339
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (37.505 ms) : 37211, 37798
. : milestone, 37505,
appsec (47.704 ms) : 47272, 48136
. : milestone, 47704,
code_origins (43.651 ms) : 43290, 44013
. : milestone, 43651,
iast (44.29 ms) : 43912, 44667
. : milestone, 44290,
profiling (47.274 ms) : 46862, 47686
. : milestone, 47274,
tracing (43.508 ms) : 43157, 43859
. : milestone, 43508,
section candidate
no_agent (36.246 ms) : 35957, 36536
. : milestone, 36246,
appsec (46.953 ms) : 46526, 47381
. : milestone, 46953,
code_origins (45.474 ms) : 45093, 45855
. : milestone, 45474,
iast (44.434 ms) : 44046, 44821
. : milestone, 44434,
profiling (50.696 ms) : 50193, 51200
. : milestone, 50696,
tracing (43.026 ms) : 42668, 43383
. : milestone, 43026,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (4.372 ms) : 4320, 4424
. : milestone, 4372,
iast (9.214 ms) : 9058, 9370
. : milestone, 9214,
iast_FULL (14.178 ms) : 13899, 14457
. : milestone, 14178,
iast_GLOBAL (10.426 ms) : 10241, 10611
. : milestone, 10426,
profiling (8.987 ms) : 8826, 9149
. : milestone, 8987,
tracing (7.435 ms) : 7328, 7542
. : milestone, 7435,
section candidate
no_agent (4.247 ms) : 4196, 4297
. : milestone, 4247,
iast (9.378 ms) : 9228, 9528
. : milestone, 9378,
iast_FULL (14.103 ms) : 13819, 14388
. : milestone, 14103,
iast_GLOBAL (10.637 ms) : 10448, 10826
. : milestone, 10637,
profiling (8.771 ms) : 8632, 8911
. : milestone, 8771,
tracing (7.386 ms) : 7271, 7502
. : milestone, 7386,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.402 ms) : 2353, 2452
. : milestone, 2402,
iast (2.197 ms) : 2134, 2259
. : milestone, 2197,
iast_GLOBAL (2.234 ms) : 2172, 2296
. : milestone, 2234,
profiling (2.056 ms) : 2005, 2107
. : milestone, 2056,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.403 ms) : 2353, 2453
. : milestone, 2403,
iast (2.192 ms) : 2130, 2254
. : milestone, 2192,
iast_GLOBAL (2.225 ms) : 2162, 2287
. : milestone, 2225,
profiling (2.495 ms) : 2319, 2671
. : milestone, 2495,
tracing (2.011 ms) : 1963, 2060
. : milestone, 2011,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e1aa51eefc, baseline=1.51.0-SNAPSHOT~33422a3a65
dateFormat X
axisFormat %s
section baseline
no_agent (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
appsec (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
iast (18.488 s) : 18488000, 18488000
. : milestone, 18488000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
tracing (14.552 s) : 14552000, 14552000
. : milestone, 14552000,
section candidate
no_agent (15.519 s) : 15519000, 15519000
. : milestone, 15519000,
appsec (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
iast (18.527 s) : 18527000, 18527000
. : milestone, 18527000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
. : milestone, 18073000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
|
| api libs.slf4j | ||
| api project(':internal-api') | ||
| api project(':dd-java-agent:agent-profiling:profiling-utils') | ||
| implementation project(':components:environment') |
There was a problem hiding this comment.
Please double check that this should be implementation, not api.
Previous Platform is inside internal-api that declared as api.
Probably make sense to double check all similar places.
There was a problem hiding this comment.
Good call. :components:environment is already exposed as part of the :internal-api API.
So it should not be needed here.
I checked the others two dd-java-agent/agent-profiling/profiling-controller-jfr/implementation and dd-java-agent/agent-profiling/profiling-utils that do need it though.
f3e2b77 to
7d59d7a
Compare
7d59d7a to
e1aa51e
Compare
What Does This Do
This PR migrates the internal API to the environment components.
Follow-up to:
Motivation
Additional Notes
This PR is mainly refactoring to use the new methods from the environment component rather than the original ones in
Platform.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-458