Add new org to Weaver instrumentation#9195
Closed
majk-p wants to merge 3 commits intoDataDog:masterfrom
Closed
Conversation
daniel-mohedano
requested changes
Jul 17, 2025
Contributor
There was a problem hiding this comment.
Thanks for opening this PR @majk-p! From what I've gathered by locally testing, I think some additional changes will be necessary in order to support TypeLevel releases too, as currently the instrumentation will break with them. Will get back to you as soon as I take a look 👍
nikita-tkachenko-datadog
approved these changes
Jul 24, 2025
daniel-mohedano
approved these changes
Jul 24, 2025
Contributor
|
@majk-p the PR looks good to go! With the changes to the instrumentation the new typelevel versions will be supported moving forward. Could you please rebase and sign your initial commit to the PR in order to unblock the check? |
Author
|
All done now! I accidentally overwrote your changes with the rebase, but cherry-picked them from #9235, I hope it's fine |
ad7bf27 to
45f4161
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates Weaver instrumentation to take into account changes to the organization following the recent migration
Motivation
Weaver has been migrated (typelevel/governance#114) from disneystreaming (https://github.com/disneystreaming/weaver-test) to typelevel (https://github.com/typelevel/weaver-test) organization. It has also got version updates in the meantime.
Additional Notes
Passing CI on #9235
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]