Fix generic url parsing in jdbc instrumentation by vandonr · Pull Request #9777 · DataDog/dd-trace-java

vandonr · 2025-10-16T13:30:25Z

What Does This Do

I realized while writing tests for a different PR that we were using the wrong string, so URI parsing failed and we were not extracting any info from the URL.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

vandonr · 2025-10-16T13:32:51Z

...trap/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java

@@ -870,7 +870,7 @@ public static DBInfo parse(String connectionUrl, final Properties props) {
        // Delegate to specific parser
        return typeParsers.get(baseType).doParse(jdbcUrl, parsedProps).build();


here we are using the correct variable

...trap/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java

AlexeyKuznetsov-DD · 2025-10-16T13:47:28Z

dd-java-agent/instrumentation/jdbc/src/test/groovy/JDBCDecoratorTest.groovy

+    assert dbInfo.type == "testdb"
+    assert dbInfo.db == "testdatabase"
+    assert dbInfo.host == "myhost"
+    assert dbInfo.port == 9999
+    assert dbInfo.warehouse == "hello"


I believe in Groovy/Spock you do not need assert in then: section.
Spock just expects expression to be true

datadog-datadog-prod-us1 · 2025-10-16T13:58:37Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.30% (+3.59%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fc22174 | Docs | Was this helpful? Give us feedback!}

amarziali

sounds reasonable thanks

pr-commenter · 2025-10-16T14:22:00Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1761040294	1761041074
git_commit_sha	`2e46666`	`fc22174`
release_version	1.55.0-SNAPSHOT~2e46666c2f	1.55.0-SNAPSHOT~fc22174c46

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761042879	1761042879
ci_job_id	1188592301	1188592301
ci_pipeline_id	79821902	79821902
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-10haexa0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-10haexa0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018480
Total [baseline] (10.756 s) : 0, 10756085
Agent [candidate] (1.018 s) : 0, 1017812
Total [candidate] (10.74 s) : 0, 10740494
section appsec
Agent [baseline] (1.199 s) : 0, 1199169
Total [baseline] (10.831 s) : 0, 10830903
Agent [candidate] (1.193 s) : 0, 1193271
Total [candidate] (10.91 s) : 0, 10910173
section iast
Agent [baseline] (1.155 s) : 0, 1154605
Total [baseline] (11.128 s) : 0, 11127865
Agent [candidate] (1.151 s) : 0, 1151424
Total [candidate] (11.123 s) : 0, 11122884
section profiling
Agent [baseline] (1.167 s) : 0, 1166543
Total [baseline] (10.925 s) : 0, 10925101
Agent [candidate] (1.165 s) : 0, 1165486
Total [candidate] (10.939 s) : 0, 10938808

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.018 s	-
Agent	appsec	1.199 s	180.689 ms (17.7%)
Agent	iast	1.155 s	136.125 ms (13.4%)
Agent	profiling	1.167 s	148.063 ms (14.5%)
Total	tracing	10.756 s	-
Total	appsec	10.831 s	74.818 ms (0.7%)
Total	iast	11.128 s	371.779 ms (3.5%)
Total	profiling	10.925 s	169.016 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.018 s	-
Agent	appsec	1.193 s	175.459 ms (17.2%)
Agent	iast	1.151 s	133.612 ms (13.1%)
Agent	profiling	1.165 s	147.674 ms (14.5%)
Total	tracing	10.74 s	-
Total	appsec	10.91 s	169.679 ms (1.6%)
Total	iast	11.123 s	382.391 ms (3.6%)
Total	profiling	10.939 s	198.315 ms (1.8%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (694.155 ms) : 0, 694155
BytebuddyAgent [candidate] (694.321 ms) : 0, 694321
GlobalTracer [baseline] (243.372 ms) : 0, 243372
GlobalTracer [candidate] (242.922 ms) : 0, 242922
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.168 ms) : 0, 32168
Debugger [baseline] (6.255 ms) : 0, 6255
Debugger [candidate] (6.243 ms) : 0, 6243
Remote Config [baseline] (682.951 µs) : 0, 683
Remote Config [candidate] (669.321 µs) : 0, 669
Telemetry [baseline] (9.344 ms) : 0, 9344
Telemetry [candidate] (9.305 ms) : 0, 9305
Flare Poller [baseline] (9.595 ms) : 0, 9595
Flare Poller [candidate] (9.568 ms) : 0, 9568
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (721.501 ms) : 0, 721501
BytebuddyAgent [candidate] (717.252 ms) : 0, 717252
GlobalTracer [baseline] (235.465 ms) : 0, 235465
GlobalTracer [candidate] (234.694 ms) : 0, 234694
IAST [baseline] (24.832 ms) : 0, 24832
IAST [candidate] (24.747 ms) : 0, 24747
AppSec [baseline] (175.447 ms) : 0, 175447
AppSec [candidate] (174.857 ms) : 0, 174857
Debugger [baseline] (6.084 ms) : 0, 6084
Debugger [candidate] (6.09 ms) : 0, 6090
Remote Config [baseline] (633.124 µs) : 0, 633
Remote Config [candidate] (635.838 µs) : 0, 636
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.534 ms) : 0, 8534
Flare Poller [baseline] (3.931 ms) : 0, 3931
Flare Poller [candidate] (3.867 ms) : 0, 3867
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (816.957 ms) : 0, 816957
BytebuddyAgent [candidate] (814.628 ms) : 0, 814628
GlobalTracer [baseline] (232.619 ms) : 0, 232619
GlobalTracer [candidate] (232.236 ms) : 0, 232236
IAST [baseline] (26.771 ms) : 0, 26771
IAST [candidate] (26.572 ms) : 0, 26572
AppSec [baseline] (35.57 ms) : 0, 35570
AppSec [candidate] (35.188 ms) : 0, 35188
Debugger [baseline] (6.129 ms) : 0, 6129
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (601.942 µs) : 0, 602
Remote Config [candidate] (601.351 µs) : 0, 601
Telemetry [baseline] (8.74 ms) : 0, 8740
Telemetry [candidate] (8.769 ms) : 0, 8769
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (4.332 ms) : 0, 4332
section profiling
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (721.828 ms) : 0, 721828
BytebuddyAgent [candidate] (721.134 ms) : 0, 721134
GlobalTracer [baseline] (219.535 ms) : 0, 219535
GlobalTracer [candidate] (219.487 ms) : 0, 219487
AppSec [baseline] (32.368 ms) : 0, 32368
AppSec [candidate] (32.29 ms) : 0, 32290
Debugger [baseline] (6.646 ms) : 0, 6646
Debugger [candidate] (6.653 ms) : 0, 6653
Remote Config [baseline] (722.87 µs) : 0, 723
Remote Config [candidate] (1.434 ms) : 0, 1434
Telemetry [baseline] (16.221 ms) : 0, 16221
Telemetry [candidate] (15.061 ms) : 0, 15061
Flare Poller [baseline] (4.195 ms) : 0, 4195
Flare Poller [candidate] (4.114 ms) : 0, 4114
ProfilingAgent [baseline] (109.6 ms) : 0, 109600
ProfilingAgent [candidate] (109.988 ms) : 0, 109988
Profiling [baseline] (110.228 ms) : 0, 110228
Profiling [candidate] (110.626 ms) : 0, 110626

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018149
Total [baseline] (8.742 s) : 0, 8742211
Agent [candidate] (1.021 s) : 0, 1020984
Total [candidate] (8.682 s) : 0, 8681798
section iast
Agent [baseline] (1.153 s) : 0, 1153071
Total [baseline] (9.308 s) : 0, 9307599
Agent [candidate] (1.158 s) : 0, 1157766
Total [candidate] (9.305 s) : 0, 9304828

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.018 s	-
Agent	iast	1.153 s	134.922 ms (13.3%)
Total	tracing	8.742 s	-
Total	iast	9.308 s	565.388 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	iast	1.158 s	136.782 ms (13.4%)
Total	tracing	8.682 s	-
Total	iast	9.305 s	623.03 ms (7.2%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (693.329 ms) : 0, 693329
BytebuddyAgent [candidate] (694.518 ms) : 0, 694518
GlobalTracer [baseline] (243.154 ms) : 0, 243154
GlobalTracer [candidate] (243.584 ms) : 0, 243584
AppSec [baseline] (31.888 ms) : 0, 31888
AppSec [candidate] (32.195 ms) : 0, 32195
Debugger [baseline] (6.29 ms) : 0, 6290
Debugger [candidate] (6.268 ms) : 0, 6268
Remote Config [baseline] (684.271 µs) : 0, 684
Remote Config [candidate] (673.217 µs) : 0, 673
Telemetry [baseline] (9.266 ms) : 0, 9266
Telemetry [candidate] (9.313 ms) : 0, 9313
Flare Poller [baseline] (10.919 ms) : 0, 10919
Flare Poller [candidate] (11.758 ms) : 0, 11758
section iast
crashtracking [baseline] (1.513 ms) : 0, 1513
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (816.05 ms) : 0, 816050
BytebuddyAgent [candidate] (819.96 ms) : 0, 819960
GlobalTracer [baseline] (232.032 ms) : 0, 232032
GlobalTracer [candidate] (233.235 ms) : 0, 233235
IAST [baseline] (26.794 ms) : 0, 26794
IAST [candidate] (26.875 ms) : 0, 26875
AppSec [baseline] (35.442 ms) : 0, 35442
AppSec [candidate] (34.983 ms) : 0, 34983
Debugger [baseline] (6.164 ms) : 0, 6164
Debugger [candidate] (6.144 ms) : 0, 6144
Remote Config [baseline] (609.47 µs) : 0, 609
Remote Config [candidate] (596.811 µs) : 0, 597
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.638 ms) : 0, 8638
Flare Poller [baseline] (4.266 ms) : 0, 4266
Flare Poller [candidate] (4.298 ms) : 0, 4298

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1761040294	1761041074
git_commit_sha	`2e46666`	`fc22174`
release_version	1.55.0-SNAPSHOT~2e46666c2f	1.55.0-SNAPSHOT~fc22174c46

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761042553	1761042553
ci_job_id	1188592302	1188592302
ci_pipeline_id	79821902	79821902
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-d8pqkg6y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-d8pqkg6y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+363.606µs; +772.485µs] or [+3.519%; +7.477%]	unstable [-74.459op/s; +27.959op/s] or [-16.553%; +6.216%]	10.899ms	426.562op/s	10.331ms	449.812op/s
scenario:load:insecure-bank:iast_FULL:high_load	better [-1.898ms; -1.266ms] or [-12.332%; -8.224%]	unstable [-1.097op/s; +69.910op/s] or [-0.362%; +23.072%]	13.808ms	337.406op/s	15.390ms	303.000op/s
scenario:load:insecure-bank:profiling:high_load	better [-792.624µs; -480.566µs] or [-8.673%; -5.258%]	unstable [-33.016op/s; +108.203op/s] or [-6.500%; +21.302%]	8.502ms	545.531op/s	9.139ms	507.938op/s
scenario:load:petclinic:profiling:high_load	worse [+1.350ms; +2.330ms] or [+2.841%; +4.905%]	unstable [-9.365op/s; +4.391op/s] or [-9.504%; +4.457%]	49.351ms	96.051op/s	47.511ms	98.537op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.413 ms) : 4363, 4463
.   : milestone, 4413,
iast (9.974 ms) : 9804, 10143
.   : milestone, 9974,
iast_FULL (15.39 ms) : 15080, 15701
.   : milestone, 15390,
iast_GLOBAL (10.331 ms) : 10147, 10516
.   : milestone, 10331,
profiling (9.139 ms) : 8980, 9298
.   : milestone, 9139,
tracing (7.994 ms) : 7872, 8115
.   : milestone, 7994,
section candidate
no_agent (4.432 ms) : 4381, 4484
.   : milestone, 4432,
iast (9.823 ms) : 9660, 9986
.   : milestone, 9823,
iast_FULL (13.808 ms) : 13532, 14085
.   : milestone, 13808,
iast_GLOBAL (10.899 ms) : 10704, 11095
.   : milestone, 10899,
profiling (8.502 ms) : 8373, 8631
.   : milestone, 8502,
tracing (7.835 ms) : 7719, 7951
.   : milestone, 7835,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.413 ms [4.363 ms, 4.463 ms]	-
iast	9.974 ms [9.804 ms, 10.143 ms]	5.561 ms (126.0%)
iast_FULL	15.39 ms [15.08 ms, 15.701 ms]	10.977 ms (248.8%)
iast_GLOBAL	10.331 ms [10.147 ms, 10.516 ms]	5.919 ms (134.1%)
profiling	9.139 ms [8.98 ms, 9.298 ms]	4.726 ms (107.1%)
tracing	7.994 ms [7.872 ms, 8.115 ms]	3.581 ms (81.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.432 ms [4.381 ms, 4.484 ms]	-
iast	9.823 ms [9.66 ms, 9.986 ms]	5.391 ms (121.6%)
iast_FULL	13.808 ms [13.532 ms, 14.085 ms]	9.376 ms (211.5%)
iast_GLOBAL	10.899 ms [10.704 ms, 11.095 ms]	6.467 ms (145.9%)
profiling	8.502 ms [8.373 ms, 8.631 ms]	4.07 ms (91.8%)
tracing	7.835 ms [7.719 ms, 7.951 ms]	3.403 ms (76.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.544 ms) : 36252, 36836
.   : milestone, 36544,
appsec (49.607 ms) : 49171, 50042
.   : milestone, 49607,
code_origins (43.149 ms) : 42764, 43533
.   : milestone, 43149,
iast (42.977 ms) : 42617, 43337
.   : milestone, 42977,
profiling (47.511 ms) : 47068, 47953
.   : milestone, 47511,
tracing (43.224 ms) : 42860, 43589
.   : milestone, 43224,
section candidate
no_agent (36.298 ms) : 36008, 36588
.   : milestone, 36298,
appsec (49.143 ms) : 48695, 49592
.   : milestone, 49143,
code_origins (43.89 ms) : 43506, 44274
.   : milestone, 43890,
iast (44.056 ms) : 43673, 44440
.   : milestone, 44056,
profiling (49.351 ms) : 48882, 49819
.   : milestone, 49351,
tracing (43.26 ms) : 42895, 43626
.   : milestone, 43260,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.544 ms [36.252 ms, 36.836 ms]	-
appsec	49.607 ms [49.171 ms, 50.042 ms]	13.063 ms (35.7%)
code_origins	43.149 ms [42.764 ms, 43.533 ms]	6.605 ms (18.1%)
iast	42.977 ms [42.617 ms, 43.337 ms]	6.433 ms (17.6%)
profiling	47.511 ms [47.068 ms, 47.953 ms]	10.967 ms (30.0%)
tracing	43.224 ms [42.86 ms, 43.589 ms]	6.681 ms (18.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.298 ms [36.008 ms, 36.588 ms]	-
appsec	49.143 ms [48.695 ms, 49.592 ms]	12.845 ms (35.4%)
code_origins	43.89 ms [43.506 ms, 44.274 ms]	7.592 ms (20.9%)
iast	44.056 ms [43.673 ms, 44.44 ms]	7.758 ms (21.4%)
profiling	49.351 ms [48.882 ms, 49.819 ms]	13.052 ms (36.0%)
tracing	43.26 ms [42.895 ms, 43.626 ms]	6.962 ms (19.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/fix
git_commit_date	1761040294	1761041074
git_commit_sha	`2e46666`	`fc22174`
release_version	1.55.0-SNAPSHOT~2e46666c2f	1.55.0-SNAPSHOT~fc22174c46

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761043137	1761043137
ci_job_id	1188592303	1188592303
ci_pipeline_id	79821902	79821902
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-s7w572xo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-s7w572xo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.788 s) : 14788000, 14788000
.   : milestone, 14788000,
appsec (15.29 s) : 15290000, 15290000
.   : milestone, 15290000,
iast (18.654 s) : 18654000, 18654000
.   : milestone, 18654000,
iast_GLOBAL (17.809 s) : 17809000, 17809000
.   : milestone, 17809000,
profiling (15.509 s) : 15509000, 15509000
.   : milestone, 15509000,
tracing (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
section candidate
no_agent (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
appsec (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,
iast (18.516 s) : 18516000, 18516000
.   : milestone, 18516000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
.   : milestone, 17952000,
profiling (15.384 s) : 15384000, 15384000
.   : milestone, 15384000,
tracing (14.766 s) : 14766000, 14766000
.   : milestone, 14766000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.788 s [14.788 s, 14.788 s]	-
appsec	15.29 s [15.29 s, 15.29 s]	502.0 ms (3.4%)
iast	18.654 s [18.654 s, 18.654 s]	3.866 s (26.1%)
iast_GLOBAL	17.809 s [17.809 s, 17.809 s]	3.021 s (20.4%)
profiling	15.509 s [15.509 s, 15.509 s]	721.0 ms (4.9%)
tracing	14.961 s [14.961 s, 14.961 s]	173.0 ms (1.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.448 s [15.448 s, 15.448 s]	-
appsec	14.902 s [14.902 s, 14.902 s]	-546.0 ms (-3.5%)
iast	18.516 s [18.516 s, 18.516 s]	3.068 s (19.9%)
iast_GLOBAL	17.952 s [17.952 s, 17.952 s]	2.504 s (16.2%)
profiling	15.384 s [15.384 s, 15.384 s]	-64.0 ms (-0.4%)
tracing	14.766 s [14.766 s, 14.766 s]	-682.0 ms (-4.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fc22174c46, baseline=1.55.0-SNAPSHOT~2e46666c2f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.731 ms) : 3511, 3950
.   : milestone, 3731,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.255 ms) : 2192, 2319
.   : milestone, 2255,
profiling (2.057 ms) : 2005, 2108
.   : milestone, 2057,
tracing (2.025 ms) : 1976, 2074
.   : milestone, 2025,
section candidate
no_agent (1.488 ms) : 1476, 1500
.   : milestone, 1488,
appsec (3.722 ms) : 3503, 3941
.   : milestone, 3722,
iast (2.22 ms) : 2156, 2283
.   : milestone, 2220,
iast_GLOBAL (2.262 ms) : 2198, 2326
.   : milestone, 2262,
profiling (2.09 ms) : 2037, 2142
.   : milestone, 2090,
tracing (2.034 ms) : 1985, 2084
.   : milestone, 2034,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.731 ms [3.511 ms, 3.95 ms]	2.252 ms (152.2%)
iast	2.21 ms [2.147 ms, 2.273 ms]	731.068 µs (49.4%)
iast_GLOBAL	2.255 ms [2.192 ms, 2.319 ms]	776.286 µs (52.5%)
profiling	2.057 ms [2.005 ms, 2.108 ms]	577.413 µs (39.0%)
tracing	2.025 ms [1.976 ms, 2.074 ms]	546.047 µs (36.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.488 ms [1.476 ms, 1.5 ms]	-
appsec	3.722 ms [3.503 ms, 3.941 ms]	2.234 ms (150.1%)
iast	2.22 ms [2.156 ms, 2.283 ms]	731.745 µs (49.2%)
iast_GLOBAL	2.262 ms [2.198 ms, 2.326 ms]	774.002 µs (52.0%)
profiling	2.09 ms [2.037 ms, 2.142 ms]	601.621 µs (40.4%)
tracing	2.034 ms [1.985 ms, 2.084 ms]	546.239 µs (36.7%)

vandonr · 2025-10-16T15:26:52Z

dd-java-agent/instrumentation/jdbc/src/test/groovy/JDBCInstrumentationTestBase.groovy

          errored false
          measured true
          tags {
+            "$Tags.PEER_HOSTNAME" "localhost"


because of the fix, the url that is "testdb://localhost" now gets correctly parsed, which is used to fill the peer.hostname

This reverts commit b776e20.

This reverts commit f992419.

fix generic url parsing in jdbc instrumentation

beb5d2b

vandonr requested a review from a team as a code owner October 16, 2025 13:30

vandonr requested a review from dougqh October 16, 2025 13:30

vandonr added type: bug Bug report and fix inst: jdbc JDBC instrumentation labels Oct 16, 2025

vandonr commented Oct 16, 2025

View reviewed changes

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

...trap/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java Show resolved Hide resolved

add test

f992419

vandonr requested a review from a team as a code owner October 16, 2025 13:42

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

amarziali approved these changes Oct 16, 2025

View reviewed changes

extract DBM specific test to a different class

b776e20

AlexeyKuznetsov-DD approved these changes Oct 16, 2025

View reviewed changes

fix existing test that was not asserting the correct thing

de2a6c3

vandonr commented Oct 16, 2025

View reviewed changes

vandonr added 3 commits October 16, 2025 17:37

just realized there was already a test on this that I could reuse

0d5b2e4

Revert "extract DBM specific test to a different class"

dbc4226

This reverts commit b776e20.

Revert "add test"

807915d

This reverts commit f992419.

vandonr enabled auto-merge (squash) October 16, 2025 15:41

fix other test

8a4ac88

bric3 approved these changes Oct 17, 2025

View reviewed changes

vandonr added 3 commits October 20, 2025 12:45

fix lasts tests

45b635c

Merge branch 'master' into vandonr/fix

2465781

Merge branch 'master' into vandonr/fix

fc22174

vandonr merged commit d7fd7ac into master Oct 21, 2025
535 checks passed

vandonr deleted the vandonr/fix branch October 21, 2025 10:52

github-actions bot added this to the 1.55.0 milestone Oct 21, 2025

PerfectSlayer changed the title ~~fix generic url parsing in jdbc instrumentation~~ Fix generic url parsing in jdbc instrumentation Oct 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix generic url parsing in jdbc instrumentation#9777

Fix generic url parsing in jdbc instrumentation#9777
vandonr merged 11 commits intomasterfrom
vandonr/fix

vandonr commented Oct 16, 2025

Uh oh!

vandonr Oct 16, 2025

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

amarziali left a comment

Uh oh!

pr-commenter bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

vandonr Oct 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -870,7 +870,7 @@ public static DBInfo parse(String connectionUrl, final Properties props) {
		// Delegate to specific parser
		return typeParsers.get(baseType).doParse(jdbcUrl, parsedProps).build();

Conversation

vandonr commented Oct 16, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

vandonr Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

vandonr Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlexeyKuznetsov-DD Oct 16, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Oct 16, 2025 •

edited

Loading

pr-commenter bot commented Oct 16, 2025 •

edited

Loading