Rename request body sample rate config variable by manuel-alvarez-alvarez · Pull Request #9791 · DataDog/dd-trace-java

manuel-alvarez-alvarez · 2025-10-17T10:22:17Z

What Does This Do

Renames the sample rate config variable from api-security.downstream.request.analysis.sample_rate to api-security.downstream.request.body.analysis.sample_rate.

Motivation

Due to an issue in the RFC, both variable names were listed. Tracers should use api-security.downstream.request.body.analysis.sample_rate.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

jandro996

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

datadog-official · 2025-10-17T10:40:54Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.69% (-0.00%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a38383e | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-17T11:36:04Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1762094315	1762131398
git_commit_sha	`d3a0f11`	`a38383e`
release_version	1.55.0-SNAPSHOT~d3a0f11a5c	1.55.0-SNAPSHOT~a38383e40d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762133184	1762133184
ci_job_id	1211083896	1211083896
ci_pipeline_id	81003829	81003829
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-e6gutwfa 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-e6gutwfa 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028597
Total [baseline] (8.67 s) : 0, 8669963
Agent [candidate] (1.029 s) : 0, 1028744
Total [candidate] (8.631 s) : 0, 8630992
section iast
Agent [baseline] (1.169 s) : 0, 1169366
Total [baseline] (9.392 s) : 0, 9392307
Agent [candidate] (1.16 s) : 0, 1159646
Total [candidate] (9.343 s) : 0, 9343413

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	iast	1.169 s	140.769 ms (13.7%)
Total	tracing	8.67 s	-
Total	iast	9.392 s	722.344 ms (8.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	iast	1.16 s	130.902 ms (12.7%)
Total	tracing	8.631 s	-
Total	iast	9.343 s	712.421 ms (8.3%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (702.53 ms) : 0, 702530
BytebuddyAgent [candidate] (701.363 ms) : 0, 701363
GlobalTracer [baseline] (244.091 ms) : 0, 244091
GlobalTracer [candidate] (244.576 ms) : 0, 244576
AppSec [baseline] (32.256 ms) : 0, 32256
AppSec [candidate] (32.18 ms) : 0, 32180
Debugger [baseline] (6.324 ms) : 0, 6324
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (684.869 µs) : 0, 685
Remote Config [candidate] (684.689 µs) : 0, 685
Telemetry [baseline] (13.587 ms) : 0, 13587
Telemetry [candidate] (14.588 ms) : 0, 14588
Flare Poller [baseline] (6.615 ms) : 0, 6615
Flare Poller [candidate] (6.514 ms) : 0, 6514
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (830.629 ms) : 0, 830629
BytebuddyAgent [candidate] (822.512 ms) : 0, 822512
GlobalTracer [baseline] (235.05 ms) : 0, 235050
GlobalTracer [candidate] (233.639 ms) : 0, 233639
IAST [baseline] (32.651 ms) : 0, 32651
IAST [candidate] (32.648 ms) : 0, 32648
AppSec [baseline] (28.768 ms) : 0, 28768
AppSec [candidate] (28.715 ms) : 0, 28715
Debugger [baseline] (6.146 ms) : 0, 6146
Debugger [candidate] (6.173 ms) : 0, 6173
Remote Config [baseline] (613.393 µs) : 0, 613
Remote Config [candidate] (600.318 µs) : 0, 600
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (8.505 ms) : 0, 8505
Flare Poller [baseline] (4.114 ms) : 0, 4114
Flare Poller [candidate] (4.17 ms) : 0, 4170

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1035546
Total [baseline] (10.948 s) : 0, 10947877
Agent [candidate] (1.029 s) : 0, 1028575
Total [candidate] (10.89 s) : 0, 10889631
section appsec
Agent [baseline] (1.201 s) : 0, 1201036
Total [baseline] (10.919 s) : 0, 10919056
Agent [candidate] (1.201 s) : 0, 1201140
Total [candidate] (10.922 s) : 0, 10921578
section iast
Agent [baseline] (1.18 s) : 0, 1179813
Total [baseline] (11.126 s) : 0, 11125666
Agent [candidate] (1.158 s) : 0, 1157888
Total [candidate] (11.053 s) : 0, 11052730
section profiling
Agent [baseline] (1.173 s) : 0, 1172904
Total [baseline] (10.914 s) : 0, 10914072
Agent [candidate] (1.179 s) : 0, 1179346
Total [candidate] (10.912 s) : 0, 10912061

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.036 s	-
Agent	appsec	1.201 s	165.49 ms (16.0%)
Agent	iast	1.18 s	144.267 ms (13.9%)
Agent	profiling	1.173 s	137.358 ms (13.3%)
Total	tracing	10.948 s	-
Total	appsec	10.919 s	-28.822 ms (-0.3%)
Total	iast	11.126 s	177.789 ms (1.6%)
Total	profiling	10.914 s	-33.805 ms (-0.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.201 s	172.565 ms (16.8%)
Agent	iast	1.158 s	129.313 ms (12.6%)
Agent	profiling	1.179 s	150.771 ms (14.7%)
Total	tracing	10.89 s	-
Total	appsec	10.922 s	31.948 ms (0.3%)
Total	iast	11.053 s	163.1 ms (1.5%)
Total	profiling	10.912 s	22.43 ms (0.2%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (706.774 ms) : 0, 706774
BytebuddyAgent [candidate] (700.951 ms) : 0, 700951
GlobalTracer [baseline] (246.015 ms) : 0, 246015
GlobalTracer [candidate] (244.812 ms) : 0, 244812
AppSec [baseline] (32.617 ms) : 0, 32617
AppSec [candidate] (32.248 ms) : 0, 32248
Debugger [baseline] (6.453 ms) : 0, 6453
Debugger [candidate] (6.353 ms) : 0, 6353
Remote Config [baseline] (676.404 µs) : 0, 676
Remote Config [candidate] (669.079 µs) : 0, 669
Telemetry [baseline] (13.674 ms) : 0, 13674
Telemetry [candidate] (14.522 ms) : 0, 14522
Flare Poller [baseline] (6.569 ms) : 0, 6569
Flare Poller [candidate] (6.426 ms) : 0, 6426
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (725.171 ms) : 0, 725171
BytebuddyAgent [candidate] (725.456 ms) : 0, 725456
GlobalTracer [baseline] (235.517 ms) : 0, 235517
GlobalTracer [candidate] (235.625 ms) : 0, 235625
IAST [baseline] (24.971 ms) : 0, 24971
IAST [candidate] (25.016 ms) : 0, 25016
AppSec [baseline] (174.011 ms) : 0, 174011
AppSec [candidate] (173.776 ms) : 0, 173776
Debugger [baseline] (5.913 ms) : 0, 5913
Debugger [candidate] (5.892 ms) : 0, 5892
Remote Config [baseline] (627.575 µs) : 0, 628
Remote Config [candidate] (624.553 µs) : 0, 625
Telemetry [baseline] (8.38 ms) : 0, 8380
Telemetry [candidate] (8.329 ms) : 0, 8329
Flare Poller [baseline] (3.895 ms) : 0, 3895
Flare Poller [candidate] (3.842 ms) : 0, 3842
section iast
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (839.633 ms) : 0, 839633
BytebuddyAgent [candidate] (821.045 ms) : 0, 821045
GlobalTracer [baseline] (235.378 ms) : 0, 235378
GlobalTracer [candidate] (233.251 ms) : 0, 233251
IAST [baseline] (32.85 ms) : 0, 32850
IAST [candidate] (31.846 ms) : 0, 31846
AppSec [baseline] (29.025 ms) : 0, 29025
AppSec [candidate] (29.726 ms) : 0, 29726
Debugger [baseline] (6.224 ms) : 0, 6224
Debugger [candidate] (6.09 ms) : 0, 6090
Remote Config [baseline] (610.263 µs) : 0, 610
Remote Config [candidate] (606.58 µs) : 0, 607
Telemetry [baseline] (8.711 ms) : 0, 8711
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (4.15 ms) : 0, 4150
Flare Poller [candidate] (4.159 ms) : 0, 4159
section profiling
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (726.307 ms) : 0, 726307
BytebuddyAgent [candidate] (731.547 ms) : 0, 731547
GlobalTracer [baseline] (220.166 ms) : 0, 220166
GlobalTracer [candidate] (220.863 ms) : 0, 220863
AppSec [baseline] (32.258 ms) : 0, 32258
AppSec [candidate] (33.148 ms) : 0, 33148
Debugger [baseline] (11.468 ms) : 0, 11468
Debugger [candidate] (10.506 ms) : 0, 10506
Remote Config [baseline] (728.464 µs) : 0, 728
Remote Config [candidate] (683.278 µs) : 0, 683
Telemetry [baseline] (11.412 ms) : 0, 11412
Telemetry [candidate] (11.366 ms) : 0, 11366
Flare Poller [baseline] (4.116 ms) : 0, 4116
Flare Poller [candidate] (4.149 ms) : 0, 4149
ProfilingAgent [baseline] (109.498 ms) : 0, 109498
ProfilingAgent [candidate] (109.868 ms) : 0, 109868
Profiling [baseline] (110.139 ms) : 0, 110139
Profiling [candidate] (110.55 ms) : 0, 110550

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1762094315	1762131398
git_commit_sha	`d3a0f11`	`a38383e`
release_version	1.55.0-SNAPSHOT~d3a0f11a5c	1.55.0-SNAPSHOT~a38383e40d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762133675	1762133675
ci_job_id	1211083897	1211083897
ci_pipeline_id	81003829	81003829
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-cbd17bep 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-cbd17bep 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+327.244µs; +370.476µs] or [+16.307%; +18.461%]	unstable [-587.248op/s; -59.814op/s] or [-26.106%; -2.659%]	2.356ms	1925.906op/s	2.007ms	2249.438op/s
scenario:load:insecure-bank:iast:high_load	better [-209.668µs; -117.832µs] or [-6.405%; -3.600%]	unstable [-97.983op/s; +240.671op/s] or [-7.008%; +17.213%]	3.110ms	1469.531op/s	3.274ms	1398.188op/s
scenario:load:insecure-bank:iast_FULL:high_load	better [-264.583µs; -139.812µs] or [-4.491%; -2.373%]	unstable [-63.578op/s; +118.515op/s] or [-8.101%; +15.102%]	5.690ms	812.250op/s	5.892ms	784.781op/s
scenario:load:insecure-bank:tracing:high_load	worse [+62.188µs; +94.177µs] or [+3.494%; +5.292%]	unstable [-405.814op/s; +201.439op/s] or [-16.074%; +7.979%]	1.858ms	2422.406op/s	1.780ms	2524.594op/s
scenario:load:petclinic:tracing:high_load	worse [+1.457ms; +1.852ms] or [+8.277%; +10.519%]	unstable [-50.183op/s; +4.870op/s] or [-18.932%; +1.837%]	19.256ms	242.406op/s	17.602ms	265.062op/s
scenario:load:petclinic:code_origins:high_load	worse [+0.794ms; +1.210ms] or [+4.283%; +6.524%]	unstable [-40.096op/s; +14.596op/s] or [-15.935%; +5.801%]	19.546ms	238.875op/s	18.544ms	251.625op/s
scenario:load:petclinic:appsec:high_load	worse [+0.810ms; +1.248ms] or [+4.152%; +6.395%]	unstable [-37.944op/s; +13.882op/s] or [-15.851%; +5.799%]	20.537ms	227.344op/s	19.508ms	239.375op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
.   : milestone, 1206,
iast (3.274 ms) : 3228, 3319
.   : milestone, 3274,
iast_FULL (5.892 ms) : 5833, 5951
.   : milestone, 5892,
iast_GLOBAL (3.596 ms) : 3545, 3648
.   : milestone, 3596,
profiling (2.007 ms) : 1990, 2024
.   : milestone, 2007,
tracing (1.78 ms) : 1765, 1794
.   : milestone, 1780,
section candidate
no_agent (1.212 ms) : 1201, 1224
.   : milestone, 1212,
iast (3.11 ms) : 3070, 3150
.   : milestone, 3110,
iast_FULL (5.69 ms) : 5633, 5746
.   : milestone, 5690,
iast_GLOBAL (3.619 ms) : 3564, 3673
.   : milestone, 3619,
profiling (2.356 ms) : 2333, 2378
.   : milestone, 2356,
tracing (1.858 ms) : 1842, 1873
.   : milestone, 1858,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.206 ms [1.194 ms, 1.218 ms]	-
iast	3.274 ms [3.228 ms, 3.319 ms]	2.068 ms (171.4%)
iast_FULL	5.892 ms [5.833 ms, 5.951 ms]	4.686 ms (388.5%)
iast_GLOBAL	3.596 ms [3.545 ms, 3.648 ms]	2.39 ms (198.2%)
profiling	2.007 ms [1.99 ms, 2.024 ms]	800.808 µs (66.4%)
tracing	1.78 ms [1.765 ms, 1.794 ms]	573.682 µs (47.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.212 ms [1.201 ms, 1.224 ms]	-
iast	3.11 ms [3.07 ms, 3.15 ms]	1.897 ms (156.5%)
iast_FULL	5.69 ms [5.633 ms, 5.746 ms]	4.477 ms (369.3%)
iast_GLOBAL	3.619 ms [3.564 ms, 3.673 ms]	2.406 ms (198.5%)
profiling	2.356 ms [2.333 ms, 2.378 ms]	1.143 ms (94.3%)
tracing	1.858 ms [1.842 ms, 1.873 ms]	645.506 µs (53.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.271 ms) : 18083, 18459
.   : milestone, 18271,
appsec (19.508 ms) : 19312, 19704
.   : milestone, 19508,
code_origins (18.544 ms) : 18354, 18733
.   : milestone, 18544,
iast (19.694 ms) : 19498, 19891
.   : milestone, 19694,
profiling (20.72 ms) : 20512, 20928
.   : milestone, 20720,
tracing (17.602 ms) : 17426, 17778
.   : milestone, 17602,
section candidate
no_agent (18.541 ms) : 18347, 18734
.   : milestone, 18541,
appsec (20.537 ms) : 20327, 20747
.   : milestone, 20537,
code_origins (19.546 ms) : 19349, 19742
.   : milestone, 19546,
iast (19.638 ms) : 19442, 19834
.   : milestone, 19638,
profiling (20.386 ms) : 20180, 20591
.   : milestone, 20386,
tracing (19.256 ms) : 19066, 19447
.   : milestone, 19256,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.271 ms [18.083 ms, 18.459 ms]	-
appsec	19.508 ms [19.312 ms, 19.704 ms]	1.237 ms (6.8%)
code_origins	18.544 ms [18.354 ms, 18.733 ms]	272.69 µs (1.5%)
iast	19.694 ms [19.498 ms, 19.891 ms]	1.424 ms (7.8%)
profiling	20.72 ms [20.512 ms, 20.928 ms]	2.449 ms (13.4%)
tracing	17.602 ms [17.426 ms, 17.778 ms]	-668.854 µs (-3.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.541 ms [18.347 ms, 18.734 ms]	-
appsec	20.537 ms [20.327 ms, 20.747 ms]	1.996 ms (10.8%)
code_origins	19.546 ms [19.349 ms, 19.742 ms]	1.005 ms (5.4%)
iast	19.638 ms [19.442 ms, 19.834 ms]	1.097 ms (5.9%)
profiling	20.386 ms [20.18 ms, 20.591 ms]	1.845 ms (10.0%)
tracing	19.256 ms [19.066 ms, 19.447 ms]	715.754 µs (3.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1762094315	1762131398
git_commit_sha	`d3a0f11`	`a38383e`
release_version	1.55.0-SNAPSHOT~d3a0f11a5c	1.55.0-SNAPSHOT~a38383e40d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762133417	1762133417
ci_job_id	1211083898	1211083898
ci_pipeline_id	81003829	81003829
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-5rc33vrs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-5rc33vrs 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.455 ms) : 2403, 2506
.   : milestone, 2455,
iast (2.214 ms) : 2151, 2278
.   : milestone, 2214,
iast_GLOBAL (2.251 ms) : 2187, 2315
.   : milestone, 2251,
profiling (2.055 ms) : 2003, 2106
.   : milestone, 2055,
tracing (2.021 ms) : 1971, 2071
.   : milestone, 2021,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (3.736 ms) : 3517, 3954
.   : milestone, 3736,
iast (2.213 ms) : 2149, 2277
.   : milestone, 2213,
iast_GLOBAL (2.259 ms) : 2195, 2324
.   : milestone, 2259,
profiling (2.045 ms) : 1994, 2096
.   : milestone, 2045,
tracing (2.016 ms) : 1967, 2066
.   : milestone, 2016,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.455 ms [2.403 ms, 2.506 ms]	982.714 µs (66.8%)
iast	2.214 ms [2.151 ms, 2.278 ms]	742.495 µs (50.4%)
iast_GLOBAL	2.251 ms [2.187 ms, 2.315 ms]	779.428 µs (53.0%)
profiling	2.055 ms [2.003 ms, 2.106 ms]	582.796 µs (39.6%)
tracing	2.021 ms [1.971 ms, 2.071 ms]	549.246 µs (37.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	3.736 ms [3.517 ms, 3.954 ms]	2.259 ms (153.0%)
iast	2.213 ms [2.149 ms, 2.277 ms]	736.738 µs (49.9%)
iast_GLOBAL	2.259 ms [2.195 ms, 2.324 ms]	782.775 µs (53.0%)
profiling	2.045 ms [1.994 ms, 2.096 ms]	568.239 µs (38.5%)
tracing	2.016 ms [1.967 ms, 2.066 ms]	539.881 µs (36.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a38383e40d, baseline=1.55.0-SNAPSHOT~d3a0f11a5c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.49 s) : 15490000, 15490000
.   : milestone, 15490000,
appsec (15.048 s) : 15048000, 15048000
.   : milestone, 15048000,
iast (18.566 s) : 18566000, 18566000
.   : milestone, 18566000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
.   : milestone, 18129000,
profiling (15.602 s) : 15602000, 15602000
.   : milestone, 15602000,
tracing (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
section candidate
no_agent (14.883 s) : 14883000, 14883000
.   : milestone, 14883000,
appsec (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
iast (18.465 s) : 18465000, 18465000
.   : milestone, 18465000,
iast_GLOBAL (18.21 s) : 18210000, 18210000
.   : milestone, 18210000,
profiling (15.254 s) : 15254000, 15254000
.   : milestone, 15254000,
tracing (15.201 s) : 15201000, 15201000
.   : milestone, 15201000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.49 s [15.49 s, 15.49 s]	-
appsec	15.048 s [15.048 s, 15.048 s]	-442.0 ms (-2.9%)
iast	18.566 s [18.566 s, 18.566 s]	3.076 s (19.9%)
iast_GLOBAL	18.129 s [18.129 s, 18.129 s]	2.639 s (17.0%)
profiling	15.602 s [15.602 s, 15.602 s]	112.0 ms (0.7%)
tracing	15.172 s [15.172 s, 15.172 s]	-318.0 ms (-2.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.883 s [14.883 s, 14.883 s]	-
appsec	15.194 s [15.194 s, 15.194 s]	311.0 ms (2.1%)
iast	18.465 s [18.465 s, 18.465 s]	3.582 s (24.1%)
iast_GLOBAL	18.21 s [18.21 s, 18.21 s]	3.327 s (22.4%)
profiling	15.254 s [15.254 s, 15.254 s]	371.0 ms (2.5%)
tracing	15.201 s [15.201 s, 15.201 s]	318.0 ms (2.1%)

manuel-alvarez-alvarez · 2025-10-17T13:41:03Z

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

Yeah, I added an alias to keep both for a while, thanks!

internal-api/src/main/java/datadog/trace/api/Config.java

jandro996

Please take a look at the change I suggested since I think it’s relevant. Anyway, I’m approving them so I don’t block you until Wednesday :)

manuel-alvarez-alvarez requested review from a team as code owners October 17, 2025 10:22

manuel-alvarez-alvarez added type: bug Bug report and fix comp: asm waf Application Security Management (WAF) labels Oct 17, 2025

manuel-alvarez-alvarez requested review from jandro996, sezen-datadog and smola October 17, 2025 10:22

jandro996 reviewed Oct 17, 2025

View reviewed changes

Base automatically changed from malvarez/waf-fix-ssrf-blocking-exception to master October 17, 2025 13:16

manuel-alvarez-alvarez requested a review from a team as a code owner October 17, 2025 13:16

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from 6acbb27 to 4a5648d Compare October 17, 2025 13:36

manuel-alvarez-alvarez requested a review from jandro996 October 17, 2025 13:41

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from ec39cb6 to 4cc6b68 Compare October 21, 2025 07:52

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from 34aa1f7 to 7162f2d Compare October 30, 2025 20:12

manuel-alvarez-alvarez requested a review from a team as a code owner October 31, 2025 08:50

manuel-alvarez-alvarez requested review from PerfectSlayer and removed request for a team October 31, 2025 08:50

jandro996 reviewed Nov 1, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Outdated Show resolved Hide resolved

jandro996 approved these changes Nov 1, 2025

View reviewed changes

manuel-alvarez-alvarez added 4 commits November 3, 2025 01:56

Rename request body sample rate config variable

89b7f0b

Maintain old variable for a bit

ba2d2ab

Add variable to supported configurations

6c295b0

Fix alias

a38383e

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch from 42ede4e to a38383e Compare November 3, 2025 00:56

manuel-alvarez-alvarez merged commit 96d5ea2 into master Nov 3, 2025
539 checks passed

manuel-alvarez-alvarez deleted the malvarez/fix-api10-sampling-config branch November 3, 2025 09:29

github-actions bot added this to the 1.55.0 milestone Nov 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename request body sample rate config variable#9791

Rename request body sample rate config variable#9791
manuel-alvarez-alvarez merged 4 commits intomasterfrom
malvarez/fix-api10-sampling-config

manuel-alvarez-alvarez commented Oct 17, 2025 •

edited

Loading

Uh oh!

jandro996 left a comment

Uh oh!

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez commented Oct 17, 2025

Uh oh!

Uh oh!

jandro996 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

manuel-alvarez-alvarez commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-official bot commented Oct 17, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez commented Oct 17, 2025

Uh oh!

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manuel-alvarez-alvarez commented Oct 17, 2025 •

edited

Loading

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Oct 17, 2025 •

edited

Loading