Make Code Origin for Spans default on#9873
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 7beade4 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 10 performance improvements and 7 performance regressions! Performance is the same for 33 metrics, 15 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051195
Total [baseline] (8.651 s) : 0, 8651309
Agent [candidate] (1.101 s) : 0, 1101089
Total [candidate] (8.813 s) : 0, 8812775
section iast
Agent [baseline] (1.182 s) : 0, 1181859
Total [baseline] (9.281 s) : 0, 9280871
Agent [candidate] (1.244 s) : 0, 1244234
Total [candidate] (9.542 s) : 0, 9541516
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (707.259 ms) : 0, 707259
BytebuddyAgent [candidate] (705.995 ms) : 0, 705995
GlobalTracer [baseline] (246.729 ms) : 0, 246729
GlobalTracer [candidate] (245.094 ms) : 0, 245094
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.27 ms) : 0, 32270
Debugger [baseline] (6.376 ms) : 0, 6376
Debugger [candidate] (68.466 ms) : 0, 68466
Remote Config [baseline] (713.743 µs) : 0, 714
Remote Config [candidate] (654.381 µs) : 0, 654
Telemetry [baseline] (14.814 ms) : 0, 14814
Telemetry [candidate] (8.728 ms) : 0, 8728
Flare Poller [baseline] (6.549 ms) : 0, 6549
Flare Poller [candidate] (3.696 ms) : 0, 3696
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (829.416 ms) : 0, 829416
BytebuddyAgent [candidate] (833.306 ms) : 0, 833306
GlobalTracer [baseline] (235.159 ms) : 0, 235159
GlobalTracer [candidate] (235.348 ms) : 0, 235348
AppSec [baseline] (29.85 ms) : 0, 29850
AppSec [candidate] (31.517 ms) : 0, 31517
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (65.261 ms) : 0, 65261
Remote Config [baseline] (603.957 µs) : 0, 604
Remote Config [candidate] (557.645 µs) : 0, 558
Telemetry [baseline] (8.578 ms) : 0, 8578
Telemetry [candidate] (8.195 ms) : 0, 8195
Flare Poller [baseline] (4.164 ms) : 0, 4164
Flare Poller [candidate] (3.572 ms) : 0, 3572
IAST [baseline] (31.784 ms) : 0, 31784
IAST [candidate] (30.075 ms) : 0, 30075
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052322
Total [baseline] (10.868 s) : 0, 10867661
Agent [candidate] (1.104 s) : 0, 1104459
Total [candidate] (10.755 s) : 0, 10755298
section appsec
Agent [baseline] (1.23 s) : 0, 1230362
Total [baseline] (10.962 s) : 0, 10962023
Agent [candidate] (1.286 s) : 0, 1286458
Total [candidate] (11.119 s) : 0, 11118581
section iast
Agent [baseline] (1.18 s) : 0, 1180337
Total [baseline] (11.138 s) : 0, 11138098
Agent [candidate] (1.242 s) : 0, 1241856
Total [candidate] (11.18 s) : 0, 11179911
section profiling
Agent [baseline] (1.193 s) : 0, 1193051
Total [baseline] (10.96 s) : 0, 10960208
Agent [candidate] (1.24 s) : 0, 1239799
Total [candidate] (11.121 s) : 0, 11120552
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (708.571 ms) : 0, 708571
BytebuddyAgent [candidate] (707.533 ms) : 0, 707533
GlobalTracer [baseline] (246.875 ms) : 0, 246875
GlobalTracer [candidate] (245.964 ms) : 0, 245964
AppSec [baseline] (32.605 ms) : 0, 32605
AppSec [candidate] (32.365 ms) : 0, 32365
Debugger [baseline] (6.442 ms) : 0, 6442
Debugger [candidate] (69.374 ms) : 0, 69374
Remote Config [baseline] (731.168 µs) : 0, 731
Remote Config [candidate] (660.981 µs) : 0, 661
Telemetry [baseline] (11.693 ms) : 0, 11693
Telemetry [candidate] (8.609 ms) : 0, 8609
Flare Poller [baseline] (9.018 ms) : 0, 9018
Flare Poller [candidate] (3.676 ms) : 0, 3676
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (734.154 ms) : 0, 734154
BytebuddyAgent [candidate] (735.318 ms) : 0, 735318
GlobalTracer [baseline] (239.15 ms) : 0, 239150
GlobalTracer [candidate] (239.278 ms) : 0, 239278
AppSec [baseline] (175.97 ms) : 0, 175970
AppSec [candidate] (175.603 ms) : 0, 175603
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (61.154 ms) : 0, 61154
Remote Config [baseline] (659.736 µs) : 0, 660
Remote Config [candidate] (642.19 µs) : 0, 642
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (9.07 ms) : 0, 9070
Flare Poller [baseline] (4.071 ms) : 0, 4071
Flare Poller [candidate] (3.771 ms) : 0, 3771
IAST [baseline] (25.107 ms) : 0, 25107
IAST [candidate] (25.157 ms) : 0, 25157
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (828.582 ms) : 0, 828582
BytebuddyAgent [candidate] (829.272 ms) : 0, 829272
GlobalTracer [baseline] (234.899 ms) : 0, 234899
GlobalTracer [candidate] (235.495 ms) : 0, 235495
AppSec [baseline] (30.587 ms) : 0, 30587
AppSec [candidate] (30.831 ms) : 0, 30831
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (66.695 ms) : 0, 66695
Remote Config [baseline] (608.62 µs) : 0, 609
Remote Config [candidate] (557.032 µs) : 0, 557
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.268 ms) : 0, 8268
Flare Poller [baseline] (4.132 ms) : 0, 4132
Flare Poller [candidate] (3.609 ms) : 0, 3609
IAST [baseline] (30.791 ms) : 0, 30791
IAST [candidate] (30.926 ms) : 0, 30926
section profiling
ProfilingAgent [baseline] (111.182 ms) : 0, 111182
ProfilingAgent [candidate] (96.682 ms) : 0, 96682
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (728.387 ms) : 0, 728387
BytebuddyAgent [candidate] (734.809 ms) : 0, 734809
GlobalTracer [baseline] (222.099 ms) : 0, 222099
GlobalTracer [candidate] (223.446 ms) : 0, 223446
AppSec [baseline] (32.232 ms) : 0, 32232
AppSec [candidate] (32.566 ms) : 0, 32566
Debugger [baseline] (7.556 ms) : 0, 7556
Debugger [candidate] (68.291 ms) : 0, 68291
Remote Config [baseline] (687.592 µs) : 0, 688
Remote Config [candidate] (651.212 µs) : 0, 651
Telemetry [baseline] (15.59 ms) : 0, 15590
Telemetry [candidate] (8.024 ms) : 0, 8024
Flare Poller [baseline] (4.136 ms) : 0, 4136
Flare Poller [candidate] (3.799 ms) : 0, 3799
Profiling [baseline] (111.862 ms) : 0, 111862
Profiling [candidate] (97.259 ms) : 0, 97259
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (19.414 ms) : 19212, 19615
. : milestone, 19414,
appsec (19.911 ms) : 19704, 20117
. : milestone, 19911,
code_origins (17.526 ms) : 17354, 17699
. : milestone, 17526,
iast (17.996 ms) : 17816, 18176
. : milestone, 17996,
profiling (18.527 ms) : 18343, 18711
. : milestone, 18527,
tracing (17.895 ms) : 17717, 18073
. : milestone, 17895,
section candidate
no_agent (17.995 ms) : 17815, 18176
. : milestone, 17995,
appsec (18.736 ms) : 18547, 18926
. : milestone, 18736,
code_origins (17.819 ms) : 17641, 17997
. : milestone, 17819,
iast (17.757 ms) : 17578, 17937
. : milestone, 17757,
profiling (18.464 ms) : 18275, 18652
. : milestone, 18464,
tracing (18.01 ms) : 17828, 18193
. : milestone, 18010,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1197
. : milestone, 1186,
iast (3.299 ms) : 3251, 3347
. : milestone, 3299,
iast_FULL (5.464 ms) : 5409, 5518
. : milestone, 5464,
iast_GLOBAL (3.524 ms) : 3474, 3574
. : milestone, 3524,
profiling (2.092 ms) : 2073, 2111
. : milestone, 2092,
tracing (1.805 ms) : 1790, 1821
. : milestone, 1805,
section candidate
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.241 ms) : 3200, 3282
. : milestone, 3241,
iast_FULL (5.983 ms) : 5923, 6044
. : milestone, 5983,
iast_GLOBAL (3.743 ms) : 3649, 3837
. : milestone, 3743,
profiling (2.162 ms) : 2143, 2182
. : milestone, 2162,
tracing (1.815 ms) : 1799, 1831
. : milestone, 1815,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.704 ms) : 3486, 3922
. : milestone, 3704,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.257 ms) : 2193, 2320
. : milestone, 2257,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.026 ms) : 1977, 2075
. : milestone, 2026,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.714 ms) : 3495, 3932
. : milestone, 3714,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.254 ms) : 2190, 2317
. : milestone, 2254,
profiling (2.058 ms) : 2007, 2109
. : milestone, 2058,
tracing (2.033 ms) : 1983, 2082
. : milestone, 2033,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7beade4bca, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (14.811 s) : 14811000, 14811000
. : milestone, 14811000,
appsec (14.809 s) : 14809000, 14809000
. : milestone, 14809000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (17.86 s) : 17860000, 17860000
. : milestone, 17860000,
profiling (15.813 s) : 15813000, 15813000
. : milestone, 15813000,
tracing (14.829 s) : 14829000, 14829000
. : milestone, 14829000,
section candidate
no_agent (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
appsec (14.628 s) : 14628000, 14628000
. : milestone, 14628000,
iast (18.605 s) : 18605000, 18605000
. : milestone, 18605000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
profiling (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
tracing (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
|
d56be96 to
3ff89a2
Compare
8dddbde to
778754a
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
778754a to
24b88d7
Compare
ad98e42 to
71e7de7
Compare
mcculls
left a comment
There was a problem hiding this comment.
Code changes look ok - just need some reassurance about the performance impact
by default Code Origin will be started
71e7de7 to
7beade4
Compare
|
@mcculls We have a link to the benchmarking results in https://datadoghq.atlassian.net/browse/DEBUG-4173, this is still a WIP but startup time, latency, memory, CPU all look nominal to move this to a default-on feature. We also have about 190 orgs using this in production today. |
What Does This Do
by default Code Origin will be started
Motivation
Additional Notes
This feature can be disabled by setting
DD_CODE_ORIGIN_FOR_SPANS_ENABLED=falseContributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4173