Skip to content

direct: fix sampling and visibility issues with new direct client#249

Merged
iksaif merged 1 commit intomasterfrom
corentin.chary/fix-distrib-sampling
May 30, 2024
Merged

direct: fix sampling and visibility issues with new direct client#249
iksaif merged 1 commit intomasterfrom
corentin.chary/fix-distrib-sampling

Conversation

@iksaif
Copy link
Contributor

@iksaif iksaif commented May 30, 2024

  • sampling should always be disabled for distribution values with the direct client this is the whole point of being able to send multiple distribution values at once
  • don't make the direct client final, users might need to have to extend it (same for the noop client)

- sampling should always be disabled for distribution values with the direct client
  this is the whole point of being able to send multiple distribution values at once
- don't make the direct client final, users might need to have to extend it (same
  for the noop client)
@iksaif iksaif requested a review from a team May 30, 2024 11:24
@iksaif iksaif merged commit 59f96a2 into master May 30, 2024
@iksaif iksaif deleted the corentin.chary/fix-distrib-sampling branch May 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants