Conversation
Contributor
|
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
702725a to
a0d07f9
Compare
76c46d3 to
dcc8730
Compare
r1viollet
reviewed
Dec 5, 2024
| @Override | ||
| protected void withTestAssumptions() { | ||
| // vmstructs based stackwalking will throw ISE on Java 23 | ||
| Assumptions.assumeFalse(Platform.isJavaVersionAtLeast(23)); |
Contributor
There was a problem hiding this comment.
I assume we do not use vmstructs for now on 23. Happy to talk more about this.
r1viollet
approved these changes
Dec 5, 2024
Contributor
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
I'm especially happy about the arm tests we are adding
MattAlp
reviewed
Dec 5, 2024
|
|
||
| void StackFrame::adjustCompiled(NMethod *nm, const void *pc, uintptr_t &sp) { | ||
| bool StackFrame::unwindAtomicStub(const void*& pc) { | ||
| // VM threads may call generated atomic stubs, which are not normally walkable |
Contributor
There was a problem hiding this comment.
LGTM, leaving comment here to refer back later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
It downstreams two aarch64 related fixes
Motivation:
Improving the aarch64 profiling stability
Additional Notes:
Additional aarch64 GHA runners were added. This also required some minor adjustments in the code to avoid crashes on those aarch64 runners (these things are most probably setup specific as I could not reproduce the problems on an aarch64 ec2 instance)
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!