Conversation
Skip zing and j9 flaky tests
Contributor
r1viollet
commented
Jul 7, 2025
| } | ||
| // Running vm stackwalker tests on JVMCI (Graal), JDK 24, aarch64 and with a sanitizer is crashing in a weird place | ||
| // This looks like the sanitizer instrumentation is breaking the longjump based crash recovery :( | ||
| assumeFalse(Platform.isJavaVersionAtLeast(24) && isJvmci && Platform.isAarch64() && cstack.startsWith("vm") && isSanitizer); |
Contributor
Author
There was a problem hiding this comment.
I don't understand the usage of assume here ?
we are triggering these tests here: https://github.com/DataDog/java-profiler/actions/runs/16116032610/job/45470209849?pr=238
Is this expected ?
Collaborator
There was a problem hiding this comment.
We are running on JDK 17 - one of the conditions is Java >=24
So yes. This is expected.
Contributor
|
🔧 Report generated by pr-comment-scanbuild |
jbachorik
reviewed
Jul 7, 2025
| boolean isSanitizer = config.endsWith("san"); | ||
| boolean isJvmci = System.getProperty("java.vm.version", "").contains("jvmci"); | ||
| assumeFalse(Platform.isZing() || Platform.isJ9()); | ||
| // Skip test entirely on unsupported JVMs (don't use assumeFalse which gets retried) |
Collaborator
There was a problem hiding this comment.
don't use assumeFalse which gets retried
Ouch. This should not be the case. I will take a look at the @TestTemplate engine ...
jbachorik
approved these changes
Jul 7, 2025
zhengyu123
pushed a commit
that referenced
this pull request
Jul 9, 2025
Skip zing and j9 flaky tests
zhengyu123
added a commit
that referenced
this pull request
Jul 9, 2025
* Potential memory leak with the JVMTI wallclock sampler * v1 * Don't sample terminated thread * v2 * v3 * v4 * Safe access * Fix thread state * v5 * Cleanup * Cleanup * safeFetch impl * jdk11 support * v6 * enhance and cleanup * fix nullptr deference * More cleanup * Erwan's finding * Fixed memory leak found by Erwan * [Automated] Bump dev version to 1.29.0 * Update the sonatype repos (#235) * Fix artifact download URL * Split debug (#233) * Split debug Add build steps to store split debug information for release builds * Add the micro-benchmark for thread filtering (#237) * Add the micro-benchmark for thread filtering * Do not test for obviously invalid thread id * Relax threadfilter mem order * Flaky test - j9 OSR (#239) Skip zing and j9 flaky tests * Fix flaky allocation test (#241) Lower threshold for allocation test * jbachorik's comments * More jbachorik's comments * Cleanup thread local references --------- Co-authored-by: zhengyu.gu <zhengyu.gu@servicenow.com> Co-authored-by: Datadog Java Profiler <java-profiler@datadoghq.com> Co-authored-by: Jaroslav Bachorik <jaroslav.bachorik@datadoghq.com> Co-authored-by: Jaroslav Bachorik <j.bachorik@gmail.com> Co-authored-by: r1viollet <74836499+r1viollet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Skip zing and j9 flaky tests
Motivation:
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!