Conversation
Clarify outputs for async-profiler checkout
|
🔧 Report generated by pr-comment-scanbuild |
020f9cc to
964e71f
Compare
jbachorik
left a comment
There was a problem hiding this comment.
Is it ok to run gtest only when testing Java?
You could then do linkDebug and get *.so file without running gtests. Is this the intention?
For CI I think this does make any difference - the gtests will run a bit later. For local dev, you can use -Pskip-gtest gradle paramater.
The rest of the changes looks good.
For me, it is more idiomatic to have tests run in the test step. I found it confusing to have always test that run at every build. Though I agree this is a matter of taste. |
964e71f to
82afa1e
Compare
It's mostly about whether we feel it is ok to be able get the library binary without going through the gtest by default. |
This avoids ownership issues in builds
…t/remove_gtest_during_build
|
I had issues with file ownership on some alpine builds. I'm not sure why I was the only one to see this. |
What does this PR do?:
Remove gtest during build
Clarify outputs for async-profiler check
Motivation:
Consecutive builds are faster
Additional Notes:
NA
How to test the change?:
We already call test commands which will run gtests
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!