fix(codecompanion): improve error handling for empty stderr output#286
Merged
Davidyz merged 3 commits intoDavidyz:mainfrom Sep 20, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 25 25
Lines 1838 1838
=======================================
Hits 1833 1833
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davidyz
requested changes
Sep 9, 2025
Owner
Davidyz
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Please review my comments (mostly about reusing code where possible) and lmk what you think about them. Happy to merge once we're in agreement about those.
- Enhanced flatten_table_to_string to filter out empty error messages
- Added logic to distinguish actual errors from empty stderr output
- Prevents false error reporting when VectorCode operations succeed but have no stderr
- Provides meaningful fallback error message for truly empty error conditions
- Fixes issue where successful operations with empty stderr were reported as { "" } errors
Resolves the confusing empty error message issue in CodeCompanion integration.
7f8cb1d to
744182d
Compare
Davidyz
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the confusing empty error message issue in CodeCompanion integration.