Skip to content

Unconditionally accept Simplicity spends in the mempool#1477

Merged
psgreco merged 1 commit intomasterfrom
simplicity
Aug 6, 2025
Merged

Unconditionally accept Simplicity spends in the mempool#1477
psgreco merged 1 commit intomasterfrom
simplicity

Conversation

@roconnor-blockstream
Copy link
Contributor

@roconnor-blockstream roconnor-blockstream commented Jul 23, 2025

Taproot and other soft-forks historically in Bitcoin have not gated mempool access.

@roconnor-blockstream
Unconditionally accept Simplicity spends in the mempool
ddda11c 
Taproot and other soft-forks historically in Bitcoin have not gated mempool access.
@roconnor-blockstream
Copy link
Contributor Author

roconnor-blockstream commented Jul 23, 2025

@apoelstra It would be nice to test your hal-simplicity workflow against this PR.

@roconnor-blockstream
Copy link
Contributor Author

roconnor-blockstream commented Jul 23, 2025

This PR is optional, but after reviewing bitcoin/bitcoin#19953 I see that historical Bitcoin activation of similar soft-forks have no mempool logic, and simply allow the new transaction type unconditionally in the next version of the software. Instead they relying on users not to use create such transaction until after activation (or risk having their funds stolen).

To than end this PR slightly simplifies our codebase and bring somewhat more in line with Bitcoin's.

This is a policy change and not a consensus rule change.

delta1
delta1 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ddda11c

Simplicity will already be active on liquidv1 by the time this is released.

@apoelstra
Copy link
Member

apoelstra commented Aug 5, 2025

utACK ddda11c

@roconnor-blockstream
Copy link
Contributor Author

roconnor-blockstream commented Aug 5, 2025

I strongly recommend not merging it until there is a tested ack.

@delta1
Copy link
Member

delta1 commented Aug 6, 2025

ACK ddda11c

Ran tests locally

@roconnor-blockstream
Copy link
Contributor Author

roconnor-blockstream commented Aug 6, 2025

I still suggest that @apoelstra test his hal-simplicity work against this PR.

@psgreco psgreco merged commit 7cb85f1 into master Aug 6, 2025
14 checks passed
@apoelstra apoelstra deleted the simplicity branch August 6, 2025 13:24
delta1 added a commit to delta1/elements that referenced this pull request Aug 8, 2025
@delta1
Merge 7cb85f1 into merged_master (Elements PR ElementsProject#1477)
bce7648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delta1 delta1 delta1 approved these changes

@apoelstra apoelstra Awaiting requested review from apoelstra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roconnor-blockstream @apoelstra @delta1 @psgreco