PropertySetTrackingDto, Arguments as Dictinary<string,object?> #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemurray
reviewed
May 21, 2025
Contributor
Author
|
Removed these lines of code + improve mutation example |
lukemurray
reviewed
May 22, 2025
lukemurray
reviewed
May 22, 2025
Collaborator
|
Thanks for this @BRUS1NATOR - looks like a straightforward way to solve this. I have left a couple of comments. |
lukemurray
added a commit
that referenced
this pull request
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #441. Inherit mutation model from
PropertySetTrackingDtoso you can useIsSet("PROPERTY_NAME")method to check if property was provided in query.Arguments type changed from
Dictionary<string, object>?toDictionary<string, object?>?.I have changed
ProcessArgumentsto return arguments with null value. Please checkBuildArgumentFromMemberfunction, it may not work correctly.