Fix: Include enum-typed input fields in introspection per GraphQL spec #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to the GraphQL spec, enums are valid input types and must not be skipped when constructing input fields. This change ensures enum-typed fields are included during schema introspection.
Motivation and Context
Previously, enum-typed fields were excluded from input values during introspection. This led to a schema that diverged from the GraphQL spec and could break clients relying on enum inputs. This PR removes that exclusion so enums appear correctly in introspection and can be used as intended.
Changes
SchemaIntrospectionwhen building input values.tests/EntityGraphQL.Tests/IntrospectionTests/IntrospectionTests.cs→IncludeEnumInputField_IntrospectionKey edit:
File touched:
src/EntityGraphQL/Schema/SchemaIntrospection.csBackwards Compatibility
Performance Considerations
Tests
IncludeEnumInputField_Introspectionwhich:__type(name: "EnumInputArgs").inputFieldsand asserts theHeightUnitfield is reported asENUM(wrapped inNON_NULL)Documentation
docs/indicating enum input types are supported and appear in introspection.Related Issues/PRs
Checklist