Make parseLayoutVariables public#4638
Merged
TomJaeger merged 1 commit intoExpressionEngine:7.devfrom Jun 16, 2025
Merged
Conversation
Making this public will let me greatly improve how Speedy parses cached templates that use layout variables. $this->layout_vars is already public, along with most other methods to parse globals, vars etc, and even some methods that are prefixed with an underscore, which is usually indicative of a private method.
litzinger
commented
Dec 19, 2024
| { | ||
| $this->log_item("Layout Variables:", $layout_vars); | ||
| $this->layout_conditionals = []; | ||
| $layout_conditionals = []; |
Contributor
Author
There was a problem hiding this comment.
Line 790 attempts to assign a variable to the class property, but it's not created until line 725, or in my case not at all. Add this so it doesn't throw an error.
intoeetive
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making this public will let me greatly improve how Speedy parses cached templates that use layout variables.
$this->layout_vars is already public, along with most other methods to parse globals, vars etc, and even some methods that are prefixed with an underscore, which is usually indicative of a private method. Making this public doesn't feel like it would have adverse side effects?