Improved #4693; show row count on grid fields#4738
Merged
Conversation
robinsowell
requested changes
Jun 13, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
Looks good- we just need to get docs in before release.
I do wonder if there's a better way to achieve what they're doing. And I am still not clear on what they're doing. But as long as docs are clear it's a count rather than a row id, I think it's good.
Collaborator
Author
|
@robinsowell , I added a description. |
robinsowell
approved these changes
Aug 5, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
Looks good- I tweaked the docs a wee bit. It's easy to confuse row id with count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #4693 where show row count on grid fields