Resolved #4708 where superadmins were not able to edit their own secondary roles#4747
Merged
Resolved #4708 where superadmins were not able to edit their own secondary roles#4747
Conversation
robinsowell
previously requested changes
Apr 29, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
Hrm- something is going really wrong. The roles are accessible and the superadmin main role is disabled, so all that is good.
But when I add a new 'regular' role and save, it logs me out and I can't get back in and if I look in the db in exp_members, my role_id is now 0. Switch that back to 1 and I'm ok.
The secondary roles 'stick' and are checked when I can log back in, but it's just setting the primary role id in exp_members to 0
Contributor
|
@robinsowell can you test this one and confirm fix? |
Collaborator
|
It looks correct to me, but I think it would be best if Robin could confirm as well. |
robinsowell
approved these changes
Aug 5, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
Checks out for me- thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #4708 where superadmins were not able to edit their own secondary roles