Resolved #4189 where {if logged_in} variable was parsed late without a reason#4824
Merged
Resolved #4189 where {if logged_in} variable was parsed late without a reason#4824
{if logged_in} variable was parsed late without a reason#4824Conversation
robinsowell
approved these changes
Jun 13, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
tested with:
{if logged_out}
{exp:query sql="SELECT title from exp_channel_titles where entry_id='1'"}
{title}
{/exp:query}
{/if}
{if !segment_3}
{exp:query sql="SELECT title from exp_channel_titles where entry_id='2'"}
{title}
{/exp:query}
{/if}
{if logged_in}
{exp:query sql="SELECT title from exp_channel_titles where entry_id='3'"}
{title}
{/exp:query}
{/if}
test the parsing
Then looked at template debug output queries. Before change, I had 2 queries (with a segment 3), after, I just had the last query.
Looks good! And no errors logged testing logged out and showed expected data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #4189 where
{if logged_in}variable was parsed late without a reasonIt would not hurt if we make it parse a little earlier