Skip to content

Resolved #4772 where MFA dialog could still be shown if set required for member but disabled globally#4845

Merged
TomJaeger merged 2 commits into7.devfrom
bug/7.x/mfa-required-when-disabled
Jun 16, 2025
Merged

Resolved #4772 where MFA dialog could still be shown if set required for member but disabled globally#4845
TomJaeger merged 2 commits into7.devfrom
bug/7.x/mfa-required-when-disabled

Conversation

@intoeetive
Copy link
Contributor

Resolved #4772 where MFA dialog could still be shown if set required for member but disabled globally

@intoeetive intoeetive added this to the 7.5.13 milestone May 15, 2025
@intoeetive intoeetive added the Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on. label May 15, 2025
# Conflicts:
#	system/ee/legacy/libraries/Core.php
@robinsowell robinsowell self-requested a review June 13, 2025 16:41
Copy link
Contributor

@robinsowell robinsowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Test- old code, enable it for site, turn it on for my user. Works. Disable it for site. Now on frontend, I get the verification pop-up just surfing around, not even pages that need login.

Drop in fix- now frontend verification goes away, and I can still login to backend with no verfication box showing.

Go back and re-enable. Still no verfication box frontend were none is supposed to be. Logged out, I do get the verification box logging into the CP.

Also fixed it for a user who was running into the issue.

@TomJaeger TomJaeger merged commit 1c6dcd7 into 7.dev Jun 16, 2025
22 checks passed
@TomJaeger TomJaeger deleted the bug/7.x/mfa-required-when-disabled branch June 16, 2025 14:31
@matthewjohns0n matthewjohns0n mentioned this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MFA is disabled in settings but if it was already 'on' for the user it's still kinda on

3 participants