Resolved #4847 where the Entry Manager could become unusable depending on Column configuration#4848
Merged
TomJaeger merged 4 commits intoExpressionEngine:7.devfrom Jun 16, 2025
Conversation
…array before attempting to use as a Sortable Column
intoeetive
reviewed
Jun 5, 2025
Contributor
intoeetive
left a comment
There was a problem hiding this comment.
@mithra62 do we really need instanceof check here? It looks like isset is sufficient as we always get columns from ColumnFactory
Contributor
Author
|
@intoeetive I wouldn't say "need", as the That said, that conditional being so strict is 100% a stylistic choice more than an immediate concern. More a "provides additional reliability so why not?" choice on my part. |
bryannielsen
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4847 Where the Entry Manager could become unusable depending on Column configuration