Conversation
…cted template is used as layout
matthewjohns0n
previously approved these changes
Aug 26, 2025
Member
matthewjohns0n
left a comment
There was a problem hiding this comment.
This code change looks good to me.
Member
|
@robinsowell I approved this code change, but think it would be best if you checked out the issue and weighed in on it. |
robinsowell
previously approved these changes
Aug 29, 2025
Contributor
robinsowell
left a comment
There was a problem hiding this comment.
Solid!
I agree that we should likely change the wording on the template form, but I also think that should be a seperate issue.
Contributor
|
I'd like to have us get the new unit tests merged in, and run this against those tests. |
8d21931
TomJaeger
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #4881 where "No access redirect" was not performed if restricted template is used as layout